From eeaba49259dbdebe337c8c05fe0b8f558314684c Mon Sep 17 00:00:00 2001 From: David Dworken Date: Tue, 14 Jan 2025 19:29:02 -0700 Subject: [PATCH] Fix test golden breakage caused by GH action update (#284) * Fix test golden breakage caused by GH action update * Update * Trigger action * Update golden * Rename integration_test.go file * Update golden --- README.md | 2 +- client/{client_test.go => integration_test.go} | 0 .../TestTui-ColoredOutputWithCustomColorScheme-linux-actions | 2 +- .../TestTui-ColoredOutputWithDefaultFilter-linux-actions | 2 +- .../TestTui-ColoredOutputWithSearch-Highlight-linux-actions | 2 +- client/testdata/TestTui-ColoredOutputWithSearch-linux-actions | 2 +- 6 files changed, 5 insertions(+), 5 deletions(-) rename client/{client_test.go => integration_test.go} (100%) diff --git a/README.md b/README.md index 473a390..b2abb51 100644 --- a/README.md +++ b/README.md @@ -273,7 +273,7 @@ If you're making code contributions, check out `make help` for some information * Make some local changes (e.g. to fix a bug or add a new feature) * Run `make local-install` to build and install your local version (note that this won't mess up your current hishtory DB!) * ... Repeat until you're happy with your change ... -* Write some tests for your change. Unit tests are great, but we also have a large number of integration tests in `client_test.go` +* Write some tests for your change. Unit tests are great, but we also have a large number of integration tests in `integration_test.go` * Note that the hishtory tests are quite thorough, so running them locally is quite time consuming (and some of them only work on Github Actions). Instead, I recommend using `make ftest` (see `make help` for information on this) to run the specific tests that you're adding/changing. * Open a PR on Github! Once you open the PR, I'll take a look and will trigger Github Actions to run all the tests which will ensure that your change doesn't lead to any reggressions. * [Optional] If you want to switch back to your previously installed hishtory version (rather than your local change), run `make restore` diff --git a/client/client_test.go b/client/integration_test.go similarity index 100% rename from client/client_test.go rename to client/integration_test.go diff --git a/client/testdata/TestTui-ColoredOutputWithCustomColorScheme-linux-actions b/client/testdata/TestTui-ColoredOutputWithCustomColorScheme-linux-actions index 37a7928..0975e62 100644 --- a/client/testdata/TestTui-ColoredOutputWithCustomColorScheme-linux-actions +++ b/client/testdata/TestTui-ColoredOutputWithCustomColorScheme-linux-actions @@ -1,4 +1,4 @@ -Search Query: > ech  +Search Query: > ech  ┌────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Hostname CWD Timestamp Runtime Exit Code Command │ diff --git a/client/testdata/TestTui-ColoredOutputWithDefaultFilter-linux-actions b/client/testdata/TestTui-ColoredOutputWithDefaultFilter-linux-actions index 94838e1..ac776da 100644 --- a/client/testdata/TestTui-ColoredOutputWithDefaultFilter-linux-actions +++ b/client/testdata/TestTui-ColoredOutputWithDefaultFilter-linux-actions @@ -1,4 +1,4 @@ -Search Query: [exit_code:0] ech  +Search Query: [exit_code:0] ech  ┌────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Hostname CWD Timestamp Runtime Exit Code Command │ diff --git a/client/testdata/TestTui-ColoredOutputWithSearch-Highlight-linux-actions b/client/testdata/TestTui-ColoredOutputWithSearch-Highlight-linux-actions index cbf9bb7..96c2fcc 100644 --- a/client/testdata/TestTui-ColoredOutputWithSearch-Highlight-linux-actions +++ b/client/testdata/TestTui-ColoredOutputWithSearch-Highlight-linux-actions @@ -1,4 +1,4 @@ -Search Query: > ech  +Search Query: > ech  ┌────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Hostname CWD Timestamp Runtime Exit Code Command │ diff --git a/client/testdata/TestTui-ColoredOutputWithSearch-linux-actions b/client/testdata/TestTui-ColoredOutputWithSearch-linux-actions index b39e6d3..4d4537d 100644 --- a/client/testdata/TestTui-ColoredOutputWithSearch-linux-actions +++ b/client/testdata/TestTui-ColoredOutputWithSearch-linux-actions @@ -1,4 +1,4 @@ -Search Query: > ech  +Search Query: > ech  ┌────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Hostname CWD Timestamp Runtime Exit Code Command │