extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-02-17 02:50:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Increment the test_retry_count metric for failures too to ensure that it captures tests that fail all retries

Browse Source
This commit is contained in:
David Dworken 2023-09-17 23:07:10 -07:00
parent f64362fbba
commit f589a0b1ba
No known key found for this signature in database
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/client_test.go
View File

@ -207,7 +207,7 @@ func runTestsWithRetries(parentT *testing.T, testName string, testFunc func(t te
func runTestsWithExtraRetries(parentT *testing.T, testName string, testFunc func(t testing.TB), numRetries int) { func runTestsWithExtraRetries(parentT *testing.T, testName string, testFunc func(t testing.TB), numRetries int) {
for i := 1; i <= numRetries; i++ { for i := 1; i <= numRetries; i++ {
rt := &retryingTester{nil, i == numRetries, true, testName} rt := &retryingTester{nil, i == numRetries, true, testName, numRetries}
parentT.Run(fmt.Sprintf("%s/%d", testName, i), func(t *testing.T) { parentT.Run(fmt.Sprintf("%s/%d", testName, i), func(t *testing.T) {
rt.T = t rt.T = t
testFunc(rt) testFunc(rt)
@ -231,6 +231,7 @@ type retryingTester struct {
isFinalRun bool isFinalRun bool
succeeded bool succeeded bool
testName string testName string
numRetries int
} }
func (t *retryingTester) Fatalf(format string, args ...any) { func (t *retryingTester) Fatalf(format string, args ...any) {
@ -239,6 +240,7 @@ func (t *retryingTester) Fatalf(format string, args ...any) {
if t.isFinalRun { if t.isFinalRun {
if GLOBAL_STATSD != nil { if GLOBAL_STATSD != nil {
GLOBAL_STATSD.Incr("test_failure", []string{"test:" + t.testName, "os:" + runtime.GOOS}, 1.0) GLOBAL_STATSD.Incr("test_failure", []string{"test:" + t.testName, "os:" + runtime.GOOS}, 1.0)
GLOBAL_STATSD.Distribution("test_retry_count", float64(t.numRetries), []string{"test:" + t.testName, "os:" + runtime.GOOS}, 1.0)
} }
t.T.Fatalf(format, args...) t.T.Fatalf(format, args...)
} else { } else {