Silence go-errcheck warning for fmt.Fprintf logging

This commit is contained in:
David Dworken 2023-09-30 07:25:58 -07:00
parent f3764b2545
commit f9372dda75
No known key found for this signature in database

View File

@ -87,7 +87,7 @@ func withLogging(s *statsd.Client, out io.Writer) Middleware {
// log panics // log panics
if err := recover(); err != nil { if err := recover(); err != nil {
duration := time.Since(start) duration := time.Since(start)
fmt.Fprintf(out, "%s %s %#v %s %s %s %v\n", getRemoteAddr(r), r.Method, r.RequestURI, getHishtoryVersion(r), duration.String(), byteCountToString(responseData.size), err) _, _ = fmt.Fprintf(out, "%s %s %#v %s %s %s %v\n", getRemoteAddr(r), r.Method, r.RequestURI, getHishtoryVersion(r), duration.String(), byteCountToString(responseData.size), err)
// keep panicking // keep panicking
panic(err) panic(err)
@ -97,7 +97,7 @@ func withLogging(s *statsd.Client, out io.Writer) Middleware {
h.ServeHTTP(&lrw, r.WithContext(ctx)) h.ServeHTTP(&lrw, r.WithContext(ctx))
duration := time.Since(start) duration := time.Since(start)
fmt.Fprintf(out, "%s %s %#v %s %s %s\n", getRemoteAddr(r), r.Method, r.RequestURI, getHishtoryVersion(r), duration.String(), byteCountToString(responseData.size)) _, _ = fmt.Fprintf(out, "%s %s %#v %s %s %s\n", getRemoteAddr(r), r.Method, r.RequestURI, getHishtoryVersion(r), duration.String(), byteCountToString(responseData.size))
if s != nil { if s != nil {
s.Distribution("hishtory.request_duration", float64(duration.Microseconds())/1_000, []string{"handler:" + getFunctionName(h)}, 1.0) s.Distribution("hishtory.request_duration", float64(duration.Microseconds())/1_000, []string{"handler:" + getFunctionName(h)}, 1.0)
s.Incr("hishtory.request", []string{"handler:" + getFunctionName(h)}, 1.0) s.Incr("hishtory.request", []string{"handler:" + getFunctionName(h)}, 1.0)