extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-08-09 23:17:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix unescape function per comments on #73 and add tests for searching for a backslash

Browse Source
This commit is contained in:
David Dworken
2023-02-20 15:46:39 -08:00
parent dddedcf9a7
commit ff24b66fce
2 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
client/lib/lib_test.go
View File

@ -281,6 +281,14 @@ func TestSearch(t *testing.T) {
if len(results) != 3 {
t.Fatalf("Search() returned %d results, expected 3, results=%#v", len(results), results)
}
// A search for an entry containing a backslash
testutils.Check(t, db.Create(testutils.MakeFakeHistoryEntry("echo '\\'")).Error)
results, err = Search(ctx, db, "\\\\", 5)
testutils.Check(t, err)
if len(results) != 1 {
t.Fatalf("Search() returned %d results, expected 3, results=%#v", len(results), results)
}
}
func TestAddToDbIfNew(t *testing.T) {
@ -487,7 +495,7 @@ func TestParseTimeGenerously(t *testing.T) {
}
}
func TestStripBackslash(t *testing.T) {
func TestUnescape(t *testing.T) {
testcases := []struct {
input string
output string
@ -498,10 +506,11 @@ func TestStripBackslash(t *testing.T) {
{"f\\:bar\\", "f:bar"},
{"\\f\\:bar\\", "f:bar"},
{"", ""},
{"\\\\", ""},
{"\\", ""},
{"\\\\", "\\"},
}
for _, tc := range testcases {
actual := stripBackslash(tc.input)
actual := unescape(tc.input)
if !reflect.DeepEqual(actual, tc.output) {
t.Fatalf("unescape failure for %#v, actual=%#v", tc.input, actual)
}