Commit Graph

919 Commits

Author SHA1 Message Date
David Dworken
d4e01ceb11 Add another error message substring for detecting errors due to being offline, to improve #30 2023-09-13 22:49:40 -07:00
David Dworken
e8ceb02138 Move tui.go out of lib and into a separate package 2023-09-13 22:47:48 -07:00
David Dworken
6d6a1a5e12 Move a bunch of update-specific code out of the generic lib.go file and into the update command 2023-09-13 22:45:49 -07:00
David Dworken
f3e4a4e1e6 Disable tquery test that is failing on github actions 2023-09-13 21:56:58 -07:00
David Dworken
b6b4dbe37a Add tests for presaving history entries 2023-09-13 20:29:06 -07:00
David Dworken
6540b4dbf6 Improve logged error messages for API failures 2023-09-13 20:24:25 -07:00
David Dworken
a039b19b9c Change root command name to all lower case so that the cobra-generated examples work correctly on case-sensitive file systems 2023-09-13 19:46:49 -07:00
David Dworken
763c8208f7 Make RetryingDbFunction more lenient so that it always ignores UNIQUE constraint errors, since if a DB.Create returns a UNIQUE error, then the create is not actually necessary 2023-09-13 19:20:15 -07:00
David Dworken
f1e2b8ddbf Update TestSortByConsistentTimezone to not use a golden for tquery since it was leading to occasional flakes, and swap it to using a regex. Also add a test for hishtory export as part of the sorting tests. 2023-09-12 19:09:01 -07:00
David Dworken
57c5a69f7d Fix bug where we failed to delete pre-saved history entries due to race conditions causing the DB to be locked 2023-09-12 18:55:13 -07:00
David Dworken
aebf526d1f Add TODO for a theoretical bug I noticed 2023-09-12 17:51:55 -07:00
David Dworken
c311b09844 Improve error messages when we fail to delete pre-saved history entries 2023-09-12 15:53:52 -07:00
Sergio Moura
2b3912c750 fix check for empty array result 2023-09-11 16:34:22 -04:00
David Dworken
9b871e93ed Fix consistent time zone sorting test to account for table sizing differences on github actions 2023-09-10 17:13:48 -07:00
David Dworken
c269e7832e Release v0.212 2023-09-09 15:17:55 -07:00
David Dworken
e3e3a7bd0d Add tablesizing command to get consistent table dimensions 2023-09-09 14:02:47 -07:00
David Dworken
2ccbb8d587 Store timestamps in DB in Unix time, and display them in the Local time for consistent TZs in displays, and to ensure ordering is correct
This fixes a bug where entries could be out of order if they were recorded on machines in different TZs (e.g. if one machine had the TZ set to UTC). Admittedly, this commit isn't a perfect fix since
it doesn't change all the existing hishtory entries to be stored in UTC, but this just means that the ordering bug will continue to exist for historical entries, but be fixed for new entries. And
for our purposes, that is good enough. :)

 # Please enter the commit message for your changes. Lines starting
2023-09-09 12:28:01 -07:00
David Dworken
223598c8f2 Remove golden that was forked for actions, that didn't need to be 2023-09-09 11:56:06 -07:00
David Dworken
b6b4499a42 Add a few more ExtraDelays + comments to further improve test reliability 2023-09-09 11:50:07 -07:00
David Dworken
4d7e685a6e Add ExtraDelay to make testTui/delete more reliable 2023-09-08 19:44:36 -07:00
David Dworken
ba099c384b Add statsd incr for overall test failure 2023-09-08 19:40:10 -07:00
David Dworken
27d5c59263 Skip datadog integratio on macos if colima fails to start, since colima appears to be flaky due to a code signing error 2023-09-08 19:27:16 -07:00
David Dworken
3a8243d25d Another set of extra delays for testTui/search, similar to 37c06a31db 2023-09-08 10:09:01 -07:00
David Dworken
cc10689d09 Skip running DD on non-master branches so that PRs can run successfully 2023-09-08 09:59:55 -07:00
David Dworken
37c06a31db Add extra delay before adding token that makes it an invalid search query to make the race condition less likely 2023-09-08 09:53:39 -07:00
David Dworken
3448c3fdf6 Add hishtory export test as a pre-req for testTui/search to ensure that entries are getting properly stored 2023-09-07 22:18:16 -07:00
David Dworken
519a7ba706 Add OS tag for datadog test export 2023-09-07 22:03:03 -07:00
David Dworken
e5864c9a16 Fix datadog tags to be passed as key/values 2023-09-07 21:05:30 -07:00
David Dworken
a13549851c Add basic datadog integration to monitor test failures in github actions 2023-09-07 18:30:47 -07:00
David Dworken
4bc23c9575 Add additional information about sync status to hishtory status -v for debugging purposes 2023-09-07 18:10:17 -07:00
David Dworken
c73b10011b Add TODO for a bug where sorting entries by timestamps in different timezones causes issues 2023-09-07 18:09:30 -07:00
David Dworken
578113e07c Revert "use errors.Is to determine what the error is" since it doesn't work with modernc.org/sqlite which we need in order to avoid using CGO (which we do to enable easy cross-compiles)
This reverts commit 1589f77956. When building with CGO_ENABLED=0, this code will fail to build.
2023-09-06 20:21:00 -07:00
David Dworken
d80afc27d4 Clear out ~/.other-path/ in tests since it wasn't getting cleared, which meant retries were guaranteed to fail for this function 2023-09-06 20:13:36 -07:00
David Dworken
c5bdee9ad5 Merge pull request #102 from lsmoura/sergio/no-ctx-ptr
Remove context pointers since there is no need to pass around a pointer to an interface
2023-09-06 19:58:08 -07:00
Sergio Moura
ce6484f465 constant context keys 2023-09-05 15:54:47 -04:00
Sergio Moura
a12b0e5f6f no context pointers 2023-09-05 15:45:17 -04:00
Sergio Moura
1589f77956 use errors.Is to determine what the error is 2023-09-05 15:37:42 -04:00
Sergio Moura
83ad8c7b1f wrap errors with %w instead of using %v 2023-09-05 15:08:55 -04:00
David Dworken
f778c1b2b6 Increase number of retries for all retriable tests on github actions 2023-09-04 21:21:13 -07:00
David Dworken
fd018fa759 Increase number of retries for testTui/search since that method appears to be the flakiest on github actions 2023-09-04 18:57:00 -07:00
David Dworken
af0234797c Refactor test retrying functions to make the number of retries configurable, and change the default to 3 retries (I'll be tuning this number in a follow up commit) 2023-09-04 18:17:02 -07:00
David Dworken
7b02d6f2a2 Update testTui setup function to ensure that entries are also added in the remote server and not just locally, to ensure they show up post-sync 2023-09-04 18:13:22 -07:00
David Dworken
434acd3738 Increase timeout amount for all github action tests 2023-09-04 18:09:11 -07:00
David Dworken
c690688834 Implement a few additional methods on retryingTester so it works with testify 2023-09-02 17:49:31 -07:00
David Dworken
58c791b662 Add extra delay before ENTER for searching to ensure that the async query finishes 2023-09-01 21:57:25 -07:00
David Dworken
96d14d3b9f Add extra timing between search and the atom that makes it invalid to ensure that the initial search is processed 2023-09-01 21:54:12 -07:00
David Dworken
f808e3815a Increase num retries for github actions 2023-09-01 16:30:42 -07:00
David Dworken
ab694c38b1 Split testTui again into smaller more specific test functions 2023-09-01 16:28:41 -07:00
David Dworken
1608543a4d Remove TODO 2023-09-01 15:57:11 -07:00
David Dworken
134dba5ddd Auto retry testControlR since it is the other test function that is flaky due to race conditions in screenshot tests 2023-09-01 15:55:13 -07:00