David Dworken
93cffd98b4
Replace e50f4d164 with query IDs so that we properly handle deletions. See e50f4d164 for full details on the bug that this fixes.
2023-10-25 20:07:09 -07:00
David Dworken
e50f4d164b
Fix race condition in TUI code for handling async queries
...
If someone types in "l" and then "s" to search for "ls", then this will dispatch two async queries. If the query for "l" finishes after the query for "ls", then this will lead to the results for "l" getting incorrectly displayed. In practice, this is quite rare for human typing speeds so I had never noticed this. But, it causes an issue for test flakes and is the root cause of many of my recent changes around test flakes. Fixing this should improve test reliability significantly.
2023-10-24 22:52:52 -07:00
David Dworken
bb96164ea8
Revert "Increase delays for testTui/search since it is the flakiest test" since I figured out the source of the flakes
...
This reverts commit 10851528bc
2023-10-24 22:47:36 -07:00
David Dworken
590c4755b5
Revert "Split the flaky testTui/search test into two tests to increase odds of it passing quickly" since I figured out the source of the flakes
...
This reverts commit 352e483db5
2023-10-24 22:47:10 -07:00
David Dworken
df48e516ef
Close dd stats
2023-10-23 19:26:25 -07:00
David Dworken
352e483db5
Split the flaky testTui/search test into two tests to increase odds of it passing quickly
2023-10-23 18:53:16 -07:00
David Dworken
27eeb7d099
Refactor code to strip out the shell prefix to a separate function
2023-10-23 12:24:43 -07:00
David Dworken
10851528bc
Increase delays for testTui/search since it is the flakiest test
2023-10-23 12:13:40 -07:00
David Dworken
ff79707ccf
Use unqualified test name as test ID since the full package makes the datadog metrics overly verbose
2023-10-22 20:57:21 -07:00
David Dworken
982f7b5f02
Add extra delay to see if that allows DD metrics to go through
2023-10-22 19:37:09 -07:00
David Dworken
0413e88321
Add flush call to metrics exporter so that metrics are flushed before the github action is killed
2023-10-22 18:10:49 -07:00
David Dworken
13233926a7
Fix test broken by 9433bd6e94
2023-10-22 17:59:21 -07:00
David Dworken
bfce9d4b1c
Add space to fix test that was broken by previous refactoring
2023-10-22 17:21:36 -07:00
David Dworken
238177897e
Swap to cloning gotestsum over https:// rather than SSH to fix auth
2023-10-22 17:09:13 -07:00
David Dworken
772ab6cc87
Update makefile to use my forked version of gotestsum that contains https://github.com/gotestyourself/gotestsum/pull/377
2023-10-22 17:06:36 -07:00
David Dworken
d463d99916
Reorder if in test metrics exporter so that it actually skips initializing DD when there is no DD api key
2023-10-22 12:01:51 -07:00
David Dworken
0f99c7996e
Follow up to 083569be17: What if we just change the message we print on the server-side so that it doesn't trigger gotestsum?
2023-10-22 11:46:11 -07:00
David Dworken
2b1af986d8
Add support for running hishtory redact while offline, even though this may lead to syncing inconsistency bugs
2023-10-22 11:43:56 -07:00
David Dworken
c613e696b4
Update hishtory redact so that it doesn't error out due to it redacting the presaved entry for the current command
2023-10-22 11:34:26 -07:00
David Dworken
fdbe91246e
Add another hook point to check HISHTORY_SIMULATE_NETWORK_ERROR so that it also blocks downloading updates
2023-10-22 11:30:49 -07:00
David Dworken
9433bd6e94
Refactor offline simulation tests so that they reliably set the env variable before ever starting the shell, since we need the env variable to also apply to presaving
2023-10-22 11:28:41 -07:00
David Dworken
53580d40e9
Remove TODOs for adding data to context that I think is actually fine to keep in the request as-is
2023-10-22 11:17:06 -07:00
David Dworken
956ac736f2
Update metrics exporter output to include whether GLOBAL_STATSD is nil
2023-10-22 11:14:25 -07:00
David Dworken
6e1589c1d8
Update github actions to export the test results json for both OSs, and to do it even if the test are an overall failure
2023-10-22 11:12:11 -07:00
David Dworken
083569be17
Move output prefix from 60d388c4c2 to the inner test
2023-10-22 11:07:59 -07:00
David Dworken
8b9e3dfb10
Export testrun.json as a file so that we can also download it for manual inspection/processing
2023-10-22 00:21:47 -07:00
David Dworken
60d388c4c2
Add one more print similar to b6885cca98 that was missed in that commit
2023-10-22 00:19:34 -07:00
David Dworken
ff0d2c34d6
Add print line after finishing upload of DD metrics
2023-10-21 17:14:49 -07:00
David Dworken
b6885cca98
Attempt to fix gotestsum skipping tests by adding a prefix so that test output doesn't begin with panic:
2023-10-21 17:03:04 -07:00
David Dworken
50c6f5e061
Skip tests that cause gotestsum to skip re-running
2023-10-21 16:59:42 -07:00
David Dworken
3d4e48aabd
Add test runtime metric
2023-10-21 16:42:41 -07:00
David Dworken
4e15bab9be
Add missing go get hash
2023-10-21 16:35:04 -07:00
David Dworken
595ddec235
Add integration to report flaky tests to datadog
2023-10-21 16:28:28 -07:00
David Dworken
1d29bb25e9
Increase timeout since the control-r test is extremely slow
2023-10-21 16:21:52 -07:00
David Dworken
8805e57c6f
Change order of gotestsum arguments
2023-10-21 15:52:32 -07:00
David Dworken
df9c6e8786
Swap to using gotestsum for retrying flaky tests
2023-10-21 15:41:32 -07:00
David Dworken
4e0788dccc
Update more test code to use require rather than manual failures
2023-10-21 14:59:12 -07:00
David Dworken
5ec9f85e5e
Fix broken test on ubuntu that was introduced in 08e734a
2023-10-21 13:44:08 -07:00
David Dworken
4751004d7e
Add TODO
2023-10-21 09:48:36 -07:00
David Dworken
6bb12241c9
Promote the background updates of the DB from BetaMode to prod
2023-10-21 09:47:20 -07:00
David Dworken
08e734a1fe
Add tests to verify the fix for #117
2023-10-21 09:00:06 -07:00
David Dworken
1fc17e3296
Release v0.238
2023-10-21 00:30:06 -07:00
David Dworken
3ca9de559f
Fix #117 by disown-ing background processes so that they don't stop fish from exiting
2023-10-20 23:23:24 -07:00
David Dworken
332bfbb388
Release v0.237
2023-10-18 20:29:25 -07:00
David Dworken
9efef65e3a
Update README and make column name matching more relaxed
2023-10-18 19:17:05 -07:00
David Dworken
8274534be1
Update README
2023-10-18 19:12:14 -07:00
David Dworken
a937b35e54
Avoid returning DB error when deleted message identifiers don't have a device ID
2023-10-18 18:59:12 -07:00
David Dworken
f1ca76a5a0
Extra delay to make test more reliable
2023-10-15 21:47:01 -07:00
David Dworken
0fec2d5ba9
Ensure that the DB entry is reliably created locally and in the remote for testTui/scroll to make it more reliable
2023-10-15 21:45:20 -07:00
David Dworken
4202e057ef
Update docker compose test to ensure that the redaction worked
2023-10-15 19:05:32 -07:00
