Commit Graph

472 Commits

Author SHA1 Message Date
354f2872d6 Improve testPresaving to cover more potential errors with presaving 2023-09-24 16:35:40 -07:00
5121df5a8c Remove testutils.Check(t, err) and replace it with require.NoError which gives a clearer error message and a full stacktrace 2023-09-24 16:05:01 -07:00
cb95d4a396 More test reliability improvements to fix all test failure root causes from 10 sample runs on Github Actions 2023-09-24 06:29:47 -07:00
ce9602d0df Make testControlR more reliable in cases where control-R doesn't include padding 2023-09-24 06:25:08 -07:00
ab12fa4d47 Fix consistency bug where ClientConfig would get out of date between different parts of the code 2023-09-23 12:40:57 -07:00
eb1bc99a22 Add extra delay for testTui_delete test that relies on syncing, which can be slow 2023-09-23 10:58:48 -07:00
68c6bd6654 Improve TestTimestampFormat 2023-09-23 10:56:27 -07:00
e886763144 Make testCustomColumns simpler and more reliable 2023-09-23 05:34:36 -07:00
61c8e26f89 Revert "Make testControlR more reliable by making it more lenient in how it looks for the separator"
This reverts commit 5168efb2c8.
2023-09-22 21:18:29 -07:00
d613c22e50 Move a bunch of utility functions for tests to a testutils.go file to make client_test.go at least a little shorter 2023-09-22 20:19:12 -07:00
5168efb2c8 Make testControlR more reliable by making it more lenient in how it looks for the separator 2023-09-22 20:03:41 -07:00
2a5a6d65c4 Roll-forward "Add preliminary support for persisting pre-saved history entries remotely"
This rolls-forward commit 66916c27cb.
2023-09-22 13:13:46 -07:00
dc166ec089 Move fuzz tests to a separate file and add a couple more tests to it 2023-09-22 08:43:58 -07:00
66916c27cb Revert "Add preliminary support for persisting pre-saved history entries remotely"
This reverts commit ff98a7907c. That commit is incomplete since it doesn't include support for the continous deletion of pre-saved history entries as soon as they
finish running. Support for this will require a good bit more work/thought, so reverting for and keeping this code in the git history.
2023-09-21 12:39:20 -07:00
ff98a7907c Add preliminary support for persisting pre-saved history entries remotely 2023-09-21 12:39:04 -07:00
1e43de689f Optimize number of round-trip HTTP connections made by the client by having the submit handler return metadata about whether there are pending dump/deletion requests
For now, I'm still keeping the dedicated endpoints for those functionalities, but since most of the time there are no dump/deletion requests this should cut down the number of requests made by the client by 2/3.
2023-09-21 11:35:24 -07:00
216803f325 Bring back logic that was removed in c9da7a10e4 that made it so invalid initial search queries will get replaced with a query for the empty string 2023-09-18 22:21:10 -07:00
f589a0b1ba Increment the test_retry_count metric for failures too to ensure that it captures tests that fail all retries 2023-09-17 23:07:10 -07:00
48e33d5034 Make the query input box in the TUI match the terminal dimensions 2023-09-14 21:14:16 -07:00
f3e4a4e1e6 Disable tquery test that is failing on github actions 2023-09-13 21:56:58 -07:00
b6b4dbe37a Add tests for presaving history entries 2023-09-13 20:29:06 -07:00
f1e2b8ddbf Update TestSortByConsistentTimezone to not use a golden for tquery since it was leading to occasional flakes, and swap it to using a regex. Also add a test for hishtory export as part of the sorting tests. 2023-09-12 19:09:01 -07:00
2b3912c750 fix check for empty array result 2023-09-11 16:34:22 -04:00
9b871e93ed Fix consistent time zone sorting test to account for table sizing differences on github actions 2023-09-10 17:13:48 -07:00
c269e7832e Release v0.212 2023-09-09 15:17:55 -07:00
e3e3a7bd0d Add tablesizing command to get consistent table dimensions 2023-09-09 14:02:47 -07:00
2ccbb8d587 Store timestamps in DB in Unix time, and display them in the Local time for consistent TZs in displays, and to ensure ordering is correct
This fixes a bug where entries could be out of order if they were recorded on machines in different TZs (e.g. if one machine had the TZ set to UTC). Admittedly, this commit isn't a perfect fix since
it doesn't change all the existing hishtory entries to be stored in UTC, but this just means that the ordering bug will continue to exist for historical entries, but be fixed for new entries. And
for our purposes, that is good enough. :)

 # Please enter the commit message for your changes. Lines starting
2023-09-09 12:28:01 -07:00
223598c8f2 Remove golden that was forked for actions, that didn't need to be 2023-09-09 11:56:06 -07:00
b6b4499a42 Add a few more ExtraDelays + comments to further improve test reliability 2023-09-09 11:50:07 -07:00
4d7e685a6e Add ExtraDelay to make testTui/delete more reliable 2023-09-08 19:44:36 -07:00
ba099c384b Add statsd incr for overall test failure 2023-09-08 19:40:10 -07:00
27d5c59263 Skip datadog integratio on macos if colima fails to start, since colima appears to be flaky due to a code signing error 2023-09-08 19:27:16 -07:00
3a8243d25d Another set of extra delays for testTui/search, similar to 37c06a31db 2023-09-08 10:09:01 -07:00
cc10689d09 Skip running DD on non-master branches so that PRs can run successfully 2023-09-08 09:59:55 -07:00
37c06a31db Add extra delay before adding token that makes it an invalid search query to make the race condition less likely 2023-09-08 09:53:39 -07:00
3448c3fdf6 Add hishtory export test as a pre-req for testTui/search to ensure that entries are getting properly stored 2023-09-07 22:18:16 -07:00
519a7ba706 Add OS tag for datadog test export 2023-09-07 22:03:03 -07:00
e5864c9a16 Fix datadog tags to be passed as key/values 2023-09-07 21:05:30 -07:00
a13549851c Add basic datadog integration to monitor test failures in github actions 2023-09-07 18:30:47 -07:00
d80afc27d4 Clear out ~/.other-path/ in tests since it wasn't getting cleared, which meant retries were guaranteed to fail for this function 2023-09-06 20:13:36 -07:00
83ad8c7b1f wrap errors with %w instead of using %v 2023-09-05 15:08:55 -04:00
f778c1b2b6 Increase number of retries for all retriable tests on github actions 2023-09-04 21:21:13 -07:00
fd018fa759 Increase number of retries for testTui/search since that method appears to be the flakiest on github actions 2023-09-04 18:57:00 -07:00
af0234797c Refactor test retrying functions to make the number of retries configurable, and change the default to 3 retries (I'll be tuning this number in a follow up commit) 2023-09-04 18:17:02 -07:00
7b02d6f2a2 Update testTui setup function to ensure that entries are also added in the remote server and not just locally, to ensure they show up post-sync 2023-09-04 18:13:22 -07:00
434acd3738 Increase timeout amount for all github action tests 2023-09-04 18:09:11 -07:00
c690688834 Implement a few additional methods on retryingTester so it works with testify 2023-09-02 17:49:31 -07:00
58c791b662 Add extra delay before ENTER for searching to ensure that the async query finishes 2023-09-01 21:57:25 -07:00
96d14d3b9f Add extra timing between search and the atom that makes it invalid to ensure that the initial search is processed 2023-09-01 21:54:12 -07:00
f808e3815a Increase num retries for github actions 2023-09-01 16:30:42 -07:00