David Dworken
aa3c7fc41a
Follow up to #103 : assign err from fmt.Fprintf to _ to ensure go-errcheck doesn't flag it
2023-09-07 07:57:20 -07:00
David Dworken
68e3a813c9
Follow up to #103 : pull context from r.Context() when used rather than at the start of functions
2023-09-07 07:56:03 -07:00
David Dworken
86c0acfbc8
Merge pull request #103 from lsmoura/sergio/handlers
...
Use the existing HTTP request context and modify server to always return a 200 response code even when there is no associated response
2023-09-07 07:48:16 -07:00
Sergio Moura
e6d922709d
fix tests
2023-09-07 09:50:36 -04:00
Sergio Moura
37670230af
Merge remote-tracking branch 'origin/master' into sergio/handlers
2023-09-07 09:33:42 -04:00
Sergio Moura
589b99e500
do not use http.StatusNoContent
2023-09-07 08:34:21 -04:00
David Dworken
2a95553fdf
Fix install.py script for arm7 so installs work on raspberry pis
2023-09-06 21:35:28 -07:00
David Dworken
578113e07c
Revert "use errors.Is to determine what the error is" since it doesn't work with modernc.org/sqlite which we need in order to avoid using CGO (which we do to enable easy cross-compiles)
...
This reverts commit 1589f77956
2023-09-06 20:21:00 -07:00
David Dworken
d80afc27d4
Clear out ~/.other-path/ in tests since it wasn't getting cleared, which meant retries were guaranteed to fail for this function
2023-09-06 20:13:36 -07:00
David Dworken
c5bdee9ad5
Merge pull request #102 from lsmoura/sergio/no-ctx-ptr
...
Remove context pointers since there is no need to pass around a pointer to an interface
2023-09-06 19:58:08 -07:00
David Dworken
02d04928d5
Merge pull request #101 from lsmoura/sergio/wrap-errors
...
Wrap errors
2023-09-06 19:56:29 -07:00
Sergio Moura
2b1ba7e3ba
use single context and always return a status to the client
...
api handlers do not need an extra context. http.Request already has a context that is being ignored, so we leverage it and stop creating a new one.
make the endpoints return http.StatusNoContent instead of just closing the connection from the client.
2023-09-06 11:37:14 -04:00
Sergio Moura
ce6484f465
constant context keys
2023-09-05 15:54:47 -04:00
Sergio Moura
a12b0e5f6f
no context pointers
2023-09-05 15:45:17 -04:00
Sergio Moura
1589f77956
use errors.Is to determine what the error is
2023-09-05 15:37:42 -04:00
Sergio Moura
83ad8c7b1f
wrap errors with %w instead of using %v
2023-09-05 15:08:55 -04:00
David Dworken
efa9ddd6df
Upgrade checkout action
2023-09-04 21:23:22 -07:00
David Dworken
f778c1b2b6
Increase number of retries for all retriable tests on github actions
2023-09-04 21:21:13 -07:00
David Dworken
adbd87a81e
Clear out ~/.hishtory/ between test retries to ensure state is cleared for a fresh run
2023-09-04 21:16:22 -07:00
David Dworken
22abfbc733
Add overall test retries for all tests to make github action tests even more reliable
2023-09-04 19:30:38 -07:00
David Dworken
fd018fa759
Increase number of retries for testTui/search since that method appears to be the flakiest on github actions
2023-09-04 18:57:00 -07:00
David Dworken
af0234797c
Refactor test retrying functions to make the number of retries configurable, and change the default to 3 retries (I'll be tuning this number in a follow up commit)
2023-09-04 18:17:02 -07:00
David Dworken
7b02d6f2a2
Update testTui setup function to ensure that entries are also added in the remote server and not just locally, to ensure they show up post-sync
2023-09-04 18:13:22 -07:00
David Dworken
434acd3738
Increase timeout amount for all github action tests
2023-09-04 18:09:11 -07:00
David Dworken
25eae144d8
Revert all tmpfs related commits, since running in a tmpfs doesn't seem to meaningfully improve test reliability
2023-09-04 18:03:46 -07:00
David Dworken
9b06e6980a
Revert 2ca6c751d0 and instead have BackupAndRestore keep files on the same mount point
2023-09-02 20:09:22 -07:00
David Dworken
2ca6c751d0
Avoid constantly copying the binary back and forth to make tests faster on github actions
2023-09-02 19:51:43 -07:00
David Dworken
6950215427
Increase test timeout to account for copies being slower than renames
2023-09-02 19:47:59 -07:00
David Dworken
c0f33a3456
Swap from os.Rename to a custom implementation that copies files to support cross-device renames, as needed for making ~/.hishtory/ a tmpfs for tests
2023-09-02 18:50:52 -07:00
David Dworken
069705ef41
Move setting of TZ variable into Makefile so it is always set even if doing local development in a different timezone
2023-09-02 18:28:37 -07:00
David Dworken
a2617e970a
Fix tmpfs creation for macos
2023-09-02 18:25:09 -07:00
David Dworken
9de10560a6
Re-enable tmate debugging
2023-09-02 18:17:16 -07:00
David Dworken
9dafa40872
Remove || true to force macos setup to complete successfully
2023-09-02 18:16:53 -07:00
David Dworken
4c2e49885f
Fix tmpfs mount command for linux
2023-09-02 18:11:29 -07:00
David Dworken
46b2d5a26a
Enable tmate for debugging
2023-09-02 18:06:46 -07:00
David Dworken
f0bd50dac6
Fix string quotes in github actions template
2023-09-02 18:04:31 -07:00
David Dworken
d9893397b7
Split test setup into separate stages for each OS
2023-09-02 18:03:26 -07:00
David Dworken
d51dba8375
Split tests and setup into different stages
2023-09-02 17:58:36 -07:00
David Dworken
c690688834
Implement a few additional methods on retryingTester so it works with testify
2023-09-02 17:49:31 -07:00
David Dworken
0ee8c1c796
Add sudo for ram disk creation
2023-09-02 17:35:22 -07:00
David Dworken
96446eb62c
Configure a ram disk for ~/.hishtory/ to make sqlite run faster
2023-09-02 17:33:02 -07:00
David Dworken
58c791b662
Add extra delay before ENTER for searching to ensure that the async query finishes
2023-09-01 21:57:25 -07:00
David Dworken
96d14d3b9f
Add extra timing between search and the atom that makes it invalid to ensure that the initial search is processed
2023-09-01 21:54:12 -07:00
David Dworken
f808e3815a
Increase num retries for github actions
2023-09-01 16:30:42 -07:00
David Dworken
ab694c38b1
Split testTui again into smaller more specific test functions
2023-09-01 16:28:41 -07:00
David Dworken
1608543a4d
Remove TODO
2023-09-01 15:57:11 -07:00
David Dworken
134dba5ddd
Auto retry testControlR since it is the other test function that is flaky due to race conditions in screenshot tests
2023-09-01 15:55:13 -07:00
David Dworken
3b07aa9a37
Split testTui method into separate smaller test methods that are more specific
2023-09-01 15:42:02 -07:00
David Dworken
21e2370d98
Rework delays to primarily only do a delay before capturing output, since that is the critical time for async rendering
2023-09-01 11:23:03 -07:00
David Dworken
9fdd676ed5
Increase test timeout since github actions tests are slow on macos
2023-08-30 11:13:18 -07:00
