From d7e17e6146d8d5f84c71cbd0f3f684467bebb4f6 Mon Sep 17 00:00:00 2001
From: Robin Schneider <45321827+robinschneider@users.noreply.github.com>
Date: Fri, 8 Oct 2021 17:50:19 +0200
Subject: [PATCH 1/8] Spelling fix

---
 .github/PULL_REQUEST_TEMPLATE.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 0746863..e0063d5 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -14,5 +14,5 @@ Fixes # (issue)
 
 - [ ] I've read & comply with the [contributing guidelines](https://github.com/bastienwirtz/homer/blob/main/CONTRIBUTING.md)
 - [ ] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers. 
-- [ ] I have made corresponding changes the documentation (README.md).
+- [ ] I have made corresponding changes to the documentation (README.md).
 - [ ] I've checked my modifications for any breaking changes, especially in the `config.yml` file

From a25e1b1a70649f4a0341056cca0669d4b7d78fb5 Mon Sep 17 00:00:00 2001
From: Bastien Wirtz <bastien.wirtz@gmail.com>
Date: Sun, 10 Oct 2021 09:23:35 +0200
Subject: [PATCH 2/8] Auto PR lint

---
 .github/workflows/integration.yml           | 31 +++++++++++++++++++++
 .github/workflows/{main.yml => release.yml} |  0
 2 files changed, 31 insertions(+)
 create mode 100644 .github/workflows/integration.yml
 rename .github/workflows/{main.yml => release.yml} (100%)

diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
new file mode 100644
index 0000000..196113d
--- /dev/null
+++ b/.github/workflows/integration.yml
@@ -0,0 +1,31 @@
+# This workflow will do a clean install of node dependencies, cache/restore them, build the source code and run tests across different versions of node
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+
+name: Node.js CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [16.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ matrix.node-version }}
+        cache: 'yarn'
+    - run: yarn install
+    - run: yarn lint
+
diff --git a/.github/workflows/main.yml b/.github/workflows/release.yml
similarity index 100%
rename from .github/workflows/main.yml
rename to .github/workflows/release.yml

From 0a3be103dc02182af7cd5e92fdd6130e3198e1a7 Mon Sep 17 00:00:00 2001
From: Bastien Wirtz <bastien.wirtz@gmail.com>
Date: Sun, 10 Oct 2021 09:26:02 +0200
Subject: [PATCH 3/8] Factorize fetch options

---
 src/App.vue                             |  6 ++++--
 src/assets/defaults.yml                 |  3 +++
 src/components/Service.vue              |  3 ++-
 src/components/services/AdGuardHome.vue | 18 +++++++---------
 src/mixins/service.js                   | 28 +++++++++++++++++++++++++
 5 files changed, 45 insertions(+), 13 deletions(-)
 create mode 100644 src/mixins/service.js

diff --git a/src/App.vue b/src/App.vue
index 1f4f509..c263c8a 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -74,7 +74,8 @@
               <Service
                 v-for="(item, index) in group.items"
                 :key="index"
-                v-bind:item="item"
+                :item="item"
+                :proxy="config.proxy"
                 :class="['column', `is-${12 / config.columns}`]"
               />
             </template>
@@ -102,7 +103,8 @@
               <Service
                 v-for="(item, index) in group.items"
                 :key="index"
-                v-bind:item="item"
+                :item="item"
+                :proxy="config.proxy"
               />
             </div>
           </div>
diff --git a/src/assets/defaults.yml b/src/assets/defaults.yml
index f011346..ae4f523 100644
--- a/src/assets/defaults.yml
+++ b/src/assets/defaults.yml
@@ -42,3 +42,6 @@ colors:
 message: ~
 links: []
 services: []
+
+
+proxy: ~
\ No newline at end of file
diff --git a/src/components/Service.vue b/src/components/Service.vue
index 39a9ac4..25b86d5 100644
--- a/src/components/Service.vue
+++ b/src/components/Service.vue
@@ -1,5 +1,5 @@
 <template>
-  <component v-bind:is="component" :item="item"></component>
+  <component v-bind:is="component" :item="item" :proxy="proxy"></component>
 </template>
 
 <script>
@@ -9,6 +9,7 @@ export default {
   name: "Service",
   props: {
     item: Object,
+    proxy: Object,
   },
   computed: {
     component() {
diff --git a/src/components/services/AdGuardHome.vue b/src/components/services/AdGuardHome.vue
index 16881fa..b01f0f4 100644
--- a/src/components/services/AdGuardHome.vue
+++ b/src/components/services/AdGuardHome.vue
@@ -20,10 +20,12 @@
 </template>
 
 <script>
+import service from "@/mixins/service.js";
 import Generic from "./Generic.vue";
 
 export default {
   name: "AdGuardHome",
+  mixins: [service],
   props: {
     item: Object,
   },
@@ -60,18 +62,14 @@ export default {
   },
   methods: {
     fetchStatus: async function () {
-      this.status = await fetch(`${this.item.url}/control/status`, {
-        credentials: "include",
-      })
-        .then((response) => response.json())
-        .catch((e) => console.log(e));
+      this.status = await this.fetch("/control/status").catch((e) =>
+        console.log(e)
+      );
     },
     fetchStats: async function () {
-      this.stats = await fetch(`${this.item.url}/control/stats`, {
-        credentials: "include",
-      })
-        .then((response) => response.json())
-        .catch((e) => console.log(e));
+      this.stats = await this.fetch("/control/stats").catch((e) =>
+        console.log(e)
+      );
     },
   },
 };
diff --git a/src/mixins/service.js b/src/mixins/service.js
new file mode 100644
index 0000000..99d8c01
--- /dev/null
+++ b/src/mixins/service.js
@@ -0,0 +1,28 @@
+export default {
+  props: {
+    proxy: Object,
+  },
+  created: function () {
+    // custom service often consume info from an API using the item link (url) as a base url,
+    // but sometimes the base url is different. An optional alternative URL can be provided with the "endpoint" key.
+    this.endpoint = this.item.endpoint || this.item.url;
+  },
+  methods: {
+    fetch: function (path, init) {
+      let options = {};
+
+      if (this.proxy?.useCredentials) {
+        options.credentials = "include";
+      }
+
+      options = Object.assign(options, init);
+
+      return fetch(`${this.endpoint}/${path}`, options).then((response) => {
+        if (!response.ok) {
+          throw new Error("Not 2xx response");
+        }
+        return response.json();
+      });
+    },
+  },
+};

From fea0f0904537db7ca164b1cb29ffcfcbb807a709 Mon Sep 17 00:00:00 2001
From: Bastien Wirtz <bastien.wirtz@gmail.com>
Date: Sun, 10 Oct 2021 09:46:51 +0200
Subject: [PATCH 4/8] Proxy settings documentation

---
 docs/configuration.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/configuration.md b/docs/configuration.md
index d90981a..b1cce56 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -24,6 +24,10 @@ footer: '<p>Created with <span class="has-text-danger">❤️</span> with <a hre
 columns: "3" # "auto" or number (must be a factor of 12: 1, 2, 3, 4, 6, 12)
 connectivityCheck: true # whether you want to display a message when the apps are not accessible anymore (VPN disconnected for example)
 
+# Optional: Proxy / hosting option
+proxy:
+  useCredentials: false # send cookies & authorization headers when fetching service specific data. Set to `true` if you use an authentication proxy.
+
 # Optional theming
 theme: default # 'default' or one of the themes available in 'src/assets/themes'.
 

From efc2bbb85673fb269e75d64655e433bed90a995a Mon Sep 17 00:00:00 2001
From: Bastien Wirtz <bastien.wirtz@gmail.com>
Date: Sun, 10 Oct 2021 10:16:18 +0200
Subject: [PATCH 5/8] Allow any service to override the credentials option

---
 docs/configuration.md |  2 +-
 src/mixins/service.js | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/docs/configuration.md b/docs/configuration.md
index b1cce56..0dd0a85 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -26,7 +26,7 @@ connectivityCheck: true # whether you want to display a message when the apps ar
 
 # Optional: Proxy / hosting option
 proxy:
-  useCredentials: false # send cookies & authorization headers when fetching service specific data. Set to `true` if you use an authentication proxy.
+  useCredentials: false # send cookies & authorization headers when fetching service specific data. Set to `true` if you use an authentication proxy. Can be overrided on service level.
 
 # Optional theming
 theme: default # 'default' or one of the themes available in 'src/assets/themes'.
diff --git a/src/mixins/service.js b/src/mixins/service.js
index 99d8c01..ae23a27 100644
--- a/src/mixins/service.js
+++ b/src/mixins/service.js
@@ -6,6 +6,10 @@ export default {
     // custom service often consume info from an API using the item link (url) as a base url,
     // but sometimes the base url is different. An optional alternative URL can be provided with the "endpoint" key.
     this.endpoint = this.item.endpoint || this.item.url;
+
+    if (this.endpoint.endsWith("/")) {
+      this.endpoint = this.endpoint.slice(0, -1);
+    }
   },
   methods: {
     fetch: function (path, init) {
@@ -15,8 +19,18 @@ export default {
         options.credentials = "include";
       }
 
+      // Each item can override the credential settings
+      if (this.item.useCredentials !== undefined) {
+        options.credentials =
+          this.item.useCredentials === true ? "include" : "omit";
+      }
+
       options = Object.assign(options, init);
 
+      if (path.startsWith("/")) {
+        path = path.slice(1);
+      }
+
       return fetch(`${this.endpoint}/${path}`, options).then((response) => {
         if (!response.ok) {
           throw new Error("Not 2xx response");

From 2fba043575e6a8db94434986c1781d2716c8f6d4 Mon Sep 17 00:00:00 2001
From: Bastien Wirtz <bastien.wirtz@gmail.com>
Date: Sun, 10 Oct 2021 10:37:20 +0200
Subject: [PATCH 6/8] Allow non json reponse in fetch.

---
 src/components/services/Ping.vue | 14 ++++----------
 src/mixins/service.js            |  5 +++--
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/src/components/services/Ping.vue b/src/components/services/Ping.vue
index 6fd3ec5..d1fda57 100644
--- a/src/components/services/Ping.vue
+++ b/src/components/services/Ping.vue
@@ -9,10 +9,12 @@
 </template>
 
 <script>
+import service from "@/mixins/service.js";
 import Generic from "./Generic.vue";
 
 export default {
   name: "Ping",
+  mixins: [service],
   props: {
     item: Object,
   },
@@ -27,16 +29,8 @@ export default {
   },
   methods: {
     fetchStatus: async function () {
-      const url = `${this.item.url}`;
-      fetch(url, {
-        method: "HEAD",
-        cache: "no-cache",
-        credentials: "include",
-      })
-        .then((response) => {
-          if (!response.ok) {
-            throw Error(response.statusText);
-          }
+      this.fetch("/", { method: "HEAD", cache: "no-cache" }, false)
+        .then(() => {
           this.status = "online";
         })
         .catch(() => {
diff --git a/src/mixins/service.js b/src/mixins/service.js
index ae23a27..17fa6fc 100644
--- a/src/mixins/service.js
+++ b/src/mixins/service.js
@@ -12,7 +12,7 @@ export default {
     }
   },
   methods: {
-    fetch: function (path, init) {
+    fetch: function (path, init, json = true) {
       let options = {};
 
       if (this.proxy?.useCredentials) {
@@ -35,7 +35,8 @@ export default {
         if (!response.ok) {
           throw new Error("Not 2xx response");
         }
-        return response.json();
+
+        return json ? response.json() : response;
       });
     },
   },

From 3acfb01d999527b609c08cd0790d3bb6bc2e2560 Mon Sep 17 00:00:00 2001
From: Bastien Wirtz <bastien.wirtz@gmail.com>
Date: Sun, 10 Oct 2021 10:47:23 +0200
Subject: [PATCH 7/8] Custom services common options documentation

---
 docs/customservices.md | 56 ++++++++++++++++++++++++------------------
 1 file changed, 32 insertions(+), 24 deletions(-)

diff --git a/docs/customservices.md b/docs/customservices.md
index f79428f..8ea28ee 100644
--- a/docs/customservices.md
+++ b/docs/customservices.md
@@ -6,6 +6,17 @@ within Homer.
 
 If you experiencing any issue, please have a look to the [troubleshooting](troubleshooting.md) page.
 
+
+## Common options
+
+```yaml
+- name: "My Service"
+  logo: "assets/tools/sample.png"
+  url: "http://my-service-link"
+  endpoint: "http://my-service-endpoint" # Optional: alternative base URL used to fetch service data is necessary.
+  type: "<type>"
+```
+
 ## PiHole
 
 Using the PiHole service you can display info about your local PiHole instance right on your Homer dashboard.
@@ -13,12 +24,11 @@ Using the PiHole service you can display info about your local PiHole instance r
 The following configuration is available for the PiHole service.
 
 ```yaml
- items:
-      - name: "Pi-hole"
-        logo: "assets/tools/sample.png"
-        # subtitle: "Network-wide Ad Blocking" # optional, if no subtitle is defined, PiHole statistics will be shown
-        url: "http://192.168.0.151/admin"
-        type: "PiHole"
+- name: "Pi-hole"
+  logo: "assets/tools/sample.png"
+  # subtitle: "Network-wide Ad Blocking" # optional, if no subtitle is defined, PiHole statistics will be shown
+  url: "http://192.168.0.151/admin"
+  type: "PiHole"
 ```
 
 ## OpenWeatherMap
@@ -27,14 +37,13 @@ Using the OpenWeatherMap service you can display weather information about a giv
 The following configuration is available for the OpenWeatherMap service:
 
 ```yaml
-items:
-     - name: "Weather"
-       location: "Amsterdam" # your location.
-       locationId: "2759794" # Optional: Specify OpenWeatherMap city ID for better accuracy
-       apiKey: "<---insert-api-key-here--->" # insert your own API key here. Request one from https://openweathermap.org/api.
-       units: "metric" # units to display temperature. Can be one of: metric, imperial, kelvin. Defaults to kelvin.
-       background: "square" # choose which type of background you want behind the image. Can be one of: square, cicle, none. Defaults to none.
-       type: "OpenWeather"
+- name: "Weather"
+  location: "Amsterdam" # your location.
+  locationId: "2759794" # Optional: Specify OpenWeatherMap city ID for better accuracy
+  apiKey: "<---insert-api-key-here--->" # insert your own API key here. Request one from https://openweathermap.org/api.
+  units: "metric" # units to display temperature. Can be one of: metric, imperial, kelvin. Defaults to kelvin.
+  background: "square" # choose which type of background you want behind the image. Can be one of: square, cicle, none. Defaults to none.
+  type: "OpenWeather"
 ```
 
 **Remarks:**
@@ -46,8 +55,8 @@ This service displays News (grey), Warning (orange) or Error (red) notifications
 Two lines are needed in the config.yml :
 
 ```yaml
-type: "Medusa"
-apikey: "01234deb70424befb1f4ef6a23456789"
+  type: "Medusa"
+  apikey: "01234deb70424befb1f4ef6a23456789"
 ```
 
 The url must be the root url of Medusa application.
@@ -59,8 +68,8 @@ This service displays Activity (blue), Warning (orange) or Error (red) notificat
 Two lines are needed in the config.yml :
 
 ```yaml
-type: "Radarr" or "Sonarr"
-apikey: "01234deb70424befb1f4ef6a23456789"
+  type: "Radarr" or "Sonarr"
+  apikey: "01234deb70424befb1f4ef6a23456789"
 ```
 
 The url must be the root url of Radarr/Sonarr application.
@@ -75,10 +84,9 @@ For Paperless you need an API-Key which you have to store at the item in the fie
 For Ping you need to set the type to Ping and provide a url.
 
 ```yaml
-items:
-   - name: "Awesome app"
-     type: Ping
-     logo: "assets/tools/sample.png"
-     subtitle: "Bookmark example" tag: "app" 
-     url: "https://www.reddit.com/r/selfhosted/" 
+- name: "Awesome app"
+  type: Ping
+  logo: "assets/tools/sample.png"
+  subtitle: "Bookmark example" tag: "app" 
+  url: "https://www.reddit.com/r/selfhosted/" 
 ```

From 66a434e7dba49011dd5401e32bb45ab180a73a11 Mon Sep 17 00:00:00 2001
From: Bastien Wirtz <bastien.wirtz@gmail.com>
Date: Sun, 10 Oct 2021 20:57:04 +0200
Subject: [PATCH 8/8] Implementation status warning

---
 docs/configuration.md  | 3 ++-
 docs/customservices.md | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/docs/configuration.md b/docs/configuration.md
index 0dd0a85..e4ddfcf 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -26,7 +26,8 @@ connectivityCheck: true # whether you want to display a message when the apps ar
 
 # Optional: Proxy / hosting option
 proxy:
-  useCredentials: false # send cookies & authorization headers when fetching service specific data. Set to `true` if you use an authentication proxy. Can be overrided on service level.
+  # NOT All custom services implements this new option YET. Support will be extended very soon.
+  useCredentials: false # send cookies & authorization headers when fetching service specific data. Set to `true` if you use an authentication proxy. Can be overrided on service level. 
 
 # Optional theming
 theme: default # 'default' or one of the themes available in 'src/assets/themes'.
diff --git a/docs/customservices.md b/docs/customservices.md
index 8ea28ee..ef84948 100644
--- a/docs/customservices.md
+++ b/docs/customservices.md
@@ -14,9 +14,12 @@ If you experiencing any issue, please have a look to the [troubleshooting](troub
   logo: "assets/tools/sample.png"
   url: "http://my-service-link"
   endpoint: "http://my-service-endpoint" # Optional: alternative base URL used to fetch service data is necessary.
+  useCredentials: false # Optional: Override global proxy.useCredentials configuration.
   type: "<type>"
 ```
 
+⚠️🚧 `endpoint` & `useCredentials` new options are not yet supported by all custom services (but will be very soon).
+
 ## PiHole
 
 Using the PiHole service you can display info about your local PiHole instance right on your Homer dashboard.