extern/httpie-cli
1
0
Fork 1
mirror of https://github.com/httpie/cli.git synced 2024-11-22 07:43:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup inline to-dos

Browse Source 
I.
This commit is contained in:
Jakub Roztocil 2020-06-25 11:36:09 +02:00
parent 49e71d252f
commit 14677bd25d
6 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Makefile
View File

@ -170,7 +170,6 @@ uninstall-httpie:
############################################################################### ###############################################################################
pdf: pdf:
# NOTE: rst2pdf needs to be installed manually and against a Python 2
@echo "Converting README.rst to PDF…" @echo "Converting README.rst to PDF…"
rst2pdf \ rst2pdf \
--strip-elements-with-class=no-pdf \ --strip-elements-with-class=no-pdf \

1
httpie/cli/constants.py
View File

@ -2,7 +2,6 @@
""" """
import re import re
import ssl
# TODO: Use MultiDict for headers once added to `requests`. # TODO: Use MultiDict for headers once added to `requests`.

2
httpie/cli/definition.py
View File

@ -643,7 +643,7 @@ ssl.add_argument(
''' '''
) )
ssl.add_argument( ssl.add_argument(
'--ssl', # TODO: Maybe something more general, such as --secure-protocol? '--ssl',
dest='ssl_version', dest='ssl_version',
choices=list(sorted(AVAILABLE_SSL_VERSION_ARG_MAPPING.keys())), choices=list(sorted(AVAILABLE_SSL_VERSION_ARG_MAPPING.keys())),
help=''' help='''

8
tests/test_docs.py
View File

@ -40,13 +40,17 @@ assert filenames
# HACK: hardcoded paths, venv should be irrelevant, etc. # HACK: hardcoded paths, venv should be irrelevant, etc.
# TODO: replaces the process with Python code # TODO: simplify by using the Python API instead of a subprocess
# then we wont’t need the paths.
VENV_BIN = Path(__file__).parent.parent / 'venv/bin' VENV_BIN = Path(__file__).parent.parent / 'venv/bin'
VENV_PYTHON = VENV_BIN / 'python' VENV_PYTHON = VENV_BIN / 'python'
VENV_RST2PSEUDOXML = VENV_BIN / 'rst2pseudoxml.py' VENV_RST2PSEUDOXML = VENV_BIN / 'rst2pseudoxml.py'
@pytest.mark.skipif(not os.path.exists(VENV_RST2PSEUDOXML), reason='docutils not installed') @pytest.mark.skipif(
not VENV_RST2PSEUDOXML.exists(),
reason='docutils not installed',
)
@pytest.mark.parametrize('filename', filenames) @pytest.mark.parametrize('filename', filenames)
def test_rst_file_syntax(filename): def test_rst_file_syntax(filename):
p = subprocess.Popen( p = subprocess.Popen(

1
tests/test_httpie.py
View File

@ -46,7 +46,6 @@ def test_help():
def test_version(): def test_version():
r = http('--version', tolerate_error_exit_status=True) r = http('--version', tolerate_error_exit_status=True)
assert r.exit_status == ExitStatus.SUCCESS assert r.exit_status == ExitStatus.SUCCESS
# FIXME: py3 has version in stdout, py2 in stderr
assert httpie.__version__ == r.strip() assert httpie.__version__ == r.strip()

1
tests/test_ssl.py
View File

@ -27,7 +27,6 @@ CLIENT_KEY = str(CERTS_ROOT / 'client.key')
CLIENT_PEM = str(CERTS_ROOT / 'client.pem') CLIENT_PEM = str(CERTS_ROOT / 'client.pem')
# FIXME:
# We test against a local httpbin instance which uses a self-signed cert. # We test against a local httpbin instance which uses a self-signed cert.
# Requests without --verify=<CA_BUNDLE> will fail with a verification error. # Requests without --verify=<CA_BUNDLE> will fail with a verification error.
# See: https://github.com/kevin1024/pytest-httpbin#https-support # See: https://github.com/kevin1024/pytest-httpbin#https-support