extern/httpie-cli
1
0
Fork 1
mirror of https://github.com/httpie/cli.git synced 2025-02-16 09:39:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't expire cookie with later setting in the same headers

Browse Source
This commit is contained in:
Aron Griffis 2024-06-26 11:50:27 -04:00
parent 5c068f8102
commit 5753882d76
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
httpie/utils.py
View File

@ -167,11 +167,14 @@ def get_expired_cookies(
split_cookies(cookies)
)
cookies = [
# Use a dict to keep only the last value for each cookie, so that an early
# expiration doesn't prevent a later setting in the same headers.
cookies = {
# The first attr name is the cookie name.
dict(attrs[1:], name=attrs[0][0])
attrs[0][0]: dict(attrs[1:], name=attrs[0][0])
for attrs in attr_sets
]
}
cookies = list(cookies.values())
_max_age_to_expires(cookies=cookies, now=now)

9
tests/test_sessions.py
View File

@ -437,6 +437,15 @@ class TestExpiredCookies(CookieTestBase):
datetime(2020, 6, 11).timestamp(),
[]
),
(
# Don't expire cookie with later setting.
(
'session=; Path=/; Expires=Thu, 01-Jan-1970 00:00:00 GMT; secure; HttpOnly, '
'session=bar; Path=/; secure; HttpOnly'
),
None,
[]
)
]
)
def test_get_expired_cookies_manages_multiple_cookie_headers(self, cookies, now, expected_expired):