extern/httpie-cli
1
0
Fork 1
mirror of https://github.com/httpie/cli.git synced 2025-06-25 03:51:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

fixed issues related to downloading and using quiet at the same time

Browse Source
This commit is contained in:
Nicolas Beltran 2020-08-11 11:35:14 -05:00 committed by Jakub Roztocil
parent ae22d4e754
commit c90d039a0b
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
README.rst
View File

@ -1158,6 +1158,10 @@ be printed via several options:
``--print, -p`` Selects parts of the HTTP exchange. ``--print, -p`` Selects parts of the HTTP exchange.
``--quiet, -q`` Doesn't print anything. Overrides other output flags. ``--quiet, -q`` Doesn't print anything. Overrides other output flags.
================= ===================================================== ================= =====================================================
If ``--quiet`` is used in conjuction with ``--output`` the flag is ignored
and ``stdout`` is still redirected. If ``--quiet`` is used with ``--download``
file is still downloaded as usual but ``stdout`` and ``stdin`` are redirected
to ``devnull``.
``--verbose`` can often be useful for debugging the request and generating ``--verbose`` can often be useful for debugging the request and generating
documentation examples: documentation examples:

4
httpie/cli/argparser.py
View File

@ -148,6 +148,7 @@ class HTTPieArgumentParser(argparse.ArgumentParser):
# The response body will be treated separately. # The response body will be treated separately.
self.env.stdout = self.env.stderr self.env.stdout = self.env.stderr
self.env.stdout_isatty = self.env.stderr_isatty self.env.stdout_isatty = self.env.stderr_isatty
elif self.args.output_file: elif self.args.output_file:
# When not `--download`ing, then `--output` simply replaces # When not `--download`ing, then `--output` simply replaces
# `stdout`. The file is opened for appending, which isn't what # `stdout`. The file is opened for appending, which isn't what
@ -165,8 +166,9 @@ class HTTPieArgumentParser(argparse.ArgumentParser):
self.env.stdout_isatty = False self.env.stdout_isatty = False
if self.args.quiet: if self.args.quiet:
self.env.stdout = self.env.devnull
self.env.stderr = self.env.devnull self.env.stderr = self.env.devnull
if not (self.args.output_file_specified and not self.args.download):
self.env.stdout = self.env.devnull
def _process_auth(self): def _process_auth(self):
# TODO: refactor & simplify this method. # TODO: refactor & simplify this method.

3
httpie/cli/definition.py
View File

@ -432,7 +432,8 @@ output_options.add_argument(
default=False, default=False,
help=''' help='''
Do not print to stdout or stderr. Do not print to stdout or stderr.
stdout is still redirected if --output is specified.
Flag doesn't affect behaviour of download beyond not printing to terminal.
''' '''
) )