From 4546a99a557810843c9ef553efe96a61d604bafe Mon Sep 17 00:00:00 2001 From: Christian Paul Date: Mon, 19 Nov 2018 00:58:09 -0800 Subject: [PATCH 1/3] The NPM package mbtiles got deprecated in favour of @mapbox/mbtiles --- src/TileSource.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/TileSource.js b/src/TileSource.js index 2ae3f63..5adef1c 100644 --- a/src/TileSource.js +++ b/src/TileSource.js @@ -16,10 +16,10 @@ const config = require('./config'); // https://github.com/mapbox/node-mbtiles has native build dependencies (sqlite3) // To maximize MapSCIIā€™s compatibility, MBTiles support must be manually added via -// $> npm install -g mbtiles +// $> npm install -g @mapbox/mbtiles let MBTiles = null; try { - MBTiles = require('mbtiles'); + MBTiles = require('@mapbox/mbtiles'); } catch (err) {void 0;} const modes = { @@ -49,7 +49,7 @@ class TileSource { } else if (this.source.endsWith('.mbtiles')) { if (!MBTiles) { - throw new Error('MBTiles support must be installed with following command: \'npm install -g mbtiles\''); + throw new Error('MBTiles support must be installed with following command: \'npm install -g @mapbox/mbtiles\''); } this.mode = modes.MBTiles; From 8a4d82deadd2e2894f2b2c9ea842168b36909178 Mon Sep 17 00:00:00 2001 From: Christian Paul Date: Mon, 19 Nov 2018 01:07:26 -0800 Subject: [PATCH 2/3] Update title in the README --- src/TileSource.spec.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 src/TileSource.spec.js diff --git a/src/TileSource.spec.js b/src/TileSource.spec.js new file mode 100644 index 0000000..4451c3f --- /dev/null +++ b/src/TileSource.spec.js @@ -0,0 +1,12 @@ +'use strict'; +const TileSource = require('./TileSource'); + +describe('TileSource', () => { + describe('with a HTTP source', async () => { + const tileSource = new TileSource(); + await tileSource.init('http://mapscii.me/'); + test('sets the mode to 3', () => { + tileSource.mode = 3; + }); + }); +}); From ad4103c8df42615c2bd2faed46a33f649d30acf7 Mon Sep 17 00:00:00 2001 From: Christian Paul Date: Sun, 24 Mar 2019 18:18:48 -0700 Subject: [PATCH 3/3] Don't use async within describe --- src/TileSource.spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/TileSource.spec.js b/src/TileSource.spec.js index 4451c3f..77d2022 100644 --- a/src/TileSource.spec.js +++ b/src/TileSource.spec.js @@ -2,10 +2,10 @@ const TileSource = require('./TileSource'); describe('TileSource', () => { - describe('with a HTTP source', async () => { - const tileSource = new TileSource(); - await tileSource.init('http://mapscii.me/'); - test('sets the mode to 3', () => { + describe('with a HTTP source', () => { + test('sets the mode to 3', async () => { + const tileSource = new TileSource(); + await tileSource.init('http://mapscii.me/'); tileSource.mode = 3; }); });