From 25b3641be867d4d59d969c0d9b392419b500f9da Mon Sep 17 00:00:00 2001
From: Viktor Liu <viktor@netbird.io>
Date: Mon, 29 Jan 2024 14:21:45 +0100
Subject: [PATCH] Fix data dir creation permissions (#1503)

---
 encryption/letsencrypt.go    | 7 ++++---
 management/cmd/management.go | 5 +++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/encryption/letsencrypt.go b/encryption/letsencrypt.go
index 193eaed2f..cfe54ec5a 100644
--- a/encryption/letsencrypt.go
+++ b/encryption/letsencrypt.go
@@ -1,10 +1,11 @@
 package encryption
 
 import (
-	log "github.com/sirupsen/logrus"
-	"golang.org/x/crypto/acme/autocert"
 	"os"
 	"path/filepath"
+
+	log "github.com/sirupsen/logrus"
+	"golang.org/x/crypto/acme/autocert"
 )
 
 // CreateCertManager wraps common logic of generating Let's encrypt certificate.
@@ -12,7 +13,7 @@ func CreateCertManager(datadir string, letsencryptDomain string) (*autocert.Mana
 	certDir := filepath.Join(datadir, "letsencrypt")
 
 	if _, err := os.Stat(certDir); os.IsNotExist(err) {
-		err = os.MkdirAll(certDir, os.ModeDir)
+		err = os.MkdirAll(certDir, 0755)
 		if err != nil {
 			return nil, err
 		}
diff --git a/management/cmd/management.go b/management/cmd/management.go
index 2b8bdb7ad..3801c5d09 100644
--- a/management/cmd/management.go
+++ b/management/cmd/management.go
@@ -7,7 +7,6 @@ import (
 	"errors"
 	"flag"
 	"fmt"
-	"github.com/netbirdio/management-integrations/integrations"
 	"io"
 	"io/fs"
 	"net"
@@ -18,6 +17,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/netbirdio/management-integrations/integrations"
+
 	"github.com/google/uuid"
 	"github.com/miekg/dns"
 	log "github.com/sirupsen/logrus"
@@ -115,7 +116,7 @@ var (
 			}
 
 			if _, err = os.Stat(config.Datadir); os.IsNotExist(err) {
-				err = os.MkdirAll(config.Datadir, os.ModeDir)
+				err = os.MkdirAll(config.Datadir, 0755)
 				if err != nil {
 					return fmt.Errorf("failed creating datadir: %s: %v", config.Datadir, err)
 				}