extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-06-30 22:50:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Extend protocol and firewall manager to handle old management (#915)

Browse Source 
* Extend protocol and firewall manager to handle old management

* Send correct empty firewall rules list when delete peer

* Add extra tests for firewall manager and uspfilter

* Work with inconsistent state

* Review note

* Update comment
This commit is contained in:
Givi Khojanashvili
2023-05-31 21:04:38 +04:00
committed by GitHub
parent 45a6263adc
commit 293499c3c0
13 changed files with 362 additions and 220 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
client/internal/engine.go
View File

@ -637,7 +637,13 @@ func (e *Engine) updateNetworkMap(networkMap *mgmProto.NetworkMap) error {
}
if e.acl != nil {
e.acl.ApplyFiltering(networkMap.FirewallRules)
// if we got empty rules list but management not set networkMap.FirewallRulesIsEmpty flag
// we have old version of management without rules handling, we should allow all traffic
allowByDefault := len(networkMap.FirewallRules) == 0 && !networkMap.FirewallRulesIsEmpty
if allowByDefault {
log.Warn("this peer is connected to a NetBird Management service with an older version. Allowing all traffic from connected peers")
}
e.acl.ApplyFiltering(networkMap.FirewallRules, allowByDefault)
}
e.networkSerial = serial
return nil