extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-03-19 00:59:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor version checks using go-version library

Browse Source
This commit is contained in:
bcmmbaga 2023-12-22 14:25:12 +03:00
parent 26e4ad7698
commit 3a717368f7
No known key found for this signature in database
GPG Key ID: 7249A19D20613553
1 changed files with 29 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
management/server/checks/posture_checks.go
View File

@ -3,6 +3,8 @@ package checks
import (
"fmt"
"github.com/hashicorp/go-version"
nbpeer "github.com/netbirdio/netbird/management/server/peer"
)
@ -23,20 +25,44 @@ type NBVersionPostureCheck struct {
}
func (n *NBVersionPostureCheck) Check(peer nbpeer.Peer) error {
if peer.Meta.WtVersion >= n.MinimumVersionAllowed {
peerNBVersion, err := version.NewVersion(peer.Meta.UIVersion)
if err != nil {
return err
}
constraints, err := version.NewConstraint(">= " + n.MinimumVersionAllowed)
if err != nil {
return err
}
if constraints.Check(peerNBVersion) {
return nil
}
return fmt.Errorf("peer nb version is not supported")
return fmt.Errorf("peer nb version is older than minimum allowed version %s", n.MinimumVersionAllowed)
}
type OSVersionPostureCheck struct {
Enabled bool
MinimumVersionAllowed string
// TODO: add OS context to prevent using the same version on different OS types
}
func (o *OSVersionPostureCheck) Check(peer nbpeer.Peer) error {
if peer.Meta.WtVersion >= o.MinimumVersionAllowed {
peerNBVersion, err := version.NewVersion(peer.Meta.UIVersion)
if err != nil {
return err
}
constraints, err := version.NewConstraint(">= " + o.MinimumVersionAllowed)
if err != nil {
return err
}
if constraints.Check(peerNBVersion) {
return nil
}
return fmt.Errorf("peer OS version is not supported")
}