From 47add9a9c3f4fea861fb28dd64e7ea2cf79c7686 Mon Sep 17 00:00:00 2001
From: Maycon Santos <mlsmaycon@gmail.com>
Date: Tue, 23 Aug 2022 11:09:56 +0200
Subject: [PATCH] Don't create index if peer is empty (#435)

When checking for existing prefix routes
Return nil if peer is empty
---
 management/server/file_store.go | 22 ++++++++++++----------
 management/server/route.go      |  5 +++++
 2 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/management/server/file_store.go b/management/server/file_store.go
index 13ab90f1b..04dac6fac 100644
--- a/management/server/file_store.go
+++ b/management/server/file_store.go
@@ -125,12 +125,13 @@ func restore(file string) (*FileStore, error) {
 			store.UserId2AccountId[user.Id] = accountId
 		}
 		for _, route := range account.Routes {
-			if route.Peer != "" {
-				if store.PeerKeyID2RouteIDs[route.Peer] == nil {
-					store.PeerKeyID2RouteIDs[route.Peer] = make(map[string]struct{})
-				}
-				store.PeerKeyID2RouteIDs[route.Peer][route.ID] = struct{}{}
+			if route.Peer == "" {
+				continue
 			}
+			if store.PeerKeyID2RouteIDs[route.Peer] == nil {
+				store.PeerKeyID2RouteIDs[route.Peer] = make(map[string]struct{})
+			}
+			store.PeerKeyID2RouteIDs[route.Peer][route.ID] = struct{}{}
 			if store.AccountPrefix2RouteIDs[account.Id] == nil {
 				store.AccountPrefix2RouteIDs[account.Id] = make(map[string][]string)
 			}
@@ -331,12 +332,13 @@ func (s *FileStore) SaveAccount(account *Account) error {
 	}
 
 	for _, route := range account.Routes {
-		if route.Peer != "" {
-			if s.PeerKeyID2RouteIDs[route.Peer] == nil {
-				s.PeerKeyID2RouteIDs[route.Peer] = make(map[string]struct{})
-			}
-			s.PeerKeyID2RouteIDs[route.Peer][route.ID] = struct{}{}
+		if route.Peer == "" {
+			continue
 		}
+		if s.PeerKeyID2RouteIDs[route.Peer] == nil {
+			s.PeerKeyID2RouteIDs[route.Peer] = make(map[string]struct{})
+		}
+		s.PeerKeyID2RouteIDs[route.Peer][route.ID] = struct{}{}
 		if s.AccountPrefix2RouteIDs[account.Id] == nil {
 			s.AccountPrefix2RouteIDs[account.Id] = make(map[string][]string)
 		}
diff --git a/management/server/route.go b/management/server/route.go
index 0c9fc2e57..40d331283 100644
--- a/management/server/route.go
+++ b/management/server/route.go
@@ -79,6 +79,11 @@ func (am *DefaultAccountManager) GetRoute(accountID, routeID string) (*route.Rou
 
 // checkPrefixPeerExists checks the combination of prefix and peer id, if it exists returns an error, otherwise returns nil
 func (am *DefaultAccountManager) checkPrefixPeerExists(accountID, peer string, prefix netip.Prefix) error {
+
+	if peer == "" {
+		return nil
+	}
+
 	routesWithPrefix, err := am.Store.GetRoutesByPrefix(accountID, prefix)
 
 	if err != nil {