extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-06-21 10:18:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Drop certain forwarded icmp packets

Browse Source
This commit is contained in:
Viktor Liu 2025-01-02 18:56:23 +01:00
parent 911f86ded8
commit 568d064089
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
client/firewall/uspfilter/forwarder/icmp.go
View File

@ -19,6 +19,8 @@ func (f *Forwarder) handleICMP(id stack.TransportEndpointID, pkt stack.PacketBuf
conn, err := lc.ListenPacket(ctx, "ip4:icmp", "0.0.0.0") conn, err := lc.ListenPacket(ctx, "ip4:icmp", "0.0.0.0")
if err != nil { if err != nil {
f.logger.Error("Failed to create ICMP socket for %v: %v", id, err) f.logger.Error("Failed to create ICMP socket for %v: %v", id, err)
// This will make netstack reply on behalf of the original destination, that's ok for now
return false return false
} }
defer func() { defer func() {
@ -42,7 +44,7 @@ func (f *Forwarder) handleICMP(id stack.TransportEndpointID, pkt stack.PacketBuf
_, err = conn.WriteTo(payload, dst) _, err = conn.WriteTo(payload, dst)
if err != nil { if err != nil {
f.logger.Error("Failed to write ICMP packet for %v: %v", id, err) f.logger.Error("Failed to write ICMP packet for %v: %v", id, err)
return false return true
} }
f.logger.Trace("Forwarded ICMP packet %v type=%v code=%v", f.logger.Trace("Forwarded ICMP packet %v type=%v code=%v",
@ -51,7 +53,7 @@ func (f *Forwarder) handleICMP(id stack.TransportEndpointID, pkt stack.PacketBuf
return f.handleEchoResponse(conn, id) return f.handleEchoResponse(conn, id)
case header.ICMPv4EchoReply: case header.ICMPv4EchoReply:
// dont process our own replies // dont process our own replies
return false return true
default: default:
} }
@ -59,7 +61,7 @@ func (f *Forwarder) handleICMP(id stack.TransportEndpointID, pkt stack.PacketBuf
_, err = conn.WriteTo(payload, dst) _, err = conn.WriteTo(payload, dst)
if err != nil { if err != nil {
f.logger.Error("Failed to write ICMP packet for %v: %v", id, err) f.logger.Error("Failed to write ICMP packet for %v: %v", id, err)
return false return true
} }
f.logger.Trace("Forwarded ICMP packet %v type=%v code=%v", f.logger.Trace("Forwarded ICMP packet %v type=%v code=%v",