Rename connector to worker

This commit is contained in:
Zoltán Papp 2024-06-18 11:22:40 +02:00
parent f7d8d03e55
commit 63b4041e9c
5 changed files with 102 additions and 102 deletions

View File

@ -82,8 +82,8 @@ type Conn struct {
status ConnStatus status ConnStatus
connectorICE *ConnectorICE workerICE *WorkerICE
connectorRelay *ConnectorRelay workerRelay *WorkerRelay
connID nbnet.ConnectionID connID nbnet.ConnectionID
beforeAddPeerHooks []BeforeAddPeerHookFunc beforeAddPeerHooks []BeforeAddPeerHookFunc
@ -116,8 +116,8 @@ func NewConn(engineCtx context.Context, config ConnConfig, statusRecorder *Statu
status: StatusDisconnected, status: StatusDisconnected,
closeCh: make(chan struct{}), closeCh: make(chan struct{}),
} }
conn.connectorICE = NewConnectorICE(ctx, conn.log, config, config.ICEConfig, signaler, iFaceDiscover, statusRecorder, conn.iCEConnectionIsReady, conn.doHandshake) conn.workerICE = NewWorkerICE(ctx, conn.log, config, config.ICEConfig, signaler, iFaceDiscover, statusRecorder, conn.iCEConnectionIsReady, conn.doHandshake)
conn.connectorRelay = NewConnectorRelay(ctx, conn.log, relayManager, config, conn.relayConnectionIsReady, conn.doHandshake) conn.workerRelay = NewWorkerRelay(ctx, conn.log, relayManager, config, conn.relayConnectionIsReady, conn.doHandshake)
return conn, nil return conn, nil
} }
@ -152,11 +152,11 @@ func (conn *Conn) Open() {
log.Warnf("error while updating the state of peer %s,err: %v", conn.config.Key, err) log.Warnf("error while updating the state of peer %s,err: %v", conn.config.Key, err)
} }
*/ */
relayIsSupportedLocally := conn.connectorRelay.RelayIsSupportedLocally() relayIsSupportedLocally := conn.workerRelay.RelayIsSupportedLocally()
if relayIsSupportedLocally { if relayIsSupportedLocally {
go conn.connectorRelay.SetupRelayConnection() go conn.workerRelay.SetupRelayConnection()
} }
go conn.connectorICE.SetupICEConnection(relayIsSupportedLocally) go conn.workerICE.SetupICEConnection(relayIsSupportedLocally)
} }
// Close closes this peer Conn issuing a close event to the Conn closeCh // Close closes this peer Conn issuing a close event to the Conn closeCh
@ -221,7 +221,7 @@ func (conn *Conn) OnRemoteAnswer(answer OfferAnswer) bool {
// OnRemoteCandidate Handles ICE connection Candidate provided by the remote peer. // OnRemoteCandidate Handles ICE connection Candidate provided by the remote peer.
func (conn *Conn) OnRemoteCandidate(candidate ice.Candidate, haRoutes route.HAMap) { func (conn *Conn) OnRemoteCandidate(candidate ice.Candidate, haRoutes route.HAMap) {
conn.connectorICE.OnRemoteCandidate(candidate, haRoutes) conn.workerICE.OnRemoteCandidate(candidate, haRoutes)
} }
func (conn *Conn) AddBeforeAddPeerHook(hook BeforeAddPeerHookFunc) { func (conn *Conn) AddBeforeAddPeerHook(hook BeforeAddPeerHookFunc) {
@ -419,12 +419,12 @@ func (conn *Conn) doHandshake() (*OfferAnswer, error) {
return nil, ErrSignalIsNotReady return nil, ErrSignalIsNotReady
} }
uFreg, pwd, err := conn.connectorICE.GetLocalUserCredentials() uFreg, pwd, err := conn.workerICE.GetLocalUserCredentials()
if err != nil { if err != nil {
conn.log.Errorf("failed to get local user credentials: %v", err) conn.log.Errorf("failed to get local user credentials: %v", err)
} }
addr, err := conn.connectorRelay.RelayAddress() addr, err := conn.workerRelay.RelayAddress()
if err != nil { if err != nil {
conn.log.Errorf("failed to get local relay address: %v", err) conn.log.Errorf("failed to get local relay address: %v", err)
} }

View File

@ -6,6 +6,6 @@ import (
"github.com/netbirdio/netbird/client/internal/stdnet" "github.com/netbirdio/netbird/client/internal/stdnet"
) )
func (conn *ConnectorICE) newStdNet() (*stdnet.Net, error) { func (w *WorkerICE) newStdNet() (*stdnet.Net, error) {
return stdnet.NewNet(conn.configICE.InterfaceBlackList) return stdnet.NewNet(w.configICE.InterfaceBlackList)
} }

View File

@ -2,6 +2,6 @@ package peer
import "github.com/netbirdio/netbird/client/internal/stdnet" import "github.com/netbirdio/netbird/client/internal/stdnet"
func (conn *ConnectorICE) newStdNet() (*stdnet.Net, error) { func (w *WorkerICE) newStdNet() (*stdnet.Net, error) {
return stdnet.NewNetWithDiscover(conn.iFaceDiscover, conn.configICE.InterfaceBlackList) return stdnet.NewNetWithDiscover(w.iFaceDiscover, w.configICE.InterfaceBlackList)
} }

View File

@ -58,7 +58,7 @@ type ICEConnInfo struct {
RelayedOnLocal bool RelayedOnLocal bool
} }
type ConnectorICE struct { type WorkerICE struct {
ctx context.Context ctx context.Context
log *log.Entry log *log.Entry
config ConnConfig config ConnConfig
@ -78,8 +78,8 @@ type ConnectorICE struct {
sentExtraSrflx bool sentExtraSrflx bool
} }
func NewConnectorICE(ctx context.Context, log *log.Entry, config ConnConfig, configICE ICEConfig, signaler *Signaler, ifaceDiscover stdnet.ExternalIFaceDiscover, statusRecorder *Status, onICEConnReady OnICEConnReadyCallback, doHandshakeFn DoHandshake) *ConnectorICE { func NewWorkerICE(ctx context.Context, log *log.Entry, config ConnConfig, configICE ICEConfig, signaler *Signaler, ifaceDiscover stdnet.ExternalIFaceDiscover, statusRecorder *Status, onICEConnReady OnICEConnReadyCallback, doHandshakeFn DoHandshake) *WorkerICE {
cice := &ConnectorICE{ cice := &WorkerICE{
ctx: ctx, ctx: ctx,
log: log, log: log,
config: config, config: config,
@ -97,38 +97,38 @@ func NewConnectorICE(ctx context.Context, log *log.Entry, config ConnConfig, con
// If the relay mode is supported then try to connect in p2p way only. // If the relay mode is supported then try to connect in p2p way only.
// It is trying to reconnection in a loop until the context is canceled. // It is trying to reconnection in a loop until the context is canceled.
// In case of success connection it will call the onICEConnReady callback. // In case of success connection it will call the onICEConnReady callback.
func (conn *ConnectorICE) SetupICEConnection(hasRelayOnLocally bool) { func (w *WorkerICE) SetupICEConnection(hasRelayOnLocally bool) {
for { for {
if !conn.waitForReconnectTry() { if !w.waitForReconnectTry() {
return return
} }
remoteOfferAnswer, err := conn.doHandshakeFn() remoteOfferAnswer, err := w.doHandshakeFn()
if err != nil { if err != nil {
if errors.Is(err, ErrSignalIsNotReady) { if errors.Is(err, ErrSignalIsNotReady) {
conn.log.Infof("signal client isn't ready, skipping connection attempt") w.log.Infof("signal client isn't ready, skipping connection attempt")
} }
continue continue
} }
var preferredCandidateTypes []ice.CandidateType var preferredCandidateTypes []ice.CandidateType
if hasRelayOnLocally && remoteOfferAnswer.RelaySrvAddress != "" { if hasRelayOnLocally && remoteOfferAnswer.RelaySrvAddress != "" {
conn.connPriority = connPriorityICEP2P w.connPriority = connPriorityICEP2P
preferredCandidateTypes = candidateTypesP2P() preferredCandidateTypes = candidateTypesP2P()
} else { } else {
conn.connPriority = connPriorityICETurn w.connPriority = connPriorityICETurn
preferredCandidateTypes = candidateTypes() preferredCandidateTypes = candidateTypes()
} }
ctx, ctxCancel := context.WithCancel(conn.ctx) ctx, ctxCancel := context.WithCancel(w.ctx)
agent, err := conn.reCreateAgent(ctxCancel, preferredCandidateTypes) agent, err := w.reCreateAgent(ctxCancel, preferredCandidateTypes)
if err != nil { if err != nil {
ctxCancel() ctxCancel()
continue continue
} }
conn.agent = agent w.agent = agent
err = conn.agent.GatherCandidates() err = w.agent.GatherCandidates()
if err != nil { if err != nil {
ctxCancel() ctxCancel()
continue continue
@ -137,13 +137,13 @@ func (conn *ConnectorICE) SetupICEConnection(hasRelayOnLocally bool) {
// will block until connection succeeded // will block until connection succeeded
// but it won't release if ICE Agent went into Disconnected or Failed state, // but it won't release if ICE Agent went into Disconnected or Failed state,
// so we have to cancel it with the provided context once agent detected a broken connection // so we have to cancel it with the provided context once agent detected a broken connection
remoteConn, err := conn.turnAgentDial(remoteOfferAnswer) remoteConn, err := w.turnAgentDial(remoteOfferAnswer)
if err != nil { if err != nil {
ctxCancel() ctxCancel()
continue continue
} }
pair, err := conn.agent.GetSelectedCandidatePair() pair, err := w.agent.GetSelectedCandidatePair()
if err != nil { if err != nil {
ctxCancel() ctxCancel()
continue continue
@ -157,7 +157,7 @@ func (conn *ConnectorICE) SetupICEConnection(hasRelayOnLocally bool) {
} }
// To support old version's with direct mode we attempt to punch an additional role with the remote WireGuard port // To support old version's with direct mode we attempt to punch an additional role with the remote WireGuard port
go conn.punchRemoteWGPort(pair, remoteWgPort) go w.punchRemoteWGPort(pair, remoteWgPort)
} }
ci := ICEConnInfo{ ci := ICEConnInfo{
@ -172,18 +172,18 @@ func (conn *ConnectorICE) SetupICEConnection(hasRelayOnLocally bool) {
Relayed: isRelayed(pair), Relayed: isRelayed(pair),
RelayedOnLocal: isRelayCandidate(pair.Local), RelayedOnLocal: isRelayCandidate(pair.Local),
} }
go conn.onICEConnReady(conn.connPriority, ci) go w.onICEConnReady(w.connPriority, ci)
<-ctx.Done() <-ctx.Done()
ctxCancel() ctxCancel()
_ = conn.agent.Close() _ = w.agent.Close()
} }
} }
// OnRemoteCandidate Handles ICE connection Candidate provided by the remote peer. // OnRemoteCandidate Handles ICE connection Candidate provided by the remote peer.
func (conn *ConnectorICE) OnRemoteCandidate(candidate ice.Candidate, haRoutes route.HAMap) { func (w *WorkerICE) OnRemoteCandidate(candidate ice.Candidate, haRoutes route.HAMap) {
conn.log.Debugf("OnRemoteCandidate from peer %s -> %s", conn.config.Key, candidate.String()) w.log.Debugf("OnRemoteCandidate from peer %s -> %s", w.config.Key, candidate.String())
if conn.agent == nil { if w.agent == nil {
return return
} }
@ -191,25 +191,25 @@ func (conn *ConnectorICE) OnRemoteCandidate(candidate ice.Candidate, haRoutes ro
return return
} }
err := conn.agent.AddRemoteCandidate(candidate) err := w.agent.AddRemoteCandidate(candidate)
if err != nil { if err != nil {
conn.log.Errorf("error while handling remote candidate") w.log.Errorf("error while handling remote candidate")
return return
} }
} }
func (conn *ConnectorICE) GetLocalUserCredentials() (frag string, pwd string, err error) { func (w *WorkerICE) GetLocalUserCredentials() (frag string, pwd string, err error) {
if conn.agent == nil { if w.agent == nil {
return "", "", errors.New("ICE Agent is not initialized") return "", "", errors.New("ICE Agent is not initialized")
} }
return conn.agent.GetLocalUserCredentials() return w.agent.GetLocalUserCredentials()
} }
func (conn *ConnectorICE) reCreateAgent(ctxCancel context.CancelFunc, relaySupport []ice.CandidateType) (*ice.Agent, error) { func (w *WorkerICE) reCreateAgent(ctxCancel context.CancelFunc, relaySupport []ice.CandidateType) (*ice.Agent, error) {
failedTimeout := 6 * time.Second failedTimeout := 6 * time.Second
transportNet, err := conn.newStdNet() transportNet, err := w.newStdNet()
if err != nil { if err != nil {
conn.log.Errorf("failed to create pion's stdnet: %s", err) w.log.Errorf("failed to create pion's stdnet: %s", err)
} }
iceKeepAlive := iceKeepAlive() iceKeepAlive := iceKeepAlive()
@ -219,36 +219,36 @@ func (conn *ConnectorICE) reCreateAgent(ctxCancel context.CancelFunc, relaySuppo
agentConfig := &ice.AgentConfig{ agentConfig := &ice.AgentConfig{
MulticastDNSMode: ice.MulticastDNSModeDisabled, MulticastDNSMode: ice.MulticastDNSModeDisabled,
NetworkTypes: []ice.NetworkType{ice.NetworkTypeUDP4, ice.NetworkTypeUDP6}, NetworkTypes: []ice.NetworkType{ice.NetworkTypeUDP4, ice.NetworkTypeUDP6},
Urls: conn.configICE.StunTurn.Load().([]*stun.URI), Urls: w.configICE.StunTurn.Load().([]*stun.URI),
CandidateTypes: relaySupport, CandidateTypes: relaySupport,
FailedTimeout: &failedTimeout, FailedTimeout: &failedTimeout,
InterfaceFilter: stdnet.InterfaceFilter(conn.configICE.InterfaceBlackList), InterfaceFilter: stdnet.InterfaceFilter(w.configICE.InterfaceBlackList),
UDPMux: conn.configICE.UDPMux, UDPMux: w.configICE.UDPMux,
UDPMuxSrflx: conn.configICE.UDPMuxSrflx, UDPMuxSrflx: w.configICE.UDPMuxSrflx,
NAT1To1IPs: conn.configICE.NATExternalIPs, NAT1To1IPs: w.configICE.NATExternalIPs,
Net: transportNet, Net: transportNet,
DisconnectedTimeout: &iceDisconnectedTimeout, DisconnectedTimeout: &iceDisconnectedTimeout,
KeepaliveInterval: &iceKeepAlive, KeepaliveInterval: &iceKeepAlive,
RelayAcceptanceMinWait: &iceRelayAcceptanceMinWait, RelayAcceptanceMinWait: &iceRelayAcceptanceMinWait,
} }
if conn.configICE.DisableIPv6Discovery { if w.configICE.DisableIPv6Discovery {
agentConfig.NetworkTypes = []ice.NetworkType{ice.NetworkTypeUDP4} agentConfig.NetworkTypes = []ice.NetworkType{ice.NetworkTypeUDP4}
} }
conn.sentExtraSrflx = false w.sentExtraSrflx = false
agent, err := ice.NewAgent(agentConfig) agent, err := ice.NewAgent(agentConfig)
if err != nil { if err != nil {
return nil, err return nil, err
} }
err = agent.OnCandidate(conn.onICECandidate) err = agent.OnCandidate(w.onICECandidate)
if err != nil { if err != nil {
return nil, err return nil, err
} }
err = agent.OnConnectionStateChange(func(state ice.ConnectionState) { err = agent.OnConnectionStateChange(func(state ice.ConnectionState) {
conn.log.Debugf("ICE ConnectionState has changed to %s", state.String()) w.log.Debugf("ICE ConnectionState has changed to %s", state.String())
if state == ice.ConnectionStateFailed || state == ice.ConnectionStateDisconnected { if state == ice.ConnectionStateFailed || state == ice.ConnectionStateDisconnected {
ctxCancel() ctxCancel()
} }
@ -257,15 +257,15 @@ func (conn *ConnectorICE) reCreateAgent(ctxCancel context.CancelFunc, relaySuppo
return nil, err return nil, err
} }
err = agent.OnSelectedCandidatePairChange(conn.onICESelectedCandidatePair) err = agent.OnSelectedCandidatePairChange(w.onICESelectedCandidatePair)
if err != nil { if err != nil {
return nil, err return nil, err
} }
err = agent.OnSuccessfulSelectedPairBindingResponse(func(p *ice.CandidatePair) { err = agent.OnSuccessfulSelectedPairBindingResponse(func(p *ice.CandidatePair) {
err := conn.statusRecorder.UpdateLatency(conn.config.Key, p.Latency()) err := w.statusRecorder.UpdateLatency(w.config.Key, p.Latency())
if err != nil { if err != nil {
conn.log.Debugf("failed to update latency for peer: %s", err) w.log.Debugf("failed to update latency for peer: %s", err)
return return
} }
}) })
@ -276,44 +276,44 @@ func (conn *ConnectorICE) reCreateAgent(ctxCancel context.CancelFunc, relaySuppo
return agent, nil return agent, nil
} }
func (conn *ConnectorICE) punchRemoteWGPort(pair *ice.CandidatePair, remoteWgPort int) { func (w *WorkerICE) punchRemoteWGPort(pair *ice.CandidatePair, remoteWgPort int) {
// wait local endpoint configuration // wait local endpoint configuration
time.Sleep(time.Second) time.Sleep(time.Second)
addr, err := net.ResolveUDPAddr("udp", fmt.Sprintf("%s:%d", pair.Remote.Address(), remoteWgPort)) addr, err := net.ResolveUDPAddr("udp", fmt.Sprintf("%s:%d", pair.Remote.Address(), remoteWgPort))
if err != nil { if err != nil {
conn.log.Warnf("got an error while resolving the udp address, err: %s", err) w.log.Warnf("got an error while resolving the udp address, err: %s", err)
return return
} }
mux, ok := conn.configICE.UDPMuxSrflx.(*bind.UniversalUDPMuxDefault) mux, ok := w.configICE.UDPMuxSrflx.(*bind.UniversalUDPMuxDefault)
if !ok { if !ok {
conn.log.Warn("invalid udp mux conversion") w.log.Warn("invalid udp mux conversion")
return return
} }
_, err = mux.GetSharedConn().WriteTo([]byte{0x6e, 0x62}, addr) _, err = mux.GetSharedConn().WriteTo([]byte{0x6e, 0x62}, addr)
if err != nil { if err != nil {
conn.log.Warnf("got an error while sending the punch packet, err: %s", err) w.log.Warnf("got an error while sending the punch packet, err: %s", err)
} }
} }
// onICECandidate is a callback attached to an ICE Agent to receive new local connection candidates // onICECandidate is a callback attached to an ICE Agent to receive new local connection candidates
// and then signals them to the remote peer // and then signals them to the remote peer
func (conn *ConnectorICE) onICECandidate(candidate ice.Candidate) { func (w *WorkerICE) onICECandidate(candidate ice.Candidate) {
// nil means candidate gathering has been ended // nil means candidate gathering has been ended
if candidate == nil { if candidate == nil {
return return
} }
// TODO: reported port is incorrect for CandidateTypeHost, makes understanding ICE use via logs confusing as port is ignored // TODO: reported port is incorrect for CandidateTypeHost, makes understanding ICE use via logs confusing as port is ignored
conn.log.Debugf("discovered local candidate %s", candidate.String()) w.log.Debugf("discovered local candidate %s", candidate.String())
go func() { go func() {
err := conn.signaler.SignalICECandidate(candidate, conn.config.Key) err := w.signaler.SignalICECandidate(candidate, w.config.Key)
if err != nil { if err != nil {
conn.log.Errorf("failed signaling candidate to the remote peer %s %s", conn.config.Key, err) w.log.Errorf("failed signaling candidate to the remote peer %s %s", w.config.Key, err)
} }
}() }()
if !conn.shouldSendExtraSrflxCandidate(candidate) { if !w.shouldSendExtraSrflxCandidate(candidate) {
return return
} }
@ -321,42 +321,42 @@ func (conn *ConnectorICE) onICECandidate(candidate ice.Candidate) {
// this is useful when network has an existing port forwarding rule for the wireguard port and this peer // this is useful when network has an existing port forwarding rule for the wireguard port and this peer
extraSrflx, err := extraSrflxCandidate(candidate) extraSrflx, err := extraSrflxCandidate(candidate)
if err != nil { if err != nil {
conn.log.Errorf("failed creating extra server reflexive candidate %s", err) w.log.Errorf("failed creating extra server reflexive candidate %s", err)
return return
} }
conn.sentExtraSrflx = true w.sentExtraSrflx = true
go func() { go func() {
err = conn.signaler.SignalICECandidate(extraSrflx, conn.config.Key) err = w.signaler.SignalICECandidate(extraSrflx, w.config.Key)
if err != nil { if err != nil {
conn.log.Errorf("failed signaling the extra server reflexive candidate: %s", err) w.log.Errorf("failed signaling the extra server reflexive candidate: %s", err)
} }
}() }()
} }
func (conn *ConnectorICE) onICESelectedCandidatePair(c1 ice.Candidate, c2 ice.Candidate) { func (w *WorkerICE) onICESelectedCandidatePair(c1 ice.Candidate, c2 ice.Candidate) {
conn.log.Debugf("selected candidate pair [local <-> remote] -> [%s <-> %s], peer %s", c1.String(), c2.String(), w.log.Debugf("selected candidate pair [local <-> remote] -> [%s <-> %s], peer %s", c1.String(), c2.String(),
conn.config.Key) w.config.Key)
} }
func (conn *ConnectorICE) shouldSendExtraSrflxCandidate(candidate ice.Candidate) bool { func (w *WorkerICE) shouldSendExtraSrflxCandidate(candidate ice.Candidate) bool {
if !conn.sentExtraSrflx && candidate.Type() == ice.CandidateTypeServerReflexive && candidate.Port() != candidate.RelatedAddress().Port { if !w.sentExtraSrflx && candidate.Type() == ice.CandidateTypeServerReflexive && candidate.Port() != candidate.RelatedAddress().Port {
return true return true
} }
return false return false
} }
func (conn *ConnectorICE) turnAgentDial(remoteOfferAnswer *OfferAnswer) (*ice.Conn, error) { func (w *WorkerICE) turnAgentDial(remoteOfferAnswer *OfferAnswer) (*ice.Conn, error) {
isControlling := conn.config.LocalKey > conn.config.Key isControlling := w.config.LocalKey > w.config.Key
if isControlling { if isControlling {
return conn.agent.Dial(conn.ctx, remoteOfferAnswer.IceCredentials.UFrag, remoteOfferAnswer.IceCredentials.Pwd) return w.agent.Dial(w.ctx, remoteOfferAnswer.IceCredentials.UFrag, remoteOfferAnswer.IceCredentials.Pwd)
} else { } else {
return conn.agent.Accept(conn.ctx, remoteOfferAnswer.IceCredentials.UFrag, remoteOfferAnswer.IceCredentials.Pwd) return w.agent.Accept(w.ctx, remoteOfferAnswer.IceCredentials.UFrag, remoteOfferAnswer.IceCredentials.Pwd)
} }
} }
// waitForReconnectTry waits for a random duration before trying to reconnect // waitForReconnectTry waits for a random duration before trying to reconnect
func (conn *ConnectorICE) waitForReconnectTry() bool { func (w *WorkerICE) waitForReconnectTry() bool {
minWait := 500 minWait := 500
maxWait := 2000 maxWait := 2000
duration := time.Duration(rand.Intn(maxWait-minWait)+minWait) * time.Millisecond duration := time.Duration(rand.Intn(maxWait-minWait)+minWait) * time.Millisecond
@ -365,7 +365,7 @@ func (conn *ConnectorICE) waitForReconnectTry() bool {
defer timeout.Stop() defer timeout.Stop()
select { select {
case <-conn.ctx.Done(): case <-w.ctx.Done():
return false return false
case <-timeout.C: case <-timeout.C:
return true return true

View File

@ -20,7 +20,7 @@ type RelayConnInfo struct {
rosenpassAddr string rosenpassAddr string
} }
type ConnectorRelay struct { type WorkerRelay struct {
ctx context.Context ctx context.Context
log *log.Entry log *log.Entry
relayManager *relayClient.Manager relayManager *relayClient.Manager
@ -29,8 +29,8 @@ type ConnectorRelay struct {
doHandshakeFn DoHandshake doHandshakeFn DoHandshake
} }
func NewConnectorRelay(ctx context.Context, log *log.Entry, relayManager *relayClient.Manager, config ConnConfig, onRelayConnReadyFN OnRelayReadyCallback, doHandshakeFn DoHandshake) *ConnectorRelay { func NewWorkerRelay(ctx context.Context, log *log.Entry, relayManager *relayClient.Manager, config ConnConfig, onRelayConnReadyFN OnRelayReadyCallback, doHandshakeFn DoHandshake) *WorkerRelay {
return &ConnectorRelay{ return &WorkerRelay{
ctx: ctx, ctx: ctx,
log: log, log: log,
relayManager: relayManager, relayManager: relayManager,
@ -41,39 +41,39 @@ func NewConnectorRelay(ctx context.Context, log *log.Entry, relayManager *relayC
} }
// SetupRelayConnection todo: this function is not completed. Make no sense to put it in a for loop because we are not waiting for any event // SetupRelayConnection todo: this function is not completed. Make no sense to put it in a for loop because we are not waiting for any event
func (conn *ConnectorRelay) SetupRelayConnection() { func (w *WorkerRelay) SetupRelayConnection() {
for { for {
if !conn.waitForReconnectTry() { if !w.waitForReconnectTry() {
return return
} }
remoteOfferAnswer, err := conn.doHandshakeFn() remoteOfferAnswer, err := w.doHandshakeFn()
if err != nil { if err != nil {
if errors.Is(err, ErrSignalIsNotReady) { if errors.Is(err, ErrSignalIsNotReady) {
conn.log.Infof("signal client isn't ready, skipping connection attempt") w.log.Infof("signal client isn't ready, skipping connection attempt")
} }
conn.log.Errorf("failed to do handshake: %v", err) w.log.Errorf("failed to do handshake: %v", err)
continue continue
} }
if !conn.isRelaySupported(remoteOfferAnswer) { if !w.isRelaySupported(remoteOfferAnswer) {
// todo should we retry? // todo should we retry?
continue continue
} }
// the relayManager will return with error in case if the connection has lost with relay server // the relayManager will return with error in case if the connection has lost with relay server
currentRelayAddress, err := conn.relayManager.RelayAddress() currentRelayAddress, err := w.relayManager.RelayAddress()
if err != nil { if err != nil {
continue continue
} }
srv := conn.preferredRelayServer(currentRelayAddress.String(), remoteOfferAnswer.RelaySrvAddress) srv := w.preferredRelayServer(currentRelayAddress.String(), remoteOfferAnswer.RelaySrvAddress)
relayedConn, err := conn.relayManager.OpenConn(srv, conn.config.Key) relayedConn, err := w.relayManager.OpenConn(srv, w.config.Key)
if err != nil { if err != nil {
continue continue
} }
go conn.onRelayConnReadyFN(RelayConnInfo{ go w.onRelayConnReadyFN(RelayConnInfo{
relayedConn: relayedConn, relayedConn: relayedConn,
rosenpassPubKey: remoteOfferAnswer.RosenpassPubKey, rosenpassPubKey: remoteOfferAnswer.RosenpassPubKey,
rosenpassAddr: remoteOfferAnswer.RosenpassAddr, rosenpassAddr: remoteOfferAnswer.RosenpassAddr,
@ -83,28 +83,28 @@ func (conn *ConnectorRelay) SetupRelayConnection() {
} }
} }
func (conn *ConnectorRelay) RelayAddress() (net.Addr, error) { func (w *WorkerRelay) RelayAddress() (net.Addr, error) {
return conn.relayManager.RelayAddress() return w.relayManager.RelayAddress()
} }
// todo check my side too // todo check my side too
func (conn *ConnectorRelay) isRelaySupported(answer *OfferAnswer) bool { func (w *WorkerRelay) isRelaySupported(answer *OfferAnswer) bool {
return answer.RelaySrvAddress != "" return answer.RelaySrvAddress != ""
} }
func (conn *ConnectorRelay) preferredRelayServer(myRelayAddress, remoteRelayAddress string) string { func (w *WorkerRelay) preferredRelayServer(myRelayAddress, remoteRelayAddress string) string {
if conn.config.LocalKey > conn.config.Key { if w.config.LocalKey > w.config.Key {
return myRelayAddress return myRelayAddress
} }
return remoteRelayAddress return remoteRelayAddress
} }
func (conn *ConnectorRelay) RelayIsSupportedLocally() bool { func (w *WorkerRelay) RelayIsSupportedLocally() bool {
return conn.relayManager.HasRelayAddress() return w.relayManager.HasRelayAddress()
} }
// waitForReconnectTry waits for a random duration before trying to reconnect // waitForReconnectTry waits for a random duration before trying to reconnect
func (conn *ConnectorRelay) waitForReconnectTry() bool { func (w *WorkerRelay) waitForReconnectTry() bool {
minWait := 500 minWait := 500
maxWait := 2000 maxWait := 2000
duration := time.Duration(rand.Intn(maxWait-minWait)+minWait) * time.Millisecond duration := time.Duration(rand.Intn(maxWait-minWait)+minWait) * time.Millisecond
@ -113,7 +113,7 @@ func (conn *ConnectorRelay) waitForReconnectTry() bool {
defer timeout.Stop() defer timeout.Stop()
select { select {
case <-conn.ctx.Done(): case <-w.ctx.Done():
return false return false
case <-timeout.C: case <-timeout.C:
return true return true