extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-02-07 14:00:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor

Browse Source 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
This commit is contained in:
bcmmbaga 2024-12-10 17:04:16 +01:00
parent a52ef1a066
commit 7146fd03d1
No known key found for this signature in database
GPG Key ID: 511EED5C928AD547
1 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
management/server/sql_store_test.go
View File

@ -2351,9 +2351,9 @@ func TestSqlStore_GetNetworkResourcesByNetID(t *testing.T) {
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
resources, err := store.GetNetworkResourcesByNetID(context.Background(), LockingStrengthShare, accountID, tt.networkID) netResources, err := store.GetNetworkResourcesByNetID(context.Background(), LockingStrengthShare, accountID, tt.networkID)
require.NoError(t, err) require.NoError(t, err)
require.Len(t, resources, tt.expectedCount) require.Len(t, netResources, tt.expectedCount)
}) })
} }
} }
@ -2365,40 +2365,40 @@ func TestSqlStore_GetNetworkResourceByID(t *testing.T) {
accountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b" accountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b"
tests := []struct { tests := []struct {
name string name string
networkResourceID string netResourceID string
expectError bool expectError bool
}{ }{
{ {
name: "retrieve existing network resource ID", name: "retrieve existing network resource ID",
networkResourceID: "ctc4nci7qv9061u6ilfg", netResourceID: "ctc4nci7qv9061u6ilfg",
expectError: false, expectError: false,
}, },
{ {
name: "retrieve non-existing network resource ID", name: "retrieve non-existing network resource ID",
networkResourceID: "non-existing", netResourceID: "non-existing",
expectError: true, expectError: true,
}, },
{ {
name: "retrieve network with empty resource ID", name: "retrieve network with empty resource ID",
networkResourceID: "", netResourceID: "",
expectError: true, expectError: true,
}, },
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
networkResource, err := store.GetNetworkResourceByID(context.Background(), LockingStrengthShare, accountID, tt.networkResourceID) netResource, err := store.GetNetworkResourceByID(context.Background(), LockingStrengthShare, accountID, tt.netResourceID)
if tt.expectError { if tt.expectError {
require.Error(t, err) require.Error(t, err)
sErr, ok := status.FromError(err) sErr, ok := status.FromError(err)
require.True(t, ok) require.True(t, ok)
require.Equal(t, sErr.Type(), status.NotFound) require.Equal(t, sErr.Type(), status.NotFound)
require.Nil(t, networkResource) require.Nil(t, netResource)
} else { } else {
require.NoError(t, err) require.NoError(t, err)
require.NotNil(t, networkResource) require.NotNil(t, netResource)
require.Equal(t, tt.networkResourceID, networkResource.ID) require.Equal(t, tt.netResourceID, netResource.ID)
} }
}) })
} }
@ -2412,7 +2412,7 @@ func TestSqlStore_SaveNetworkResource(t *testing.T) {
accountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b" accountID := "bf1c8084-ba50-4ce7-9439-34653001fc3b"
networkID := "ct286bi7qv930dsrrug0" networkID := "ct286bi7qv930dsrrug0"
netResource, err := networks.NewNetworkResource(accountID, networkID, "resource-name", "resource-description", "example.com") netResource, err := networks.NewNetworkResource(accountID, networkID, "resource-name", "", "example.com")
require.NoError(t, err) require.NoError(t, err)
err = store.SaveNetworkResource(context.Background(), LockingStrengthUpdate, netResource) err = store.SaveNetworkResource(context.Background(), LockingStrengthUpdate, netResource)
@ -2434,10 +2434,10 @@ func TestSqlStore_DeleteNetworkResource(t *testing.T) {
err = store.DeleteNetworkResource(context.Background(), LockingStrengthUpdate, accountID, netResourceID) err = store.DeleteNetworkResource(context.Background(), LockingStrengthUpdate, accountID, netResourceID)
require.NoError(t, err) require.NoError(t, err)
netRouter, err := store.GetNetworkByID(context.Background(), LockingStrengthShare, accountID, netResourceID) netResource, err := store.GetNetworkByID(context.Background(), LockingStrengthShare, accountID, netResourceID)
require.Error(t, err) require.Error(t, err)
sErr, ok := status.FromError(err) sErr, ok := status.FromError(err)
require.True(t, ok) require.True(t, ok)
require.Equal(t, status.NotFound, sErr.Type()) require.Equal(t, status.NotFound, sErr.Type())
require.Nil(t, netRouter) require.Nil(t, netResource)
} }