Properly parse dns resolver address (#622)

Prevent panic when address is empty. Common with older managers, where
resolver is disabled by default as
we receive an empty dns config
This commit is contained in:
Maycon Santos
2022-12-13 12:26:48 +01:00
committed by GitHub
parent 93fcfeae91
commit 7dfef091bb
3 changed files with 53 additions and 11 deletions

View File

@@ -95,7 +95,10 @@ func (n *networkManagerDbusConfigurator) applyDNSConfig(config hostDNSConfig) er
connSettings.cleanDeprecatedSettings()
dnsIP := netip.MustParseAddr(config.serverIP)
dnsIP, err := netip.ParseAddr(config.serverIP)
if err != nil {
return fmt.Errorf("unable to parse ip address, error: %s", err)
}
convDNSIP := binary.LittleEndian.Uint32(dnsIP.AsSlice())
connSettings[networkManagerDbusIPv4Key][networkManagerDbusDNSKey] = dbus.MakeVariant([]uint32{convDNSIP})
var (