extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-06-26 04:31:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix panic if login cmd fails

Browse Source
This commit is contained in:
Viktor Liu 2025-01-11 02:10:27 +01:00
parent 648b22aca1
commit 8430c37dd6
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
client/ssh/server.go
View File

@ -168,8 +168,12 @@ func (srv *DefaultServer) sessionHandler(session ssh.Session) {
cmd := exec.Command(loginCmd, loginArgs...) cmd := exec.Command(loginCmd, loginArgs...)
go func() { go func() {
<-session.Context().Done() <-session.Context().Done()
if cmd.Process == nil {
return
}
err := cmd.Process.Kill() err := cmd.Process.Kill()
if err != nil { if err != nil {
log.Debugf("failed killing SSH process %v", err)
return return
} }
}() }()
@ -185,7 +189,7 @@ func (srv *DefaultServer) sessionHandler(session ssh.Session) {
log.Debugf("Login command: %s", cmd.String()) log.Debugf("Login command: %s", cmd.String())
file, err := pty.Start(cmd) file, err := pty.Start(cmd)
if err != nil { if err != nil {
log.Errorf("failed starting SSH server %v", err) log.Errorf("failed starting SSH server: %v", err)
} }
go func() { go func() {