extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2024-12-24 15:48:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add comment clarifying AddPeer race check (#927)

Browse Source
This commit is contained in:
Misha Bragin 2023-06-02 18:04:24 +02:00 committed by GitHub
parent 51502af218
commit 8817765aeb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
management/server/peer.go
View File

@ -495,6 +495,11 @@ func (am *DefaultAccountManager) AddPeer(setupKey, userID string, peer *Peer) (*
return nil, nil, err return nil, nil, err
} }
// This is a handling for the case when the same machine (with the same WireGuard pub key) tries to register twice.
// Such case is possible when AddPeer function takes long time to finish after AcquireAccountLock (e.g., database is slow)
// and the peer disconnects with a timeout and tries to register again.
// We just check if this machine has been registered before and reject the second registration.
// The connecting peer should be able to recover with a retry.
_, err = account.FindPeerByPubKey(peer.Key) _, err = account.FindPeerByPubKey(peer.Key)
if err == nil { if err == nil {
return nil, nil, status.Errorf(status.PreconditionFailed, "peer has been already registered") return nil, nil, status.Errorf(status.PreconditionFailed, "peer has been already registered")