mirror of
https://github.com/netbirdio/netbird.git
synced 2025-05-31 07:07:42 +02:00
Rollback stopping management client within engine stop (#204)
* start close handler when using console * don't close management client within engine stop
This commit is contained in:
parent
0739038d51
commit
98dc5824ce
@ -22,11 +22,13 @@ var (
|
|||||||
Short: "install, login and start wiretrustee client",
|
Short: "install, login and start wiretrustee client",
|
||||||
RunE: func(cmd *cobra.Command, args []string) error {
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
SetFlagsFromEnvVars()
|
SetFlagsFromEnvVars()
|
||||||
|
|
||||||
err := loginCmd.RunE(cmd, args)
|
err := loginCmd.RunE(cmd, args)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
if logFile == "console" {
|
if logFile == "console" {
|
||||||
|
SetupCloseHandler()
|
||||||
return runClient()
|
return runClient()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -96,13 +96,7 @@ func (e *Engine) Stop() error {
|
|||||||
e.syncMsgMux.Lock()
|
e.syncMsgMux.Lock()
|
||||||
defer e.syncMsgMux.Unlock()
|
defer e.syncMsgMux.Unlock()
|
||||||
|
|
||||||
err := e.mgmClient.Close()
|
err := e.removeAllPeers()
|
||||||
if err != nil {
|
|
||||||
log.Errorf("failed closing engine's management client: %v", err)
|
|
||||||
return err
|
|
||||||
}
|
|
||||||
|
|
||||||
err = e.removeAllPeers()
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
@ -351,7 +351,11 @@ func TestEngine_MultiplePeers(t *testing.T) {
|
|||||||
|
|
||||||
// cleanup test
|
// cleanup test
|
||||||
for _, peerEngine := range engines {
|
for _, peerEngine := range engines {
|
||||||
errStop := peerEngine.Stop()
|
errStop := peerEngine.mgmClient.Close()
|
||||||
|
if errStop != nil {
|
||||||
|
log.Infoln("got error trying to close management clients from engine: ", errStop)
|
||||||
|
}
|
||||||
|
errStop = peerEngine.Stop()
|
||||||
if errStop != nil {
|
if errStop != nil {
|
||||||
log.Infoln("got error trying to close testing peers engine: ", errStop)
|
log.Infoln("got error trying to close testing peers engine: ", errStop)
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user