From 9872bee41db34da97e075c2f4491b4db9d57d9b8 Mon Sep 17 00:00:00 2001 From: bcmmbaga Date: Tue, 12 Nov 2024 23:53:29 +0300 Subject: [PATCH] Refactor anyGroupHasPeers to retrieve all groups once Signed-off-by: bcmmbaga --- management/server/group.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/management/server/group.go b/management/server/group.go index 5d3014169..758b28b76 100644 --- a/management/server/group.go +++ b/management/server/group.go @@ -609,12 +609,12 @@ func (am *DefaultAccountManager) anyGroupHasPeers(account *Account, groupIDs []s // anyGroupHasPeers checks if any of the given groups in the account have peers. func anyGroupHasPeers(ctx context.Context, transaction Store, accountID string, groupIDs []string) (bool, error) { - for _, groupID := range groupIDs { - group, err := transaction.GetGroupByID(ctx, LockingStrengthShare, accountID, groupID) - if err != nil { - return false, err - } + groups, err := transaction.GetGroupsByIDs(ctx, LockingStrengthShare, accountID, groupIDs) + if err != nil { + return false, err + } + for _, group := range groups { if group.HasPeers() { return true, nil }