extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2024-11-07 08:44:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Skip state notification should use a copy of the previous peer state (#960)

Browse Source 
This was affecting the behavior of the route manager,
causing issues with HA and with cases of flaky connections
This commit is contained in:
Maycon Santos 2023-06-17 09:03:52 +02:00 committed by GitHub
parent 09ca2d222a
commit a4350c19e7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/internal/peer/status.go
View File

@ -135,6 +135,8 @@ func (d *Status) UpdatePeerState(receivedState State) error {
peerState.IP = receivedState.IP
}
skipNotification := shouldSkipNotify(receivedState, peerState)
if receivedState.ConnStatus != peerState.ConnStatus {
peerState.ConnStatus = receivedState.ConnStatus
peerState.ConnStatusUpdate = receivedState.ConnStatusUpdate
@ -146,7 +148,7 @@ func (d *Status) UpdatePeerState(receivedState State) error {
d.peers[receivedState.PubKey] = peerState
if shouldSkipNotify(receivedState, peerState) {
if skipNotification {
return nil
}