mirror of
https://github.com/netbirdio/netbird.git
synced 2024-11-24 00:54:01 +01:00
Add contribution guide (#595)
* Add contribution guide * update code of conduct contact email * add PR template
This commit is contained in:
Maycon Santos
GitHub
parent
0cf0dc048b
commit
a6d2f673ad
10
.github/pull_request_template.md
vendored
Normal file
10
.github/pull_request_template.md
vendored
Normal file
@ -0,0 +1,10 @@
|
|||||||
|
## Describe your changes
|
||||||
|
|
||||||
|
## Issue ticket number and link
|
||||||
|
|
||||||
|
### Checklist
|
||||||
|
- [ ] Is it a bug fix
|
||||||
|
- [ ] Is a typo/documentation fix
|
||||||
|
- [ ] Is a feature enhancement
|
||||||
|
- [ ] Created tests that fail without the change (if possible)
|
||||||
|
- [ ] Extended the README / documentation, if necessary
|
||||||
@ -60,7 +60,7 @@ representative at an online or offline event.
|
|||||||
|
|
||||||
Instances of abusive, harassing, or otherwise unacceptable behavior may be
|
Instances of abusive, harassing, or otherwise unacceptable behavior may be
|
||||||
reported to the community leaders responsible for enforcement at
|
reported to the community leaders responsible for enforcement at
|
||||||
dev@wiretrustee.com.
|
community@netbird.io.
|
||||||
All complaints will be reviewed and investigated promptly and fairly.
|
All complaints will be reviewed and investigated promptly and fairly.
|
||||||
|
|
||||||
All community leaders are obligated to respect the privacy and security of the
|
All community leaders are obligated to respect the privacy and security of the
|
||||||
|
|||||||
218
CONTRIBUTING.md
Normal file
218
CONTRIBUTING.md
Normal file
@ -0,0 +1,218 @@
|
|||||||
|
# Contributing to NetBird
|
||||||
|
|
||||||
|
Thanks for your interest in contributing to NetBird.
|
||||||
|
|
||||||
|
There are many ways that you can contribute:
|
||||||
|
- Reporting issues
|
||||||
|
- Updating documentation
|
||||||
|
- Sharing use cases in slack or Reddit
|
||||||
|
- Bug fix or feature enhancement
|
||||||
|
|
||||||
|
If you haven't already, join our slack workspace [here](https://join.slack.com/t/netbirdio/shared_invite/zt-vrahf41g-ik1v7fV8du6t0RwxSrJ96A), we would love to discuss topics that need community contribution and enhancements to existing features.
|
||||||
|
|
||||||
|
## Contents
|
||||||
|
|
||||||
|
- [Contributing to NetBird](#contributing-to-netbird)
|
||||||
|
- [Contents](#contents)
|
||||||
|
- [Code of conduct](#code-of-conduct)
|
||||||
|
- [Directory structure](#directory-structure)
|
||||||
|
- [Development setup](#development-setup)
|
||||||
|
- [Requirements](#requirements)
|
||||||
|
- [Local NetBird setup](#local-netbird-setup)
|
||||||
|
- [Build and start](#build-and-start)
|
||||||
|
- [Test suite](#test-suite)
|
||||||
|
- [Checklist before submitting a PR](#checklist-before-submitting-a-pr)
|
||||||
|
- [Other project repositories](#other-project-repositories)
|
||||||
|
- [Checklist before submitting a new node](#checklist-before-submitting-a-new-node)
|
||||||
|
- [Contributor License Agreement](#contributor-license-agreement)
|
||||||
|
|
||||||
|
## Code of conduct
|
||||||
|
|
||||||
|
This project and everyone participating in it are governed by the Code of
|
||||||
|
Conduct which can be found in the file [CODE_OF_CONDUCT.md](CODE_OF_CONDUCT.md).
|
||||||
|
By participating, you are expected to uphold this code. Please report
|
||||||
|
unacceptable behavior to community@netbird.io.
|
||||||
|
|
||||||
|
## Directory structure
|
||||||
|
|
||||||
|
The NetBird project monorepo is organized to maintain most of its individual dependencies code within their directories, except for a few auxiliary or shared packages.
|
||||||
|
|
||||||
|
The most important directories are:
|
||||||
|
|
||||||
|
- [/.github](/.github) - Github actions workflow files and issue templates
|
||||||
|
- [/client](/client) - NetBird agent code
|
||||||
|
- [/client/cmd](/client/cmd) - NetBird agent cli code
|
||||||
|
- [/client/internal](/client/internal) - NetBird agent business logic code
|
||||||
|
- [/client/proto](/client/proto) - NetBird agent daemon GRPC proto files
|
||||||
|
- [/client/server](/client/server) - NetBird agent daemon code for background execution
|
||||||
|
- [/client/ui](/client/ui) - NetBird agent UI code
|
||||||
|
- [/encryption](/encryption) - Contain main encryption code for agent communication
|
||||||
|
- [/iface](/iface) - Wireguard® interface code
|
||||||
|
- [/infrastructure_files](/infrastructure_files) - Getting started files containing docker and template scripts
|
||||||
|
- [/management](/management) - Management service code
|
||||||
|
- [/management/client](/management/client) - Management service client code which is imported by the agent code
|
||||||
|
- [/management/proto](/management/proto) - Management service GRPC proto files
|
||||||
|
- [/management/server](/management/server) - Management service server code
|
||||||
|
- [/management/server/http](/management/server/http) - Management service REST API code
|
||||||
|
- [/management/server/idp](/management/server/idp) - Management service IDP management code
|
||||||
|
- [/release_files](/release_files) - Files that goes into release packages
|
||||||
|
- [/signal](/signal) - Signal service code
|
||||||
|
- [/signal/client](/signal/client) - Signal service client code which is imported by the agent code
|
||||||
|
- [/signal/peer](/signal/peer) - Signal service peer message logic
|
||||||
|
- [/signal/proto](/signal/proto) - Signal service GRPC proto files
|
||||||
|
- [/signal/server](/signal/server) - Signal service server code
|
||||||
|
|
||||||
|
|
||||||
|
## Development setup
|
||||||
|
|
||||||
|
If you want to contribute to bug fixes or improve existing features, you have to ensure that all needed
|
||||||
|
dependencies are installed. Here is a short guide on how that can be done.
|
||||||
|
|
||||||
|
### Requirements
|
||||||
|
|
||||||
|
#### Go 1.19
|
||||||
|
|
||||||
|
Follow the installation guide from https://go.dev/
|
||||||
|
|
||||||
|
#### UI client - Fyne toolkit
|
||||||
|
|
||||||
|
We use the fyne toolkit in our UI client. You can follow its requirement guide to have all its dependencies installed: https://developer.fyne.io/started/#prerequisites
|
||||||
|
|
||||||
|
#### gRPC
|
||||||
|
You can follow the instructions from the quickstarter guide https://grpc.io/docs/languages/go/quickstart/#prerequisites and then run the `generate.sh` files located in each `proto` directory to generate changes.
|
||||||
|
> **IMPORTANT**: We are very open to contributions that can improve the client daemon protocol. For Signal and Management protocols, please reach out on slack or via github issues with your proposals.
|
||||||
|
|
||||||
|
#### Docker
|
||||||
|
|
||||||
|
Follow the installation guide from https://docs.docker.com/get-docker/
|
||||||
|
|
||||||
|
#### Goreleaser and golangci-lint
|
||||||
|
|
||||||
|
We utilize two tools in our Github actions workflows:
|
||||||
|
- Goreleaser: Used for release packaging. You can follow the installation steps [here](https://goreleaser.com/install/); keep in mind to match the version defined in [release.yml](/.github/workflows/release.yml)
|
||||||
|
- golangci-lint: Used for linting checks. You can follow the installation steps [here](https://golangci-lint.run/usage/install/); keep in mind to match the version defined in [golangci-lint.yml](/.github/workflows/golangci-lint.yml)
|
||||||
|
|
||||||
|
They can be executed from the repository root before every push or PR:
|
||||||
|
|
||||||
|
**Goreleaser**
|
||||||
|
```shell
|
||||||
|
goreleaser --snapshot --rm-dist
|
||||||
|
```
|
||||||
|
**golangci-lint**
|
||||||
|
```shell
|
||||||
|
golangci-lint run
|
||||||
|
```
|
||||||
|
|
||||||
|
### Local NetBird setup
|
||||||
|
|
||||||
|
> **IMPORTANT**: All the steps below have to get executed at least once to get the development setup up and running!
|
||||||
|
|
||||||
|
Now that everything NetBird requires to run is installed, the actual NetBird code can be
|
||||||
|
checked out and set up:
|
||||||
|
|
||||||
|
1. [Fork](https://guides.github.com/activities/forking/#fork) the NetBird repository
|
||||||
|
|
||||||
|
2. Clone your forked repository
|
||||||
|
|
||||||
|
```
|
||||||
|
git clone https://github.com/<your_github_username>/netbird.git
|
||||||
|
```
|
||||||
|
|
||||||
|
3. Go into the repository folder
|
||||||
|
|
||||||
|
```
|
||||||
|
cd netbird
|
||||||
|
```
|
||||||
|
|
||||||
|
4. Add the original NetBird repository as `upstream` to your forked repository
|
||||||
|
|
||||||
|
```
|
||||||
|
git remote add upstream https://github.com/netbirdio/netbird.git
|
||||||
|
```
|
||||||
|
|
||||||
|
5. Install all Go dependencies:
|
||||||
|
|
||||||
|
```
|
||||||
|
go mod tidy
|
||||||
|
```
|
||||||
|
|
||||||
|
### Build and start
|
||||||
|
#### Client
|
||||||
|
|
||||||
|
> Windows clients have a Wireguard driver requirement. We provide a bash script that can be executed in WLS 2 with docker support [wireguard_nt.sh](/client/wireguard_nt.sh).
|
||||||
|
|
||||||
|
To start NetBird, execute:
|
||||||
|
```
|
||||||
|
cd client
|
||||||
|
# bash wireguard_nt.sh # if windows
|
||||||
|
go build .
|
||||||
|
```
|
||||||
|
|
||||||
|
To start NetBird the client in the foreground:
|
||||||
|
|
||||||
|
```
|
||||||
|
sudo ./client up --log-level debug --log-file console
|
||||||
|
```
|
||||||
|
> On Windows use a powershell with administrator privileges
|
||||||
|
#### Signal service
|
||||||
|
|
||||||
|
To start NetBird's signal, execute:
|
||||||
|
|
||||||
|
```
|
||||||
|
cd signal
|
||||||
|
go build .
|
||||||
|
```
|
||||||
|
|
||||||
|
To start NetBird the signal service:
|
||||||
|
|
||||||
|
```
|
||||||
|
./signal run --log-level debug --log-file console
|
||||||
|
```
|
||||||
|
|
||||||
|
#### Management service
|
||||||
|
> You may need to generate a configuration file for management. Follow steps 2 to 5 from our [self-hosting guide](https://netbird.io/docs/getting-started/self-hosting).
|
||||||
|
|
||||||
|
To start NetBird's management, execute:
|
||||||
|
|
||||||
|
```
|
||||||
|
cd management
|
||||||
|
go build .
|
||||||
|
```
|
||||||
|
|
||||||
|
To start NetBird the management service:
|
||||||
|
|
||||||
|
```
|
||||||
|
./management management --log-level debug --log-file console --config ./management.json
|
||||||
|
```
|
||||||
|
|
||||||
|
### Test suite
|
||||||
|
|
||||||
|
The tests can be started via:
|
||||||
|
|
||||||
|
```
|
||||||
|
cd netbird
|
||||||
|
go test -exec sudo ./...
|
||||||
|
```
|
||||||
|
> On Windows use a powershell with administrator privileges
|
||||||
|
|
||||||
|
## Checklist before submitting a PR
|
||||||
|
As a critical network service and open-source project, we must enforce a few things before submitting the pull-requests:
|
||||||
|
- Keep functions as simple as possible, with a single purpose
|
||||||
|
- Use private functions and constants where possible
|
||||||
|
- Comment on any new public functions
|
||||||
|
- Add unit tests for any new public function
|
||||||
|
|
||||||
|
> When pushing fixes to the PR comments, please push as separate commits; we will squash the PR before merging, so there is no need to squash it before pushing it, and we are more than okay with 10-100 commits in a single PR. This helps review the fixes to the requested changes.
|
||||||
|
|
||||||
|
## Other project repositories
|
||||||
|
|
||||||
|
NetBird project is composed of 3 main repositories:
|
||||||
|
- NetBird: This repository, which contains the code for the agents and control plane services.
|
||||||
|
- Dashboard: https://github.com/netbirdio/dashboard, contains the Administration UI for the management service
|
||||||
|
- Documentations: https://github.com/netbirdio/docs, contains the documentation from https://netbird.io/docs
|
||||||
|
|
||||||
|
## Contributor License Agreement
|
||||||
|
|
||||||
|
That we do not have any potential problems later it is sadly necessary to sign a [Contributor License Agreement](CONTRIBUTOR_LICENSE_AGREEMENT.md). That can be done literally with the push of a button.
|
||||||
|
|
||||||
|
A bot will automatically comment on the pull request once it got opened asking for the agreement to be signed. Before it did not get signed it is sadly not possible to merge it in.
|
||||||
148
CONTRIBUTOR_LICENSE_AGREEMENT.md
Normal file
148
CONTRIBUTOR_LICENSE_AGREEMENT.md
Normal file
@ -0,0 +1,148 @@
|
|||||||
|
# Contributor License Agreement
|
||||||
|
|
||||||
|
We are incredibly thankful for the contributions we receive from the community.
|
||||||
|
We require our external contributors to sign a Contributor License Agreement ("CLA") in
|
||||||
|
order to ensure that our projects remain licensed under Free and Open Source licenses such
|
||||||
|
as BSD-3 while allowing Wiretrustee to build a sustainable business.
|
||||||
|
|
||||||
|
Wiretrustee is committed to having a true Open Source Software ("OSS") license for
|
||||||
|
our software. A CLA enables Wiretrustee to safely commercialize our products
|
||||||
|
while keeping a standard OSS license with all the rights that license grants to users: the
|
||||||
|
ability to use the project in their own projects or businesses, to republish modified
|
||||||
|
source, or to completely fork the project.
|
||||||
|
|
||||||
|
This page gives a human-friendly summary of our CLA, details on why we require a CLA, how
|
||||||
|
contributors can sign our CLA, and more. You may view the full legal CLA document (below).
|
||||||
|
|
||||||
|
# Human-friendly summary
|
||||||
|
|
||||||
|
This is a human-readable summary of (and not a substitute for) the full agreement (below).
|
||||||
|
This highlights only some of key terms of the CLA. It has no legal value and you should
|
||||||
|
carefully review all the terms of the actual CLA before agreeing.
|
||||||
|
|
||||||
|
<li>Grant of copyright license. You give Wiretrustee permission to use your copyrighted work
|
||||||
|
in commercial products.
|
||||||
|
</li>
|
||||||
|
|
||||||
|
<li>Grant of patent license. If your contributed work uses a patent, you give Wiretrustee a
|
||||||
|
license to use that patent including within commercial products. You also agree that you
|
||||||
|
have permission to grant this license.
|
||||||
|
</li>
|
||||||
|
|
||||||
|
<li>No Warranty or Support Obligations.
|
||||||
|
By making a contribution, you are not obligating yourself to provide support for the
|
||||||
|
contribution, and you are not taking on any warranty obligations or providing any
|
||||||
|
assurances about how it will perform.
|
||||||
|
</li>
|
||||||
|
|
||||||
|
The CLA does not change the terms of the standard open source license used by our software
|
||||||
|
such as BSD-3 or MIT.
|
||||||
|
You are still free to use our projects within your own projects or businesses, republish
|
||||||
|
modified source, and more.
|
||||||
|
Please reference the appropriate license for the project you're contributing to to learn
|
||||||
|
more.
|
||||||
|
|
||||||
|
# Why require a CLA?
|
||||||
|
|
||||||
|
Agreeing to a CLA explicitly states that you are entitled to provide a contribution, that you cannot withdraw permission
|
||||||
|
to use your contribution at a later date, and that Wiretrustee has permission to use your contribution in our commercial
|
||||||
|
products.
|
||||||
|
|
||||||
|
This removes any ambiguities or uncertainties caused by not having a CLA and allows users and customers to confidently
|
||||||
|
adopt our projects. At the same time, the CLA ensures that all contributions to our open source projects are licensed
|
||||||
|
under the project's respective open source license, such as BSD-3.
|
||||||
|
|
||||||
|
Requiring a CLA is a common and well-accepted practice in open source. Major open source projects require CLAs such as
|
||||||
|
Apache Software Foundation projects, Facebook projects (such as React), Google projects (including Go), Python, Django,
|
||||||
|
and more. Each of these projects remains licensed under permissive OSS licenses such as MIT, Apache, BSD, and more.
|
||||||
|
|
||||||
|
# Signing the CLA
|
||||||
|
|
||||||
|
Open a pull request ("PR") to any of our open source projects to sign the CLA. A bot will comment on the PR asking you
|
||||||
|
to sign the CLA if you haven't already.
|
||||||
|
|
||||||
|
Follow the steps given by the bot to sign the CLA. This will require you to log in with GitHub (we only request public
|
||||||
|
information from your account) and to fill in a few additional details such as your name and email address. We will only
|
||||||
|
use this information for CLA tracking; none of your submitted information will be used for marketing purposes.
|
||||||
|
|
||||||
|
You only have to sign the CLA once. Once you've signed the CLA, future contributions to any Wiretrustee project will not
|
||||||
|
require you to sign again.
|
||||||
|
|
||||||
|
# Legal Terms and Agreement
|
||||||
|
|
||||||
|
In order to clarify the intellectual property license granted with Contributions from any person or entity, Wiretrustee
|
||||||
|
UG (haftungsbeschränkt) ("Wiretrustee") must have a Contributor License Agreement ("CLA") on file that has been signed
|
||||||
|
by each Contributor, indicating agreement to the license terms below. This license does not change your rights to use
|
||||||
|
your own Contributions for any other purpose.
|
||||||
|
|
||||||
|
You accept and agree to the following terms and conditions for Your present and future Contributions submitted to
|
||||||
|
Wiretrustee. Except for the license granted herein to Wiretrustee and recipients of software distributed by Wiretrustee,
|
||||||
|
You reserve all right, title, and interest in and to Your Contributions.
|
||||||
|
|
||||||
|
1. Definitions.
|
||||||
|
|
||||||
|
```
|
||||||
|
"You" (or "Your") shall mean the copyright owner or legal entity authorized by the copyright owner
|
||||||
|
that is making this Agreement with Wiretrustee. For legal entities, the entity making a Contribution and all other
|
||||||
|
entities that control, are controlled by, or are under common control with that entity are considered
|
||||||
|
to be a single Contributor. For the purposes of this definition, "control" means (i) the power, direct or indirect,
|
||||||
|
to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty
|
||||||
|
percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
|
||||||
|
```
|
||||||
|
```
|
||||||
|
"Contribution" shall mean any original work of authorship, including any modifications or additions to
|
||||||
|
an existing work, that is or previously has been intentionally submitted by You to Wiretrustee for inclusion in,
|
||||||
|
or documentation of, any of the products owned or managed by Wiretrustee (the "Work").
|
||||||
|
For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication
|
||||||
|
sent to Wiretrustee or its representatives, including but not limited to communication on electronic mailing lists,
|
||||||
|
source code control systems, and issue tracking systems that are managed by, or on behalf of,
|
||||||
|
Wiretrustee for the purpose of discussing and improving the Work, but excluding communication that is conspicuously
|
||||||
|
marked or otherwise designated in writing by You as "Not a Contribution."
|
||||||
|
```
|
||||||
|
|
||||||
|
2. Grant of Copyright License. Subject to the terms and conditions of this Agreement, You hereby grant to Wiretrustee
|
||||||
|
and to recipients of software distributed by Wiretrustee a perpetual, worldwide, non-exclusive, no-charge,
|
||||||
|
royalty-free, irrevocable copyright license to reproduce, prepare derivative works of, publicly display, publicly
|
||||||
|
perform, sublicense, and distribute Your Contributions and such derivative works.
|
||||||
|
|
||||||
|
|
||||||
|
3. Grant of Patent License. Subject to the terms and conditions of this Agreement, You hereby grant to Wiretrustee and
|
||||||
|
to recipients of software distributed by Wiretrustee a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
|
||||||
|
irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import,
|
||||||
|
and otherwise transfer the Work, where such license applies only to those patent claims licensable by You that are
|
||||||
|
necessarily infringed by Your Contribution(s) alone or by combination of Your Contribution(s) with the Work to which
|
||||||
|
such Contribution(s) was submitted. If any entity institutes patent litigation against You or any other entity (
|
||||||
|
including a cross-claim or counterclaim in a lawsuit) alleging that your Contribution, or the Work to which you have
|
||||||
|
contributed, constitutes direct or contributory patent infringement, then any patent licenses granted to that entity
|
||||||
|
under this Agreement for that Contribution or Work shall terminate as of the date such litigation is filed.
|
||||||
|
|
||||||
|
|
||||||
|
4. You represent that you are legally entitled to grant the above license. If your employer(s) has rights to
|
||||||
|
intellectual property that you create that includes your Contributions, you represent that you have received
|
||||||
|
permission to make Contributions on behalf of that employer, that you will have received permission from your current
|
||||||
|
and future employers for all future Contributions, that your applicable employer has waived such rights for all of
|
||||||
|
your current and future Contributions to Wiretrustee, or that your employer has executed a separate Corporate CLA
|
||||||
|
with Wiretrustee.
|
||||||
|
|
||||||
|
|
||||||
|
5. You represent that each of Your Contributions is Your original creation (see section 7 for submissions on behalf of
|
||||||
|
others). You represent that Your Contribution submissions include complete details of any third-party license or
|
||||||
|
other restriction (including, but not limited to, related patents and trademarks) of which you are personally aware
|
||||||
|
and which are associated with any part of Your Contributions.
|
||||||
|
|
||||||
|
|
||||||
|
6. You are not expected to provide support for Your Contributions, except to the extent You desire to provide support.
|
||||||
|
You may provide support for free, for a fee, or not at all. Unless required by applicable law or agreed to in
|
||||||
|
writing, You provide Your Contributions on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
|
||||||
|
express or implied, including, without limitation, any warranties or conditions of TITLE, NON- INFRINGEMENT,
|
||||||
|
MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE.
|
||||||
|
|
||||||
|
|
||||||
|
7. Should You wish to submit work that is not Your original creation, You may submit it to Wiretrustee separately from
|
||||||
|
any Contribution, identifying the complete details of its source and of any license or other restriction (including,
|
||||||
|
but not limited to, related patents, trademarks, and license agreements) of which you are personally aware, and
|
||||||
|
conspicuously marking the work as "Submitted on behalf of a third-party: [named here]".
|
||||||
|
|
||||||
|
|
||||||
|
8. You agree to notify Wiretrustee of any facts or circumstances of which you become aware that would make these
|
||||||
|
representations inaccurate in any respect.
|
||||||
Loading…
Reference in New Issue
Block a user