From a789e9e6d8c922050f6020ad1fdf164c9bd67e7e Mon Sep 17 00:00:00 2001
From: Pascal Fischer <32096965+pascal-fischer@users.noreply.github.com>
Date: Wed, 5 Feb 2025 21:42:09 +0100
Subject: [PATCH] [management] fix duplication detection (#3286)

---
 management/server/types/firewall_rule.go | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/management/server/types/firewall_rule.go b/management/server/types/firewall_rule.go
index 118a6a3d2..10923828d 100644
--- a/management/server/types/firewall_rule.go
+++ b/management/server/types/firewall_rule.go
@@ -3,6 +3,7 @@ package types
 import (
 	"context"
 	"fmt"
+	"reflect"
 	"strconv"
 	"strings"
 
@@ -40,11 +41,7 @@ type FirewallRule struct {
 
 // Equal checks if two firewall rules are equal.
 func (r *FirewallRule) Equal(other *FirewallRule) bool {
-	return r.PeerIP == other.PeerIP &&
-		r.Direction == other.Direction &&
-		r.Action == other.Action &&
-		r.Protocol == other.Protocol &&
-		r.Port == other.Port
+	return reflect.DeepEqual(r, other)
 }
 
 // generateRouteFirewallRules generates a list of firewall rules for a given route.