From a8d03d8c91fb895a187e19adfb49a1cac06a9f41 Mon Sep 17 00:00:00 2001 From: Maycon Santos Date: Wed, 25 Oct 2023 17:51:05 +0200 Subject: [PATCH] Fix redirect urls template processing (#1251) removed duplicated key and added tests --- .github/workflows/test-infrastructure-files.yml | 1 + infrastructure_files/management.json.tmpl | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-infrastructure-files.yml b/.github/workflows/test-infrastructure-files.yml index 29f868a64..6482b716f 100644 --- a/.github/workflows/test-infrastructure-files.yml +++ b/.github/workflows/test-infrastructure-files.yml @@ -119,6 +119,7 @@ jobs: grep -A 10 PKCEAuthorizationFlow management.json | grep -A 10 ProviderConfig | grep AuthorizationEndpoint | grep $CI_NETBIRD_AUTH_PKCE_AUTHORIZATION_ENDPOINT grep -A 10 PKCEAuthorizationFlow management.json | grep -A 10 ProviderConfig | grep TokenEndpoint | grep $CI_NETBIRD_AUTH_TOKEN_ENDPOINT grep -A 10 PKCEAuthorizationFlow management.json | grep -A 10 ProviderConfig | grep Scope | grep "$CI_NETBIRD_AUTH_SUPPORTED_SCOPES" + grep -A 10 PKCEAuthorizationFlow management.json | grep -A 10 ProviderConfig | grep -A 3 RedirectURLs | grep "http://localhost:53000" - name: Install modules run: go mod tidy diff --git a/infrastructure_files/management.json.tmpl b/infrastructure_files/management.json.tmpl index ece953515..64c2d0816 100644 --- a/infrastructure_files/management.json.tmpl +++ b/infrastructure_files/management.json.tmpl @@ -82,8 +82,7 @@ "TokenEndpoint": "$NETBIRD_AUTH_TOKEN_ENDPOINT", "Scope": "$NETBIRD_AUTH_SUPPORTED_SCOPES", "RedirectURLs": [$NETBIRD_AUTH_PKCE_REDIRECT_URLS], - "UseIDToken": $NETBIRD_AUTH_PKCE_USE_ID_TOKEN, - "RedirectURLs": null + "UseIDToken": $NETBIRD_AUTH_PKCE_USE_ID_TOKEN } } }