extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-02-02 19:39:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove the number of status notifications on disconnected peers (#946)

Browse Source 
Only send notifications when disconnected once, at peer's IP update
This commit is contained in:
Maycon Santos 2023-06-11 21:51:33 +02:00 committed by GitHub
parent a0296f7839
commit c331cef242
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
client/internal/peer/status.go
View File

@ -146,8 +146,7 @@ func (d *Status) UpdatePeerState(receivedState State) error {
d.peers[receivedState.PubKey] = peerState d.peers[receivedState.PubKey] = peerState
if receivedState.ConnStatus == StatusConnecting || if shouldSkipNotify(receivedState, peerState) {
(receivedState.ConnStatus == StatusDisconnected && peerState.ConnStatus == StatusConnecting) {
return nil return nil
} }
@ -161,6 +160,19 @@ func (d *Status) UpdatePeerState(receivedState State) error {
return nil return nil
} }
func shouldSkipNotify(new, curr State) bool {
switch {
case new.ConnStatus == StatusConnecting:
return true
case new.ConnStatus == StatusDisconnected && curr.ConnStatus == StatusConnecting:
return true
case new.ConnStatus == StatusDisconnected && curr.ConnStatus == StatusDisconnected:
return curr.IP != ""
default:
return false
}
}
// UpdatePeerFQDN update peer's state fqdn only // UpdatePeerFQDN update peer's state fqdn only
func (d *Status) UpdatePeerFQDN(peerPubKey, fqdn string) error { func (d *Status) UpdatePeerFQDN(peerPubKey, fqdn string) error {
d.mux.Lock() d.mux.Lock()