extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-06-19 17:31:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Handle other icmp types in forwarder

Browse Source
This commit is contained in:
Viktor Liu 2025-01-02 15:18:00 +01:00
parent 7667886794
commit d85e57e819
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
client/firewall/uspfilter/forwarder/icmp.go
View File

@ -37,7 +37,8 @@ func (f *Forwarder) handleICMP(id stack.TransportEndpointID, pkt stack.PacketBuf
icmpHdr := header.ICMPv4(pkt.TransportHeader().View().AsSlice()) icmpHdr := header.ICMPv4(pkt.TransportHeader().View().AsSlice())
// For Echo Requests, send and handle response // For Echo Requests, send and handle response
if icmpHdr.Type() == header.ICMPv4Echo { switch icmpHdr.Type() {
case header.ICMPv4Echo:
_, err = conn.WriteTo(payload, dst) _, err = conn.WriteTo(payload, dst)
if err != nil { if err != nil {
f.logger.Error("Failed to write ICMP packet for %v: %v", id, err) f.logger.Error("Failed to write ICMP packet for %v: %v", id, err)
@ -48,9 +49,21 @@ func (f *Forwarder) handleICMP(id stack.TransportEndpointID, pkt stack.PacketBuf
id, icmpHdr.Type(), icmpHdr.Code()) id, icmpHdr.Type(), icmpHdr.Code())
return f.handleEchoResponse(conn, id) return f.handleEchoResponse(conn, id)
case header.ICMPv4EchoReply:
// dont process our own replies
return false
default:
} }
// TODO: forward other ICMP types // For other ICMP types (Time Exceeded, Destination Unreachable, etc)
_, err = conn.WriteTo(payload, dst)
if err != nil {
f.logger.Error("Failed to write ICMP packet for %v: %v", id, err)
return false
}
f.logger.Trace("Forwarded ICMP packet %v type=%v code=%v",
id, icmpHdr.Type(), icmpHdr.Code())
return true return true
} }