extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2024-11-25 17:43:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Properly handle cache error and return userdata (#1571)

Browse Source
This commit is contained in:
Maycon Santos 2024-02-12 21:54:16 +01:00 committed by GitHub
parent 88747e3e01
commit dd14db6478
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
management/server/account.go
View File

@ -1231,14 +1231,12 @@ func (am *DefaultAccountManager) lookupUserInCache(userID string, account *Accou
key := user.IntegrationReference.CacheKey(account.Id, userID) key := user.IntegrationReference.CacheKey(account.Id, userID)
ud, err := am.externalCacheManager.Get(am.ctx, key) ud, err := am.externalCacheManager.Get(am.ctx, key)
if err == nil { if err != nil {
log.Errorf("failed to get externalCache for key: %s, error: %s", key, err) log.Errorf("failed to get externalCache for key: %s, error: %s", key, err)
return ud, status.Errorf(status.NotFound, "user %s not found in the IdP", userID) return nil, status.Errorf(status.NotFound, "user %s not found in the IdP", userID)
} }
log.Infof("user %s not found in any cache", userID) return ud, nil
return nil, nil //nolint:nilnil
} }
func (am *DefaultAccountManager) refreshCache(accountID string) ([]*idp.UserData, error) { func (am *DefaultAccountManager) refreshCache(accountID string) ([]*idp.UserData, error) {