extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-06-24 11:41:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

Count only successful HTTP request durations (#886)

Browse Source
This commit is contained in:
Misha Bragin 2023-05-22 16:26:36 +02:00 committed by GitHub
parent 48265b32f3
commit f66574b094
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
management/server/telemetry/http_api_metrics.go
View File

@ -163,16 +163,6 @@ func getResponseCounterKey(endpoint, method string, status int) string {
func (m *HTTPMiddleware) Handler(h http.Handler) http.Handler { func (m *HTTPMiddleware) Handler(h http.Handler) http.Handler {
fn := func(rw http.ResponseWriter, r *http.Request) { fn := func(rw http.ResponseWriter, r *http.Request) {
reqStart := time.Now() reqStart := time.Now()
defer func() {
tookMs := time.Since(reqStart).Milliseconds()
m.totalHTTPRequestDuration.Record(m.ctx, tookMs)
if r.Method == http.MethodPut || r.Method == http.MethodPost || r.Method == http.MethodDelete {
m.totalHTTPRequestDuration.Record(m.ctx, tookMs, attribute.String("type", "write"))
} else {
m.totalHTTPRequestDuration.Record(m.ctx, tookMs, attribute.String("type", "read"))
}
}()
traceID := hash(fmt.Sprintf("%v", r)) traceID := hash(fmt.Sprintf("%v", r))
log.Tracef("HTTP request %v: %v %v", traceID, r.Method, r.URL) log.Tracef("HTTP request %v: %v %v", traceID, r.Method, r.URL)
@ -208,7 +198,13 @@ func (m *HTTPMiddleware) Handler(h http.Handler) http.Handler {
if c, ok := m.httpRequestDurations[durationKey]; ok { if c, ok := m.httpRequestDurations[durationKey]; ok {
c.Record(m.ctx, reqTook.Milliseconds()) c.Record(m.ctx, reqTook.Milliseconds())
} }
log.Debugf("request %s %s took %d ms", r.Method, r.URL.Path, reqTook.Milliseconds()) log.Debugf("request %s %s took %d ms and finished with status %d", r.Method, r.URL.Path, reqTook.Milliseconds(), w.Status())
if w.Status() == 200 && (r.Method == http.MethodPut || r.Method == http.MethodPost || r.Method == http.MethodDelete) {
m.totalHTTPRequestDuration.Record(m.ctx, reqTook.Milliseconds(), attribute.String("type", "write"))
} else {
m.totalHTTPRequestDuration.Record(m.ctx, reqTook.Milliseconds(), attribute.String("type", "read"))
}
} }