extern/netbird
1
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2025-02-01 02:49:30 +01:00
Code Issues Packages Projects Releases Wiki Activity
1,926 Commits 156 Branches 207 Tags 209 MiB
b15ee5c07c
Commit Graph

164 Commits

Author SHA1 Message Date
bcmmbaga
84aea32118
Refactor peer scheduler to retry every 3 seconds on errors 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2025-01-14 22:13:11 +03:00
bcmmbaga
ce7385119a
Use integrated validator direct 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2025-01-14 20:58:43 +03:00
bcmmbaga
48af90c770
Get account direct from store without buffer 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2025-01-13 19:18:18 +03:00
bcmmbaga
3cc6d3862d
Improve peer performance 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2025-01-13 17:52:39 +03:00
bcmmbaga
d1e5d584f7
Fix merge 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2025-01-13 16:12:34 +03:00
bcmmbaga
b1325267d8
Merge branch 'main' into peers-get-account-refactoring 
# Conflicts:
#	management/server/peer.go
 2025-01-13 15:54:37 +03:00
Bethuel Mmbaga
168ea9560e
[Management] Send peer network map when SSH status is toggled (#3172) 2025-01-11 13:19:30 +01:00
bcmmbaga
2e596fbf1a
use account object to get validated peers 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2025-01-10 13:37:38 +03:00
bcmmbaga
baf211203a
fix merge 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2025-01-08 23:17:54 +03:00
bcmmbaga
9d86f76a24
Merge branch 'main' into peers-get-account-refactoring 
# Conflicts:
#	management/server/account.go
#	management/server/account_test.go
#	management/server/ephemeral.go
#	management/server/ephemeral_test.go
#	management/server/http/handlers/peers/peers_handler.go
#	management/server/http/handlers/peers/peers_handler_test.go
#	management/server/integrated_validator.go
#	management/server/mock_server/account_mock.go
#	management/server/peer.go
#	management/server/store/sql_store.go
#	management/server/store/sql_store_test.go
#	management/server/store/store.go
#	management/server/testdata/store_with_expired_peers.sql
#	management/server/user.go
 2025-01-08 22:31:10 +03:00
Bethuel Mmbaga
02a3feddb8
[management] Add MySQL Support (#3108) 
* Add mysql store support
* Add support to disable activity events recording
 2025-01-06 13:38:30 +01:00
Viktor Liu
ddc365f7a0
[client, management] Add new network concept (#3047) 
---------

Co-authored-by: Pascal Fischer <32096965+pascal-fischer@users.noreply.github.com>
Co-authored-by: bcmmbaga <bethuelmbaga12@gmail.com>
Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>
Co-authored-by: Zoltan Papp <zoltan.pmail@gmail.com>
 2024-12-20 11:30:28 +01:00
Bethuel Mmbaga
97bb74f824
Remove peer login log (#3005) 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-12-09 18:40:06 +01:00
bcmmbaga
9a96b91d9d
Fix merge 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-12-09 14:21:28 +01:00
bcmmbaga
a05bd464cd
Merge branch 'main' into peers-get-account-refactoring 
# Conflicts:
#	management/server/peer.go
 2024-12-06 13:45:23 +03:00
M. Essam
713e320c4c
Update account peers on login on meta change (#2991) 
* Update account peers on login on meta change

* Factor out LoginPeer peer not found handling
 2024-12-05 14:15:23 +01:00
Pascal Fischer
d063fbb8b9
[management] merge update account peers in sync call (#2978) 2024-12-03 16:41:19 +01:00
Joakim Nohlgård
7dacd9cb23
[management] Add missing parentheses on iphone hostname generation condition (#2977) 2024-12-03 13:49:02 +01:00
bcmmbaga
d66140fc82
Fix merge 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-28 15:08:42 +03:00
bcmmbaga
dea6886394
Merge branch 'main' into peers-get-account-refactoring 
# Conflicts:
#	management/server/peer.go
 2024-11-28 15:07:52 +03:00
Pascal Fischer
00c3b67182
[management] refactor to use account object instead of separate db calls for peer update (#2957) 2024-11-28 11:13:01 +01:00
bcmmbaga
fde9f2ffda
Add store locks and prevent fetching setup keys peers when retrieving user peers with empty userID 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-28 12:18:02 +03:00
bcmmbaga
b2139875d9
Merge branch 'nameserver-get-account-refactoring' into peers-get-account-refactoring 
# Conflicts:
#	management/server/account.go
#	management/server/http/peers_handler.go
#	management/server/peer.go
 2024-11-27 13:18:17 +03:00
Bethuel Mmbaga
ca12bc6953
[management] Refactor posture check to use store methods (#2874) 2024-11-25 16:26:24 +01:00
Pascal Fischer
f66bbcc54c
[management] Add metric for peer meta update (#2913) 2024-11-19 18:13:26 +01:00
Pascal Fischer
5dd6a08ea6
link peer meta update back to account object (#2911) 2024-11-19 17:25:49 +01:00
Pascal Fischer
52ea2e84e9
[management] Add transaction metrics and exclude getAccount time from peers update (#2904) 2024-11-19 00:04:50 +01:00
bcmmbaga
a2a49bdd47
fix peer fields updated after save 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-18 16:43:09 +03:00
bcmmbaga
a2fb274b86
remove duplicate store method 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-18 15:09:30 +03:00
bcmmbaga
a61e9da3e9
run peer ops in transaction 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-18 15:06:25 +03:00
Bethuel Mmbaga
12f442439a
[management] Refactor group to use store methods (#2867) 
* Refactor setup key handling to use store methods

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add lock to get account groups

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add check for regular user

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* get only required groups for auto-group validation

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add account lock and return auto groups map on validation

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* refactor account peers update

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Refactor groups to use store methods

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* refactor GetGroupByID and add NewGroupNotFoundError

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Add AddPeer and RemovePeer methods to Group struct

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Preserve store engine in SqlStore transactions

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Run groups ops in transaction

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix missing group removed from setup key activity

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix merge

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix merge

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix sonar

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Change setup key log level to debug for missing group

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Retrieve modified peers once for group events

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Add tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Add account locking and merge group deletion methods

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Fix tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

---------

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-15 20:09:32 +03:00
Pascal Fischer
4aee3c9e33
[client/management] add peer lock to peer meta update and fix isEqual func (#2840) 2024-11-15 16:59:03 +01:00
bcmmbaga
c557c98390
Refactor peer to use store methods 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-14 19:33:57 +03:00
bcmmbaga
147971fdfe
Merge branch 'groups-get-account-refactoring' into policy-get-account-refactoring 2024-11-12 17:15:16 +03:00
bcmmbaga
ed259a6a03
Merge branch 'main' into groups-get-account-refactoring 
# Conflicts:
#	management/server/account.go
#	management/server/status/error.go
 2024-11-12 17:14:45 +03:00
Pascal Fischer
20a5afc359
[management] Add more logs to the peer update processes (#2881) 2024-11-12 14:19:22 +01:00
Bethuel Mmbaga
6cb697eed6
[management] Refactor setup key to use store methods (#2861) 
* Refactor setup key handling to use store methods

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add lock to get account groups

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add check for regular user

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* get only required groups for auto-group validation

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add account lock and return auto groups map on validation

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix missing group removed from setup key activity

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Remove context from DB queries

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Add user permission check and add setup events into events to store slice

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Retrieve all groups once during setup key auto-group validation

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Fix lint

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Fix sonar

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

---------

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-11 19:46:10 +03:00
bcmmbaga
d54b6967ce
fix refactor 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-11 12:38:34 +03:00
bcmmbaga
bdeb95c58c
Run groups ops in transaction 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-09 01:17:01 +03:00
bcmmbaga
106fc75936
refactor account peers update 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-08 18:38:32 +03:00
bcmmbaga
78044c226d
add lock to get account groups 
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-11-08 00:32:14 +03:00
Pascal Fischer
3e88b7c56e
[management] Fix network map update on peer validation (#2849) 2024-11-07 09:50:13 +01:00
Pascal Fischer
a9d06b883f
add all group to add peer affected peers network map check (#2830) 2024-11-01 22:09:08 +01:00
pascal-fischer
10480eb52f
[management] Setup key improvements (#2775) 2024-10-28 17:52:23 +01:00
Bethuel Mmbaga
7bda385e1b
[management] Optimize network map updates (#2718) 
* Skip peer update on unchanged network map (#2236)

* Enhance network updates by skipping unchanged messages

Optimizes the network update process
by skipping updates where no changes in the peer update message received.

* Add unit tests

* add locks

* Improve concurrency and update peer message handling

* Refactor account manager network update tests

* fix test

* Fix inverted network map update condition

* Add default group and policy to test data

* Run peer updates in a separate goroutine

* Refactor

* Refactor lock

* Fix peers update by including NetworkMap and posture Checks

* go mod tidy

* fix merge

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix merge

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* [management] Skip account peers update if no changes affect peers (#2310)

* Remove incrementing network serial and updating peers after group deletion

* Update account peer if posture check is linked to policy

* Remove account peers update on saving setup key

* Refactor group link checking into re-usable functions

* Add HasPeers function to group

* Refactor group management

* Optimize group change effects on account peers

* Update account peers if ns group has peers

* Refactor group changes

* Optimize account peers update in DNS settings

* Optimize update of account peers on jwt groups sync

* Refactor peer account updates for efficiency

* Optimize peer update on user deletion and changes

* Remove condition check for network serial update

* Optimize account peers updates on route changes

* Remove UpdatePeerSSHKey method

* Remove unused isPolicyRuleGroupsEmpty

* Add tests for peer update behavior on posture check changes

* Add tests for peer update behavior on policy changes

* Add tests for peer update behavior on group changes

* Add tests for peer update behavior on dns settings changes

* Refactor

* Add tests for peer update behavior on name server changes

* Add tests for peer update behavior on user changes

* Add tests for peer update behavior on route changes

* fix tests

* Add tests for peer update behavior on setup key changes

* Add tests for peer update behavior on peers changes

* fix merge

* Fix tests

* go mod tidy

* Add NameServer and Route comparators

* Update network map diff logic with custom comparators

* Add tests

* Refactor duplicate diff handling logic

* fix linter

* fix tests

* Refactor policy group handling and update logic.

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Update route check by checking if group has peers

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Refactor posture check policy linking logic

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Simplify peer update condition in DNS management

Refactor the condition for updating account peers to remove redundant checks

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix merge

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add policy tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add posture checks tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix user and setup key tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix account and route tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix typo

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix nameserver tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix routes tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix group tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* upgrade diff package

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix nameserver tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* use generic differ for netip.Addr and netip.Prefix

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* go mod tidy

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add peer tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix merge

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix management suite tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* fix postgres tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* enable diff nil structs comparison

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* skip the update only last sent the serial is larger

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* refactor peer and user

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* skip spell check for groupD

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Refactor group, ns group, policy and posture checks

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* skip spell check for GroupD

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* update account policy check before verifying policy status

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Update management/server/route_test.go

Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>

* Update management/server/route_test.go

Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>

* Update management/server/route_test.go

Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>

* Update management/server/route_test.go

Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>

* Update management/server/route_test.go

Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>

* add tests missing tests for dns setting groups

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add tests for posture checks changes

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add ns group and policy tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add route and group tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* increase Linux test timeout to 10 minutes

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Run diff for client posture checks only

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* add panic recovery and detailed logging in peer update comparison

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* Fix tests

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

---------

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>

---------

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Co-authored-by: Maycon Santos <mlsmaycon@gmail.com>
 2024-10-23 13:05:02 +03:00
ctrl-zzz
49e65109d2
Add session expire functionality based on inactivity (#2326) 
Implemented inactivity expiration by checking the status of a peer: after a configurable period of time following netbird down, the peer shows login required.
 2024-10-13 14:52:43 +02:00
Bethuel Mmbaga
2c1f5e46d5
[management] Validate peer ownership during login (#2704) 
* check peer ownership in login

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

* update error message

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

---------

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
 2024-10-07 19:06:26 +03:00
pascal-fischer
6c50b0c84b
[management] Add transaction to addPeer (#2469) 
This PR removes the GetAccount and SaveAccount operations from the AddPeer and instead makes use of gorm.Transaction to add the new peer.
 2024-09-16 15:47:03 +02:00
pascal-fischer
f43a0a0177
[client] Retry on tun creation for darwin (#2564) 
The interface creation on macOS seems to be asynchronus why the tun.create methode somethimes failes becasue the interface is not ready yet. To work around this issue we introduce a retry on tun.create
 2024-09-09 19:02:10 +02:00
Zoltan Papp
0c039274a4
[relay] Feature/relay integration (#2244) 
This update adds new relay integration for NetBird clients. The new relay is based on web sockets and listens on a single port.

- Adds new relay implementation with websocket with single port relaying mechanism
- refactor peer connection logic, allowing upgrade and downgrade from/to P2P connection
- peer connections are faster since it connects first to relay and then upgrades to P2P
- maintains compatibility with old clients by not using the new relay
- updates infrastructure scripts with new relay service
 2024-09-08 12:06:14 +02:00