mirror of
https://github.com/netbirdio/netbird.git
synced 2024-12-14 10:50:45 +01:00
6886691213
- Add two new test cases for p2p and relay routes with same latency - Add extra statuses generation
411 lines
8.9 KiB
Go
411 lines
8.9 KiB
Go
package routemanager
|
|
|
|
import (
|
|
"fmt"
|
|
"net/netip"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/netbirdio/netbird/client/internal/routemanager/static"
|
|
"github.com/netbirdio/netbird/route"
|
|
)
|
|
|
|
func TestGetBestrouteFromStatuses(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
name string
|
|
statuses map[route.ID]routerPeerStatus
|
|
expectedRouteID route.ID
|
|
currentRoute route.ID
|
|
existingRoutes map[route.ID]*route.Route
|
|
}{
|
|
{
|
|
name: "one route",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: false,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "one connected routes with relayed and direct",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: true,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "one connected routes with relayed and no direct",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: true,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "no connected peers",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: false,
|
|
relayed: false,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "",
|
|
},
|
|
{
|
|
name: "multiple connected peers with different metrics",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: false,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
relayed: false,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: 9000,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "multiple connected peers with one relayed",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: false,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
relayed: true,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "multiple connected peers with different latencies",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
latency: 300 * time.Millisecond,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
latency: 10 * time.Millisecond,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "route2",
|
|
},
|
|
{
|
|
name: "should ignore routes with latency 0",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
latency: 0 * time.Millisecond,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
latency: 10 * time.Millisecond,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "",
|
|
expectedRouteID: "route2",
|
|
},
|
|
{
|
|
name: "current route with similar score and similar but slightly worse latency should not change",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 15 * time.Millisecond,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 10 * time.Millisecond,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "route1",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "relayed routes with latency 0 should maintain previous choice",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: true,
|
|
latency: 0 * time.Millisecond,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
relayed: true,
|
|
latency: 0 * time.Millisecond,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "route1",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "p2p routes with latency 0 should maintain previous choice",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 0 * time.Millisecond,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 0 * time.Millisecond,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "route1",
|
|
expectedRouteID: "route1",
|
|
},
|
|
{
|
|
name: "current route with bad score should be changed to route with better score",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 200 * time.Millisecond,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 10 * time.Millisecond,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "route1",
|
|
expectedRouteID: "route2",
|
|
},
|
|
{
|
|
name: "current chosen route doesn't exist anymore",
|
|
statuses: map[route.ID]routerPeerStatus{
|
|
"route1": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 20 * time.Millisecond,
|
|
},
|
|
"route2": {
|
|
connected: true,
|
|
relayed: false,
|
|
latency: 10 * time.Millisecond,
|
|
},
|
|
},
|
|
existingRoutes: map[route.ID]*route.Route{
|
|
"route1": {
|
|
ID: "route1",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer1",
|
|
},
|
|
"route2": {
|
|
ID: "route2",
|
|
Metric: route.MaxMetric,
|
|
Peer: "peer2",
|
|
},
|
|
},
|
|
currentRoute: "routeDoesntExistAnymore",
|
|
expectedRouteID: "route2",
|
|
},
|
|
}
|
|
|
|
// fill the test data with random routes
|
|
for _, tc := range testCases {
|
|
for i := 0; i < 50; i++ {
|
|
dummyRoute := &route.Route{
|
|
ID: route.ID(fmt.Sprintf("dummy_p1_%d", i)),
|
|
Metric: route.MinMetric,
|
|
Peer: fmt.Sprintf("dummy_p1_%d", i),
|
|
}
|
|
tc.existingRoutes[dummyRoute.ID] = dummyRoute
|
|
}
|
|
for i := 0; i < 50; i++ {
|
|
dummyRoute := &route.Route{
|
|
ID: route.ID(fmt.Sprintf("dummy_p2_%d", i)),
|
|
Metric: route.MinMetric,
|
|
Peer: fmt.Sprintf("dummy_p1_%d", i),
|
|
}
|
|
tc.existingRoutes[dummyRoute.ID] = dummyRoute
|
|
}
|
|
|
|
for i := 0; i < 50; i++ {
|
|
id := route.ID(fmt.Sprintf("dummy_p1_%d", i))
|
|
dummyStatus := routerPeerStatus{
|
|
connected: false,
|
|
relayed: true,
|
|
latency: 0,
|
|
}
|
|
tc.statuses[id] = dummyStatus
|
|
}
|
|
for i := 0; i < 50; i++ {
|
|
id := route.ID(fmt.Sprintf("dummy_p2_%d", i))
|
|
dummyStatus := routerPeerStatus{
|
|
connected: false,
|
|
relayed: true,
|
|
latency: 0,
|
|
}
|
|
tc.statuses[id] = dummyStatus
|
|
}
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
currentRoute := &route.Route{
|
|
ID: "routeDoesntExistAnymore",
|
|
}
|
|
if tc.currentRoute != "" {
|
|
currentRoute = tc.existingRoutes[tc.currentRoute]
|
|
}
|
|
|
|
// create new clientNetwork
|
|
client := &clientNetwork{
|
|
handler: static.NewRoute(&route.Route{Network: netip.MustParsePrefix("192.168.0.0/24")}, nil, nil),
|
|
routes: tc.existingRoutes,
|
|
currentChosen: currentRoute,
|
|
}
|
|
|
|
chosenRoute := client.getBestRouteFromStatuses(tc.statuses)
|
|
if chosenRoute != tc.expectedRouteID {
|
|
t.Errorf("expected routeID %s, got %s", tc.expectedRouteID, chosenRoute)
|
|
}
|
|
})
|
|
}
|
|
}
|