mirror of
https://github.com/netbirdio/netbird.git
synced 2024-12-04 22:10:56 +01:00
ce0718fcb5
* serialize net.IP as json * migrate net ip field from blob to json * run net ip migration * remove duplicate index * Refactor * Add tests * fix tests * migrate null blob values
162 lines
5.0 KiB
Go
162 lines
5.0 KiB
Go
package migration_test
|
|
|
|
import (
|
|
"encoding/gob"
|
|
"net"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"gorm.io/driver/sqlite"
|
|
"gorm.io/gorm"
|
|
|
|
"github.com/netbirdio/netbird/management/server"
|
|
"github.com/netbirdio/netbird/management/server/migration"
|
|
nbpeer "github.com/netbirdio/netbird/management/server/peer"
|
|
"github.com/netbirdio/netbird/route"
|
|
)
|
|
|
|
func setupDatabase(t *testing.T) *gorm.DB {
|
|
t.Helper()
|
|
|
|
db, err := gorm.Open(sqlite.Open("file::memory:?cache=shared"), &gorm.Config{
|
|
PrepareStmt: true,
|
|
})
|
|
|
|
require.NoError(t, err, "Failed to open database")
|
|
return db
|
|
}
|
|
|
|
func TestMigrateFieldFromGobToJSON_EmptyDB(t *testing.T) {
|
|
db := setupDatabase(t)
|
|
err := migration.MigrateFieldFromGobToJSON[server.Account, net.IPNet](db, "network_net")
|
|
require.NoError(t, err, "Migration should not fail for an empty database")
|
|
}
|
|
|
|
func TestMigrateFieldFromGobToJSON_WithGobData(t *testing.T) {
|
|
db := setupDatabase(t)
|
|
|
|
err := db.AutoMigrate(&server.Account{}, &route.Route{})
|
|
require.NoError(t, err, "Failed to auto-migrate tables")
|
|
|
|
_, ipnet, err := net.ParseCIDR("10.0.0.0/24")
|
|
require.NoError(t, err, "Failed to parse CIDR")
|
|
|
|
type network struct {
|
|
server.Network
|
|
Net net.IPNet `gorm:"serializer:gob"`
|
|
}
|
|
|
|
type account struct {
|
|
server.Account
|
|
Network *network `gorm:"embedded;embeddedPrefix:network_"`
|
|
}
|
|
|
|
err = db.Save(&account{Account: server.Account{Id: "123"}, Network: &network{Net: *ipnet}}).Error
|
|
require.NoError(t, err, "Failed to insert Gob data")
|
|
|
|
var gobStr string
|
|
err = db.Model(&server.Account{}).Select("network_net").First(&gobStr).Error
|
|
assert.NoError(t, err, "Failed to fetch Gob data")
|
|
|
|
err = gob.NewDecoder(strings.NewReader(gobStr)).Decode(&ipnet)
|
|
require.NoError(t, err, "Failed to decode Gob data")
|
|
|
|
err = migration.MigrateFieldFromGobToJSON[server.Account, net.IPNet](db, "network_net")
|
|
require.NoError(t, err, "Migration should not fail with Gob data")
|
|
|
|
var jsonStr string
|
|
db.Model(&server.Account{}).Select("network_net").First(&jsonStr)
|
|
assert.JSONEq(t, `{"IP":"10.0.0.0","Mask":"////AA=="}`, jsonStr, "Data should be migrated")
|
|
}
|
|
|
|
func TestMigrateFieldFromGobToJSON_WithJSONData(t *testing.T) {
|
|
db := setupDatabase(t)
|
|
|
|
err := db.AutoMigrate(&server.Account{}, &route.Route{})
|
|
require.NoError(t, err, "Failed to auto-migrate tables")
|
|
|
|
_, ipnet, err := net.ParseCIDR("10.0.0.0/24")
|
|
require.NoError(t, err, "Failed to parse CIDR")
|
|
|
|
err = db.Save(&server.Account{Network: &server.Network{Net: *ipnet}}).Error
|
|
require.NoError(t, err, "Failed to insert JSON data")
|
|
|
|
err = migration.MigrateFieldFromGobToJSON[server.Account, net.IPNet](db, "network_net")
|
|
require.NoError(t, err, "Migration should not fail with JSON data")
|
|
|
|
var jsonStr string
|
|
db.Model(&server.Account{}).Select("network_net").First(&jsonStr)
|
|
assert.JSONEq(t, `{"IP":"10.0.0.0","Mask":"////AA=="}`, jsonStr, "Data should be unchanged")
|
|
}
|
|
|
|
func TestMigrateNetIPFieldFromBlobToJSON_EmptyDB(t *testing.T) {
|
|
db := setupDatabase(t)
|
|
err := migration.MigrateNetIPFieldFromBlobToJSON[nbpeer.Peer](db, "ip", "idx_peers_account_id_ip")
|
|
require.NoError(t, err, "Migration should not fail for an empty database")
|
|
}
|
|
|
|
func TestMigrateNetIPFieldFromBlobToJSON_WithBlobData(t *testing.T) {
|
|
db := setupDatabase(t)
|
|
|
|
err := db.AutoMigrate(&server.Account{}, &nbpeer.Peer{})
|
|
require.NoError(t, err, "Failed to auto-migrate tables")
|
|
|
|
type location struct {
|
|
nbpeer.Location
|
|
ConnectionIP net.IP
|
|
}
|
|
|
|
type peer struct {
|
|
nbpeer.Peer
|
|
Location location `gorm:"embedded;embeddedPrefix:location_"`
|
|
}
|
|
|
|
type account struct {
|
|
server.Account
|
|
Peers []peer `gorm:"foreignKey:AccountID;references:id"`
|
|
}
|
|
|
|
err = db.Save(&account{
|
|
Account: server.Account{Id: "123"},
|
|
Peers: []peer{
|
|
{Location: location{ConnectionIP: net.IP{10, 0, 0, 1}}},
|
|
}},
|
|
).Error
|
|
require.NoError(t, err, "Failed to insert blob data")
|
|
|
|
var blobValue string
|
|
err = db.Model(&nbpeer.Peer{}).Select("location_connection_ip").First(&blobValue).Error
|
|
assert.NoError(t, err, "Failed to fetch blob data")
|
|
|
|
err = migration.MigrateNetIPFieldFromBlobToJSON[nbpeer.Peer](db, "location_connection_ip", "")
|
|
require.NoError(t, err, "Migration should not fail with net.IP blob data")
|
|
|
|
var jsonStr string
|
|
db.Model(&nbpeer.Peer{}).Select("location_connection_ip").First(&jsonStr)
|
|
assert.JSONEq(t, `"10.0.0.1"`, jsonStr, "Data should be migrated")
|
|
}
|
|
|
|
func TestMigrateNetIPFieldFromBlobToJSON_WithJSONData(t *testing.T) {
|
|
db := setupDatabase(t)
|
|
|
|
err := db.AutoMigrate(&server.Account{}, &nbpeer.Peer{})
|
|
require.NoError(t, err, "Failed to auto-migrate tables")
|
|
|
|
err = db.Save(&server.Account{
|
|
Id: "1234",
|
|
PeersG: []nbpeer.Peer{
|
|
{Location: nbpeer.Location{ConnectionIP: net.IP{10, 0, 0, 1}}},
|
|
}},
|
|
).Error
|
|
require.NoError(t, err, "Failed to insert JSON data")
|
|
|
|
err = migration.MigrateNetIPFieldFromBlobToJSON[nbpeer.Peer](db, "location_connection_ip", "")
|
|
require.NoError(t, err, "Migration should not fail with net.IP JSON data")
|
|
|
|
var jsonStr string
|
|
db.Model(&nbpeer.Peer{}).Select("location_connection_ip").First(&jsonStr)
|
|
assert.JSONEq(t, `"10.0.0.1"`, jsonStr, "Data should be unchanged")
|
|
}
|