netbird/management/server/posture/os_version_test.go

package posture

import (
	"context"
	"testing"

	"github.com/netbirdio/netbird/management/server/peer"

	"github.com/stretchr/testify/assert"
)

func TestOSVersionCheck_Check(t *testing.T) {
	tests := []struct {
		name    string
		input   peer.Peer
		check   OSVersionCheck
		wantErr bool
		isValid bool
	}{
		{
			name: "Valid Peer Windows Kernel version",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:          "linux",
					KernelVersion: "10.0.20348.2227",
				},
			},
			check: OSVersionCheck{
				Linux: &MinKernelVersionCheck{
					MinKernelVersion: "10.0.20340.2200",
				},
			},
			wantErr: false,
			isValid: true,
		},
		{
			name: "Valid Peer Linux Kernel version",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:          "linux",
					KernelVersion: "6.1.1",
				},
			},
			check: OSVersionCheck{
				Linux: &MinKernelVersionCheck{
					MinKernelVersion: "6.0.0",
				},
			},
			wantErr: false,
			isValid: true,
		},
		{
			name: "Valid Peer Linux Kernel version with suffix",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:          "linux",
					KernelVersion: "6.5.11-linuxkit",
				},
			},
			check: OSVersionCheck{
				Linux: &MinKernelVersionCheck{
					MinKernelVersion: "6.0.0",
				},
			},
			wantErr: false,
			isValid: true,
		},
		{
			name: "Not valid Peer macOS version",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:      "darwin",
					OSVersion: "14.2.1",
				},
			},
			check: OSVersionCheck{
				Darwin: &MinVersionCheck{
					MinVersion: "15",
				},
			},
			wantErr: false,
			isValid: false,
		},
		{
			name: "Valid Peer ios version allowed by any rule",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:      "ios",
					OSVersion: "17.0.1",
				},
			},
			check: OSVersionCheck{
				Ios: &MinVersionCheck{
					MinVersion: "0",
				},
			},
			wantErr: false,
			isValid: true,
		},
		{
			name: "Valid Peer android version not allowed by rule",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:      "android",
					OSVersion: "14",
				},
			},
			check:   OSVersionCheck{},
			wantErr: false,
			isValid: false,
		},
		{
			name: "Valid Peer Linux Kernel version not allowed by rule",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:          "linux",
					KernelVersion: "6.1.1",
				},
			},
			check:   OSVersionCheck{},
			wantErr: false,
			isValid: false,
		},
		{
			name: "Invalid Peer Linux kernel version",
			input: peer.Peer{
				Meta: peer.PeerSystemMeta{
					GoOS:          "linux",
					KernelVersion: "x.y.1",
				},
			},
			check: OSVersionCheck{
				Linux: &MinKernelVersionCheck{
					MinKernelVersion: "6.0.0",
				},
			},
			wantErr: true,
			isValid: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			isValid, err := tt.check.Check(context.Background(), tt.input)
			if tt.wantErr {
				assert.Error(t, err)
			} else {
				assert.NoError(t, err)
			}
			assert.Equal(t, tt.isValid, isValid)
		})
	}
}

func TestOSVersionCheck_Validate(t *testing.T) {
	testCases := []struct {
		name          string
		check         OSVersionCheck
		expectedError bool
	}{
		{
			name: "Valid linux kernel version",
			check: OSVersionCheck{
				Linux: &MinKernelVersionCheck{MinKernelVersion: "6.0"},
			},
			expectedError: false,
		},
		{
			name: "Valid linux and darwin version",
			check: OSVersionCheck{
				Linux:  &MinKernelVersionCheck{MinKernelVersion: "6.0"},
				Darwin: &MinVersionCheck{MinVersion: "14.2"},
			},
			expectedError: false,
		},
		{
			name:          "Invalid empty check",
			check:         OSVersionCheck{},
			expectedError: true,
		},
		{
			name: "Invalid empty linux kernel version",
			check: OSVersionCheck{
				Linux: &MinKernelVersionCheck{},
			},
			expectedError: true,
		},
		{
			name: "Invalid empty linux kernel version with correct darwin version",
			check: OSVersionCheck{
				Linux:  &MinKernelVersionCheck{},
				Darwin: &MinVersionCheck{MinVersion: "14.2"},
			},
			expectedError: true,
		},
		{
			name: "Valid windows kernel version",
			check: OSVersionCheck{
				Windows: &MinKernelVersionCheck{MinKernelVersion: "10.0"},
			},
			expectedError: false,
		},
		{
			name: "Valid ios minimum version",
			check: OSVersionCheck{
				Ios: &MinVersionCheck{MinVersion: "13.0"},
			},
			expectedError: false,
		},
		{
			name: "Invalid empty window version with valid ios minimum version",
			check: OSVersionCheck{
				Windows: &MinKernelVersionCheck{},
				Ios:     &MinVersionCheck{MinVersion: "13.0"},
			},
			expectedError: true,
		},
	}
	for _, tc := range testCases {
		t.Run(tc.name, func(t *testing.T) {
			err := tc.check.Validate()
			if tc.expectedError {
				assert.Error(t, err)
			} else {
				assert.NoError(t, err)
			}
		})
	}
}