mirror of
https://github.com/netbirdio/netbird.git
synced 2024-12-15 03:11:02 +01:00
acb73bd64a
* refactor access control middleware and user access by JWT groups Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * refactor jwt groups extractor Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * refactor handlers to get account when necessary Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * refactor getAccountFromToken Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * refactor getAccountWithAuthorizationClaims Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * fix merge Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * revert handles change Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * remove GetUserByID from account manager Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * fix tests Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * refactor getAccountWithAuthorizationClaims to return account id Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * refactor handlers to use GetAccountIDFromToken Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * fix tests Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * remove locks Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * refactor Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * add GetGroupByName from store Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * add GetGroupByID from store and refactor Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * Refactor retrieval of policy and posture checks Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * Refactor user permissions and retrieves PAT Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * Refactor route, setupkey, nameserver and dns to get record(s) from store Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * Refactor store Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * fix lint Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * fix tests Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * fix add missing policy source posture checks Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * add store lock Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * fix tests Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> * add get account Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com> --------- Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
153 lines
4.3 KiB
Go
153 lines
4.3 KiB
Go
package http
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/netbirdio/netbird/management/server/http/api"
|
|
"github.com/netbirdio/netbird/management/server/status"
|
|
|
|
"github.com/gorilla/mux"
|
|
|
|
"github.com/netbirdio/netbird/management/server"
|
|
"github.com/netbirdio/netbird/management/server/jwtclaims"
|
|
"github.com/netbirdio/netbird/management/server/mock_server"
|
|
)
|
|
|
|
const (
|
|
testDNSSettingsAccountID = "test_id"
|
|
testDNSSettingsExistingGroup = "test_group"
|
|
testDNSSettingsUserID = "test_user"
|
|
)
|
|
|
|
var baseExistingDNSSettings = server.DNSSettings{
|
|
DisabledManagementGroups: []string{testDNSSettingsExistingGroup},
|
|
}
|
|
|
|
var testingDNSSettingsAccount = &server.Account{
|
|
Id: testDNSSettingsAccountID,
|
|
Domain: "hotmail.com",
|
|
Users: map[string]*server.User{
|
|
testDNSSettingsUserID: server.NewAdminUser("test_user"),
|
|
},
|
|
DNSSettings: baseExistingDNSSettings,
|
|
}
|
|
|
|
func initDNSSettingsTestData() *DNSSettingsHandler {
|
|
return &DNSSettingsHandler{
|
|
accountManager: &mock_server.MockAccountManager{
|
|
GetDNSSettingsFunc: func(ctx context.Context, accountID string, userID string) (*server.DNSSettings, error) {
|
|
return &testingDNSSettingsAccount.DNSSettings, nil
|
|
},
|
|
SaveDNSSettingsFunc: func(ctx context.Context, accountID string, userID string, dnsSettingsToSave *server.DNSSettings) error {
|
|
if dnsSettingsToSave != nil {
|
|
return nil
|
|
}
|
|
return status.Errorf(status.InvalidArgument, "the dns settings provided are nil")
|
|
},
|
|
GetAccountIDFromTokenFunc: func(ctx context.Context, _ jwtclaims.AuthorizationClaims) (string, string, error) {
|
|
return testingDNSSettingsAccount.Id, testingDNSSettingsAccount.Users[testDNSSettingsUserID].Id, nil
|
|
},
|
|
},
|
|
claimsExtractor: jwtclaims.NewClaimsExtractor(
|
|
jwtclaims.WithFromRequestContext(func(r *http.Request) jwtclaims.AuthorizationClaims {
|
|
return jwtclaims.AuthorizationClaims{
|
|
UserId: "test_user",
|
|
Domain: "hotmail.com",
|
|
AccountId: testDNSSettingsAccountID,
|
|
}
|
|
}),
|
|
),
|
|
}
|
|
}
|
|
|
|
func TestDNSSettingsHandlers(t *testing.T) {
|
|
tt := []struct {
|
|
name string
|
|
expectedStatus int
|
|
expectedBody bool
|
|
expectedDNSSettings *api.DNSSettings
|
|
requestType string
|
|
requestPath string
|
|
requestBody io.Reader
|
|
}{
|
|
{
|
|
name: "Get DNS Settings",
|
|
requestType: http.MethodGet,
|
|
requestPath: "/api/dns/settings",
|
|
expectedStatus: http.StatusOK,
|
|
expectedBody: true,
|
|
expectedDNSSettings: &api.DNSSettings{
|
|
DisabledManagementGroups: baseExistingDNSSettings.DisabledManagementGroups,
|
|
},
|
|
},
|
|
{
|
|
name: "Update DNS Settings",
|
|
requestType: http.MethodPut,
|
|
requestPath: "/api/dns/settings",
|
|
requestBody: bytes.NewBuffer(
|
|
[]byte("{\"disabled_management_groups\":[\"group1\",\"group2\"]}")),
|
|
expectedStatus: http.StatusOK,
|
|
expectedBody: true,
|
|
expectedDNSSettings: &api.DNSSettings{
|
|
DisabledManagementGroups: []string{"group1", "group2"},
|
|
},
|
|
},
|
|
{
|
|
name: "Update DNS Settings Empty Body",
|
|
requestType: http.MethodPut,
|
|
requestPath: "/api/dns/settings",
|
|
requestBody: bytes.NewBuffer(
|
|
[]byte("{}")),
|
|
expectedStatus: http.StatusOK,
|
|
expectedBody: true,
|
|
expectedDNSSettings: &api.DNSSettings{},
|
|
},
|
|
}
|
|
|
|
p := initDNSSettingsTestData()
|
|
|
|
for _, tc := range tt {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
recorder := httptest.NewRecorder()
|
|
req := httptest.NewRequest(tc.requestType, tc.requestPath, tc.requestBody)
|
|
|
|
router := mux.NewRouter()
|
|
router.HandleFunc("/api/dns/settings", p.GetDNSSettings).Methods("GET")
|
|
router.HandleFunc("/api/dns/settings", p.UpdateDNSSettings).Methods("PUT")
|
|
router.ServeHTTP(recorder, req)
|
|
|
|
res := recorder.Result()
|
|
defer res.Body.Close()
|
|
|
|
content, err := io.ReadAll(res.Body)
|
|
if err != nil {
|
|
t.Fatalf("I don't know what I expected; %v", err)
|
|
}
|
|
|
|
if status := recorder.Code; status != tc.expectedStatus {
|
|
t.Errorf("handler returned wrong status code: got %v want %v, content: %s",
|
|
status, tc.expectedStatus, string(content))
|
|
return
|
|
}
|
|
|
|
if !tc.expectedBody {
|
|
return
|
|
}
|
|
|
|
got := &api.DNSSettings{}
|
|
if err = json.Unmarshal(content, &got); err != nil {
|
|
t.Fatalf("Sent content is not in correct json format; %v", err)
|
|
}
|
|
assert.Equal(t, tc.expectedDNSSettings, got)
|
|
})
|
|
}
|
|
}
|