mirror of
https://github.com/netbirdio/netbird.git
synced 2025-04-11 13:08:51 +02:00
Avoid creating groups with the same name via API calls. JWT and integrations still allowed to register groups with duplicated names
404 lines
9.9 KiB
Go
404 lines
9.9 KiB
Go
package server
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/rs/xid"
|
|
log "github.com/sirupsen/logrus"
|
|
|
|
"github.com/netbirdio/netbird/management/server/activity"
|
|
"github.com/netbirdio/netbird/management/server/status"
|
|
)
|
|
|
|
type GroupLinkError struct {
|
|
Resource string
|
|
Name string
|
|
}
|
|
|
|
func (e *GroupLinkError) Error() string {
|
|
return fmt.Sprintf("group has been linked to %s: %s", e.Resource, e.Name)
|
|
}
|
|
|
|
const (
|
|
GroupIssuedAPI = "api"
|
|
GroupIssuedJWT = "jwt"
|
|
GroupIssuedIntegration = "integration"
|
|
)
|
|
|
|
// Group of the peers for ACL
|
|
type Group struct {
|
|
// ID of the group
|
|
ID string
|
|
|
|
// AccountID is a reference to Account that this object belongs
|
|
AccountID string `json:"-" gorm:"index"`
|
|
|
|
// Name visible in the UI
|
|
Name string
|
|
|
|
// Issued defines how this group was created (enum of "api", "integration" or "jwt")
|
|
Issued string
|
|
|
|
// Peers list of the group
|
|
Peers []string `gorm:"serializer:json"`
|
|
|
|
IntegrationReference IntegrationReference `gorm:"embedded;embeddedPrefix:integration_ref_"`
|
|
}
|
|
|
|
// EventMeta returns activity event meta related to the group
|
|
func (g *Group) EventMeta() map[string]any {
|
|
return map[string]any{"name": g.Name}
|
|
}
|
|
|
|
func (g *Group) Copy() *Group {
|
|
group := &Group{
|
|
ID: g.ID,
|
|
Name: g.Name,
|
|
Issued: g.Issued,
|
|
Peers: make([]string, len(g.Peers)),
|
|
IntegrationReference: g.IntegrationReference,
|
|
}
|
|
copy(group.Peers, g.Peers)
|
|
return group
|
|
}
|
|
|
|
// GetGroup object of the peers
|
|
func (am *DefaultAccountManager) GetGroup(accountID, groupID string) (*Group, error) {
|
|
unlock := am.Store.AcquireAccountLock(accountID)
|
|
defer unlock()
|
|
|
|
account, err := am.Store.GetAccount(accountID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
group, ok := account.Groups[groupID]
|
|
if ok {
|
|
return group, nil
|
|
}
|
|
|
|
return nil, status.Errorf(status.NotFound, "group with ID %s not found", groupID)
|
|
}
|
|
|
|
// GetGroupByName filters all groups in an account by name and returns the one with the most peers
|
|
func (am *DefaultAccountManager) GetGroupByName(groupName, accountID string) (*Group, error) {
|
|
unlock := am.Store.AcquireAccountLock(accountID)
|
|
defer unlock()
|
|
|
|
account, err := am.Store.GetAccount(accountID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
matchingGroups := make([]*Group, 0)
|
|
for _, group := range account.Groups {
|
|
if group.Name == groupName {
|
|
matchingGroups = append(matchingGroups, group)
|
|
}
|
|
}
|
|
|
|
if len(matchingGroups) == 0 {
|
|
return nil, status.Errorf(status.NotFound, "group with name %s not found", groupName)
|
|
}
|
|
|
|
maxPeers := -1
|
|
var groupWithMostPeers *Group
|
|
for i, group := range matchingGroups {
|
|
if len(group.Peers) > maxPeers {
|
|
maxPeers = len(group.Peers)
|
|
groupWithMostPeers = matchingGroups[i]
|
|
}
|
|
}
|
|
|
|
return groupWithMostPeers, nil
|
|
}
|
|
|
|
// SaveGroup object of the peers
|
|
func (am *DefaultAccountManager) SaveGroup(accountID, userID string, newGroup *Group) error {
|
|
unlock := am.Store.AcquireAccountLock(accountID)
|
|
defer unlock()
|
|
|
|
account, err := am.Store.GetAccount(accountID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if newGroup.ID == "" && newGroup.Issued != GroupIssuedAPI {
|
|
return status.Errorf(status.InvalidArgument, "%s group without ID set", newGroup.Issued)
|
|
}
|
|
|
|
if newGroup.ID == "" && newGroup.Issued == GroupIssuedAPI {
|
|
|
|
existingGroup, err := account.FindGroupByName(newGroup.Name)
|
|
if err != nil {
|
|
s, ok := status.FromError(err)
|
|
if !ok || s.ErrorType != status.NotFound {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// avoid duplicate groups only for the API issued groups. Integration or JWT groups can be duplicated as they are
|
|
// coming from the IdP that we don't have control of.
|
|
if existingGroup != nil {
|
|
return status.Errorf(status.AlreadyExists, "group with name %s already exists", newGroup.Name)
|
|
}
|
|
|
|
newGroup.ID = xid.New().String()
|
|
}
|
|
|
|
for _, peerID := range newGroup.Peers {
|
|
if account.Peers[peerID] == nil {
|
|
return status.Errorf(status.InvalidArgument, "peer with ID \"%s\" not found", peerID)
|
|
}
|
|
}
|
|
|
|
oldGroup, exists := account.Groups[newGroup.ID]
|
|
account.Groups[newGroup.ID] = newGroup
|
|
|
|
account.Network.IncSerial()
|
|
if err = am.Store.SaveAccount(account); err != nil {
|
|
return err
|
|
}
|
|
|
|
am.updateAccountPeers(account)
|
|
|
|
// the following snippet tracks the activity and stores the group events in the event store.
|
|
// It has to happen after all the operations have been successfully performed.
|
|
addedPeers := make([]string, 0)
|
|
removedPeers := make([]string, 0)
|
|
if exists {
|
|
addedPeers = difference(newGroup.Peers, oldGroup.Peers)
|
|
removedPeers = difference(oldGroup.Peers, newGroup.Peers)
|
|
} else {
|
|
addedPeers = append(addedPeers, newGroup.Peers...)
|
|
am.StoreEvent(userID, newGroup.ID, accountID, activity.GroupCreated, newGroup.EventMeta())
|
|
}
|
|
|
|
for _, p := range addedPeers {
|
|
peer := account.Peers[p]
|
|
if peer == nil {
|
|
log.Errorf("peer %s not found under account %s while saving group", p, accountID)
|
|
continue
|
|
}
|
|
am.StoreEvent(userID, peer.ID, accountID, activity.GroupAddedToPeer,
|
|
map[string]any{
|
|
"group": newGroup.Name, "group_id": newGroup.ID, "peer_ip": peer.IP.String(),
|
|
"peer_fqdn": peer.FQDN(am.GetDNSDomain()),
|
|
})
|
|
}
|
|
|
|
for _, p := range removedPeers {
|
|
peer := account.Peers[p]
|
|
if peer == nil {
|
|
log.Errorf("peer %s not found under account %s while saving group", p, accountID)
|
|
continue
|
|
}
|
|
am.StoreEvent(userID, peer.ID, accountID, activity.GroupRemovedFromPeer,
|
|
map[string]any{
|
|
"group": newGroup.Name, "group_id": newGroup.ID, "peer_ip": peer.IP.String(),
|
|
"peer_fqdn": peer.FQDN(am.GetDNSDomain()),
|
|
})
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// difference returns the elements in `a` that aren't in `b`.
|
|
func difference(a, b []string) []string {
|
|
mb := make(map[string]struct{}, len(b))
|
|
for _, x := range b {
|
|
mb[x] = struct{}{}
|
|
}
|
|
var diff []string
|
|
for _, x := range a {
|
|
if _, found := mb[x]; !found {
|
|
diff = append(diff, x)
|
|
}
|
|
}
|
|
return diff
|
|
}
|
|
|
|
// DeleteGroup object of the peers
|
|
func (am *DefaultAccountManager) DeleteGroup(accountId, userId, groupID string) error {
|
|
unlock := am.Store.AcquireAccountLock(accountId)
|
|
defer unlock()
|
|
|
|
account, err := am.Store.GetAccount(accountId)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
g, ok := account.Groups[groupID]
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
// disable a deleting integration group if the initiator is not an admin service user
|
|
if g.Issued == GroupIssuedIntegration {
|
|
executingUser := account.Users[userId]
|
|
if executingUser == nil {
|
|
return status.Errorf(status.NotFound, "user not found")
|
|
}
|
|
if executingUser.Role != UserRoleAdmin || !executingUser.IsServiceUser {
|
|
return status.Errorf(status.PermissionDenied, "only service users with admin power can delete integration group")
|
|
}
|
|
}
|
|
|
|
// check route links
|
|
for _, r := range account.Routes {
|
|
for _, g := range r.Groups {
|
|
if g == groupID {
|
|
return &GroupLinkError{"route", r.NetID}
|
|
}
|
|
}
|
|
}
|
|
|
|
// check DNS links
|
|
for _, dns := range account.NameServerGroups {
|
|
for _, g := range dns.Groups {
|
|
if g == groupID {
|
|
return &GroupLinkError{"name server groups", dns.Name}
|
|
}
|
|
}
|
|
}
|
|
|
|
// check ACL links
|
|
for _, policy := range account.Policies {
|
|
for _, rule := range policy.Rules {
|
|
for _, src := range rule.Sources {
|
|
if src == groupID {
|
|
return &GroupLinkError{"policy", policy.Name}
|
|
}
|
|
}
|
|
|
|
for _, dst := range rule.Destinations {
|
|
if dst == groupID {
|
|
return &GroupLinkError{"policy", policy.Name}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// check setup key links
|
|
for _, setupKey := range account.SetupKeys {
|
|
for _, grp := range setupKey.AutoGroups {
|
|
if grp == groupID {
|
|
return &GroupLinkError{"setup key", setupKey.Name}
|
|
}
|
|
}
|
|
}
|
|
|
|
// check user links
|
|
for _, user := range account.Users {
|
|
for _, grp := range user.AutoGroups {
|
|
if grp == groupID {
|
|
return &GroupLinkError{"user", user.Id}
|
|
}
|
|
}
|
|
}
|
|
|
|
// check DisabledManagementGroups
|
|
for _, disabledMgmGrp := range account.DNSSettings.DisabledManagementGroups {
|
|
if disabledMgmGrp == groupID {
|
|
return &GroupLinkError{"disabled DNS management groups", g.Name}
|
|
}
|
|
}
|
|
|
|
delete(account.Groups, groupID)
|
|
|
|
account.Network.IncSerial()
|
|
if err = am.Store.SaveAccount(account); err != nil {
|
|
return err
|
|
}
|
|
|
|
am.StoreEvent(userId, groupID, accountId, activity.GroupDeleted, g.EventMeta())
|
|
|
|
am.updateAccountPeers(account)
|
|
|
|
return nil
|
|
}
|
|
|
|
// ListGroups objects of the peers
|
|
func (am *DefaultAccountManager) ListGroups(accountID string) ([]*Group, error) {
|
|
unlock := am.Store.AcquireAccountLock(accountID)
|
|
defer unlock()
|
|
|
|
account, err := am.Store.GetAccount(accountID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
groups := make([]*Group, 0, len(account.Groups))
|
|
for _, item := range account.Groups {
|
|
groups = append(groups, item)
|
|
}
|
|
|
|
return groups, nil
|
|
}
|
|
|
|
// GroupAddPeer appends peer to the group
|
|
func (am *DefaultAccountManager) GroupAddPeer(accountID, groupID, peerID string) error {
|
|
unlock := am.Store.AcquireAccountLock(accountID)
|
|
defer unlock()
|
|
|
|
account, err := am.Store.GetAccount(accountID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
group, ok := account.Groups[groupID]
|
|
if !ok {
|
|
return status.Errorf(status.NotFound, "group with ID %s not found", groupID)
|
|
}
|
|
|
|
add := true
|
|
for _, itemID := range group.Peers {
|
|
if itemID == peerID {
|
|
add = false
|
|
break
|
|
}
|
|
}
|
|
if add {
|
|
group.Peers = append(group.Peers, peerID)
|
|
}
|
|
|
|
account.Network.IncSerial()
|
|
if err = am.Store.SaveAccount(account); err != nil {
|
|
return err
|
|
}
|
|
|
|
am.updateAccountPeers(account)
|
|
|
|
return nil
|
|
}
|
|
|
|
// GroupDeletePeer removes peer from the group
|
|
func (am *DefaultAccountManager) GroupDeletePeer(accountID, groupID, peerID string) error {
|
|
unlock := am.Store.AcquireAccountLock(accountID)
|
|
defer unlock()
|
|
|
|
account, err := am.Store.GetAccount(accountID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
group, ok := account.Groups[groupID]
|
|
if !ok {
|
|
return status.Errorf(status.NotFound, "group with ID %s not found", groupID)
|
|
}
|
|
|
|
account.Network.IncSerial()
|
|
for i, itemID := range group.Peers {
|
|
if itemID == peerID {
|
|
group.Peers = append(group.Peers[:i], group.Peers[i+1:]...)
|
|
if err := am.Store.SaveAccount(account); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
am.updateAccountPeers(account)
|
|
|
|
return nil
|
|
}
|