From 078fd93168276da1719b8c47618b72f8e8d97b10 Mon Sep 17 00:00:00 2001
From: Donovan Glover <donovan@dglover.co>
Date: Fri, 23 Aug 2024 19:47:01 -0400
Subject: [PATCH] Revert "overlays: Update picom to v12-rc2 for animations"

After trying the new picom animations for a bit they're a bit too janky
compared to the animations in Hyprland. The "geometry" trigger
replicated the tiling animation when swapping windows, however this came
at the cost of transparency being broken during the animation and the
easing in general not being comparable to Hyprland.

Further issues include the usage of animations breaking fade in/out
support for windows, which I found less intrusive than the appear /
disappear presets with not-so-subtle easing. Using the geometry trigger
also meant that switching tags in dwm had a slide in effect, which felt
disruptive compared to the usual feeling of dwm.

Other issues included the increased probability of things not being
drawn correctly (for example, an animation that "hangs" while in the
middle of animating) and a slightly annoying fade effect every time
windows changed in size such as when toggling fullscreen.

The config used is below for reference, however after trying picom
animations dwm feels considerably better without them.

```
animations = (
  {
    triggers = ["open"];
    preset = "appear";
    scale = 0.5;
  },
  {
    triggers = ["close"];
    preset = "disappear";
    scale = 0.5;
  },
  {
    triggers = ["geometry"];
    preset = "geometry-change";
    duration = 0.5;
  },
);
```
---
 overlays/picom.nix | 16 ----------------
 1 file changed, 16 deletions(-)
 delete mode 100644 overlays/picom.nix

diff --git a/overlays/picom.nix b/overlays/picom.nix
deleted file mode 100644
index 546ed797..00000000
--- a/overlays/picom.nix
+++ /dev/null
@@ -1,16 +0,0 @@
-final: prev: {
-  picom = prev.picom.overrideAttrs (oldAttrs: rec {
-    version = "12-rc2";
-
-    src = prev.fetchFromGitHub {
-      owner = "yshui";
-      repo = "picom";
-      rev = "v${version}";
-      hash = "sha256-59I6uozu4g9hll5U/r0nf4q92+zwRlbOD/z4R8TpSdo=";
-    };
-
-    nativeBuildInputs = oldAttrs.nativeBuildInputs ++ (with prev; [
-      asciidoctor
-    ]);
-  });
-}