2023-04-07 23:09:55 +02:00
|
|
|
use nu_test_support::nu;
|
2020-04-13 09:59:57 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn each_works_separately() {
|
2023-05-18 01:55:26 +02:00
|
|
|
let actual = nu!("echo [1 2 3] | each { |it| echo $it 10 | math sum } | to json -r");
|
2020-04-13 09:59:57 +02:00
|
|
|
|
2020-05-07 13:03:43 +02:00
|
|
|
assert_eq!(actual.out, "[11,12,13]");
|
2020-04-13 09:59:57 +02:00
|
|
|
}
|
2020-09-07 07:54:52 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn each_group_works() {
|
2023-05-18 01:55:26 +02:00
|
|
|
let actual = nu!("echo [1 2 3 4 5 6] | group 3 | to json --raw");
|
2020-09-07 07:54:52 +02:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "[[1,2,3],[4,5,6]]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn each_window() {
|
2023-05-18 01:55:26 +02:00
|
|
|
let actual = nu!("echo [1 2 3 4] | window 3 | to json --raw");
|
2020-09-07 07:54:52 +02:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "[[1,2,3],[2,3,4]]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn each_window_stride() {
|
2023-05-18 01:55:26 +02:00
|
|
|
let actual = nu!("echo [1 2 3 4 5 6] | window 3 -s 2 | to json --raw");
|
2020-09-07 07:54:52 +02:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "[[1,2,3],[3,4,5]]");
|
|
|
|
}
|
2020-10-27 08:37:35 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn each_no_args_in_block() {
|
2023-05-18 01:55:26 +02:00
|
|
|
let actual = nu!("echo [[foo bar]; [a b] [c d] [e f]] | each {|i| $i | to json -r } | get 1");
|
2022-02-04 03:01:45 +01:00
|
|
|
|
2024-03-20 22:14:31 +01:00
|
|
|
assert_eq!(actual.out, r#"{"foo":"c","bar":"d"}"#);
|
2020-10-27 08:37:35 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn each_implicit_it_in_block() {
|
|
|
|
let actual = nu!(
|
2023-04-07 23:09:55 +02:00
|
|
|
"echo [[foo bar]; [a b] [c d] [e f]] | each { |it| nu --testbin cococo $it.foo } | str join"
|
|
|
|
);
|
2020-10-27 08:37:35 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "ace");
|
|
|
|
}
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
#[test]
|
2023-02-02 23:59:58 +01:00
|
|
|
fn each_uses_enumerate_index() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!("[7 8 9 10] | enumerate | each {|el| $el.index } | to nuon");
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "[0, 1, 2, 3]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2023-02-02 23:59:58 +01:00
|
|
|
fn each_while_uses_enumerate_index() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!("[7 8 9 10] | enumerate | each while {|el| $el.index } | to nuon");
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "[0, 1, 2, 3]");
|
|
|
|
}
|
2023-04-15 07:11:02 +02:00
|
|
|
|
Prevent `each` from swallowing errors when `eval_block` returns a `ListStream` (#12412)
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx
you can also mention related issues, PRs or discussions!
-->
# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.
Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
Prior, it seemed that nested errors would not get detected and shown.
This PR fixes that.
Resolves #10176:
```
~/CodingProjects/nushell> [[1,2]] | each {|x| $x | each {|y| error make {msg: "oh noes"} } } 05/04/2024 21:34:08
Error: nu::shell::eval_block_with_input
× Eval block failed with pipeline input
╭─[entry #1:1:3]
1 │ [[1,2]] | each {|x| $x | each {|y| error make {msg: "oh noes"} } }
· ┬
· ╰── source value
╰────
Error: × oh noes
╭─[entry #1:1:36]
1 │ [[1,2]] | each {|x| $x | each {|y| error make {msg: "oh noes"} } }
· ─────┬────
· ╰── originates from here
╰────
```
Resolves #11224:
```
~/CodingProjects/nushell> [0] | each { |_| 05/04/2024 21:35:40
::: [0] | each { |_|
::: non-existent-command
::: }
::: }
Error: nu::shell::eval_block_with_input
× Eval block failed with pipeline input
╭─[entry #1:2:6]
1 │ [0] | each { |_|
2 │ [0] | each { |_|
· ┬
· ╰── source value
3 │ non-existent-command
╰────
Error: nu::shell::external_command
× External command failed
╭─[entry #1:3:9]
2 │ [0] | each { |_|
3 │ non-existent-command
· ──────────┬─────────
· ╰── executable was not found
4 │ }
╰────
help: No such file or directory (os error 2)
```
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2024-05-02 00:24:54 +02:00
|
|
|
#[test]
|
|
|
|
fn errors_in_nested_each_show() {
|
|
|
|
let actual = nu!("[[1,2]] | each {|x| $x | each {|y| error make {msg: \"oh noes\"} } }");
|
|
|
|
assert!(actual.err.contains("oh noes"))
|
|
|
|
}
|