2022-03-17 18:55:02 +01:00
|
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_the_column() {
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
|
|
r#"
|
|
|
|
open cargo_sample.toml
|
|
|
|
| insert dev-dependencies.new_assertions "0.7.0"
|
|
|
|
| get dev-dependencies.new_assertions
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "0.7.0");
|
|
|
|
}
|
|
|
|
|
2022-11-21 14:35:11 +01:00
|
|
|
#[test]
|
|
|
|
fn doesnt_convert_record_to_table() {
|
2023-07-21 17:32:37 +02:00
|
|
|
let actual = nu!("{a:1} | insert b 2 | to nuon");
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "{a: 1, b: 2}");
|
|
|
|
}
|
|
|
|
|
2022-03-17 18:55:02 +01:00
|
|
|
#[test]
|
|
|
|
fn insert_the_column_conflict() {
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
|
|
r#"
|
|
|
|
open cargo_sample.toml
|
|
|
|
| insert dev-dependencies.pretty_assertions "0.7.0"
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
2022-11-19 18:35:55 +01:00
|
|
|
assert!(actual
|
|
|
|
.err
|
|
|
|
.contains("column 'pretty_assertions' already exists"));
|
2022-03-17 18:55:02 +01:00
|
|
|
}
|
2022-03-18 22:12:54 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_into_list() {
|
2023-07-21 17:32:37 +02:00
|
|
|
let actual = nu!("[1, 2, 3] | insert 1 abc | to json -r");
|
2022-03-18 22:12:54 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, r#"[1,"abc",2,3]"#);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
fn insert_at_start_of_list() {
|
2023-07-21 17:32:37 +02:00
|
|
|
let actual = nu!("[1, 2, 3] | insert 0 abc | to json -r");
|
2022-03-18 22:12:54 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, r#"["abc",1,2,3]"#);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
fn insert_at_end_of_list() {
|
2023-07-21 17:32:37 +02:00
|
|
|
let actual = nu!("[1, 2, 3] | insert 3 abc | to json -r");
|
2022-03-18 22:12:54 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, r#"[1,2,3,"abc"]"#);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
fn insert_past_end_of_list() {
|
|
|
|
let actual = nu!("[1, 2, 3] | insert 5 abc");
|
2022-03-18 22:12:54 +01:00
|
|
|
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
assert!(actual
|
|
|
|
.err
|
|
|
|
.contains("can't insert at index (the next available index is 3)"));
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_into_list_stream() {
|
|
|
|
let actual = nu!("[1, 2, 3] | every 1 | insert 1 abc | to json -r");
|
|
|
|
|
|
|
|
assert_eq!(actual.out, r#"[1,"abc",2,3]"#);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_at_end_of_list_stream() {
|
|
|
|
let actual = nu!("[1, 2, 3] | every 1 | insert 3 abc | to json -r");
|
|
|
|
|
|
|
|
assert_eq!(actual.out, r#"[1,2,3,"abc"]"#);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_past_end_of_list_stream() {
|
|
|
|
let actual = nu!("[1, 2, 3] | every 1 | insert 5 abc");
|
|
|
|
|
|
|
|
assert!(actual
|
|
|
|
.err
|
|
|
|
.contains("can't insert at index (the next available index is 3)"));
|
2022-03-18 22:12:54 +01:00
|
|
|
}
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
#[test]
|
2023-02-02 23:59:58 +01:00
|
|
|
fn insert_uses_enumerate_index() {
|
2022-11-21 14:35:11 +01:00
|
|
|
let actual = nu!(
|
2023-07-21 17:32:37 +02:00
|
|
|
"[[a]; [7] [6]] | enumerate | insert b {|el| $el.index + 1 + $el.item.a } | flatten | to nuon"
|
2023-07-17 18:43:51 +02:00
|
|
|
);
|
2022-11-21 14:35:11 +01:00
|
|
|
|
2023-02-02 23:59:58 +01:00
|
|
|
assert_eq!(actual.out, "[[index, a, b]; [0, 7, 8], [1, 6, 8]]");
|
2022-11-21 14:35:11 +01:00
|
|
|
}
|
2023-05-31 13:27:55 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_support_lazy_record() {
|
|
|
|
let actual =
|
|
|
|
nu!(r#"let x = (lazy make -c ["h"] -g {|a| $a | str upcase}); $x | insert a 10 | get a"#);
|
|
|
|
assert_eq!(actual.out, "10");
|
|
|
|
}
|
allow `values` command to support `LazyRecord`s (#10418)
# Description
This PR allows the `values` command to support lazy records.
closes https://github.com/nushell/nushell/issues/10417
### Before
```nushell
sys | values
Error: nu::shell::only_supports_this_input_type
× Input type not supported.
╭─[entry #1:1:1]
1 │ sys | values
· ─┬─ ───┬──
· │ ╰── only record or table input data is supported
· ╰── input type: record<host: record<name: string, os_version: string, long_os_version: string, kernel_version: string, hostname: string, uptime: duration, boot_time: string, sessions: list<any>>, cpu: table<name: string, brand: string, freq: int, cpu_usage: float, load_average: string, vendor_id: string>, disks: table<device: string, type: string, mount: string, total: filesize, free: filesize, removable: bool, kind: string>, mem: record<total: filesize, free: filesize, used: filesize, available: filesize, swap total: filesize, swap free: filesize, swap used: filesize>, temp: list<any>, net: table<name: string, sent: filesize, recv: filesize>>
╰────
```
### After
```nushell
❯ sys | values
╭─┬─────────────────╮
│0│{record 8 fields}│
│1│[table 16 rows] │
│2│[table 1 row] │
│3│{record 7 fields}│
│4│[list 0 items] │
│5│[table 5 rows] │
╰─┴─────────────────╯
```
# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2023-09-20 19:57:29 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn lazy_record_test_values() {
|
|
|
|
let actual = nu!(
|
|
|
|
r#"lazy make --columns ["haskell", "futures", "nushell"] --get-value { |lazything| $lazything + "!" } | values | length"#
|
|
|
|
);
|
|
|
|
assert_eq!(actual.out, "3");
|
|
|
|
}
|
2023-11-19 21:46:41 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn deep_cell_path_creates_all_nested_records() {
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
let actual = nu!("{a: {}} | insert a.b.c 0 | get a.b.c");
|
2023-11-19 21:46:41 +01:00
|
|
|
assert_eq!(actual.out, "0");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn inserts_all_rows_in_table_in_record() {
|
|
|
|
let actual = nu!(
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
"{table: [[col]; [{a: 1}], [{a: 1}]]} | insert table.col.b 2 | get table.col.b | to nuon"
|
2023-11-19 21:46:41 +01:00
|
|
|
);
|
|
|
|
assert_eq!(actual.out, "[2, 2]");
|
|
|
|
}
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn list_replacement_closure() {
|
|
|
|
let actual = nu!("[1, 2] | insert 1 {|i| $i + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3, 2]");
|
|
|
|
|
|
|
|
let actual = nu!("[1, 2] | insert 1 { $in + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3, 2]");
|
|
|
|
|
|
|
|
let actual = nu!("[1, 2] | insert 2 {|i| if $i == null { 0 } else { $in + 1 } } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 2, 0]");
|
|
|
|
|
|
|
|
let actual = nu!("[1, 2] | insert 2 { if $in == null { 0 } else { $in + 1 } } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 2, 0]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn record_replacement_closure() {
|
|
|
|
let actual = nu!("{ a: text } | insert b {|r| $r.a | str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "{a: text, b: TEXT}");
|
|
|
|
|
|
|
|
let actual = nu!("{ a: text } | insert b { default TEXT } | to nuon");
|
|
|
|
assert_eq!(actual.out, "{a: text, b: TEXT}");
|
|
|
|
|
|
|
|
let actual = nu!("{ a: { b: 1 } } | insert a.c {|r| $r.a.b } | to nuon");
|
|
|
|
assert_eq!(actual.out, "{a: {b: 1, c: 1}}");
|
|
|
|
|
|
|
|
let actual = nu!("{ a: { b: 1 } } | insert a.c { default 0 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "{a: {b: 1, c: 0}}");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn table_replacement_closure() {
|
|
|
|
let actual = nu!("[[a]; [text]] | insert b {|r| $r.a | str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a, b]; [text, TEXT]]");
|
|
|
|
|
|
|
|
let actual = nu!("[[a]; [text]] | insert b { default TEXT } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a, b]; [text, TEXT]]");
|
|
|
|
|
|
|
|
let actual = nu!("[[b]; [1]] | wrap a | insert a.c {|r| $r.a.b } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [{b: 1, c: 1}]]");
|
|
|
|
|
|
|
|
let actual = nu!("[[b]; [1]] | wrap a | insert a.c { default 0 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [{b: 1, c: 0}]]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn list_stream_replacement_closure() {
|
|
|
|
let actual = nu!("[1, 2] | every 1 | insert 1 {|i| $i + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3, 2]");
|
|
|
|
|
|
|
|
let actual = nu!("[1, 2] | every 1 | insert 1 { $in + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3, 2]");
|
|
|
|
|
|
|
|
let actual =
|
|
|
|
nu!("[1, 2] | every 1 | insert 2 {|i| if $i == null { 0 } else { $in + 1 } } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 2, 0]");
|
|
|
|
|
|
|
|
let actual =
|
|
|
|
nu!("[1, 2] | every 1 | insert 2 { if $in == null { 0 } else { $in + 1 } } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 2, 0]");
|
|
|
|
|
|
|
|
let actual = nu!("[[a]; [text]] | every 1 | insert b {|r| $r.a | str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a, b]; [text, TEXT]]");
|
|
|
|
|
|
|
|
let actual = nu!("[[a]; [text]] | every 1 | insert b { default TEXT } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a, b]; [text, TEXT]]");
|
|
|
|
}
|