2023-04-07 23:09:55 +02:00
|
|
|
use nu_test_support::nu;
|
2022-06-30 03:01:34 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn capture_errors_works() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!("do -c {$env.use}");
|
2022-06-30 03:01:34 +02:00
|
|
|
|
2022-11-24 04:58:15 +01:00
|
|
|
eprintln!("actual.err: {:?}", actual.err);
|
|
|
|
|
2022-09-30 14:14:02 +02:00
|
|
|
assert!(actual.err.contains("column_not_found"));
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn capture_errors_works_for_external() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!("do -c {nu --testbin fail}");
|
Error on non-zero exit statuses (#13515)
# Description
This PR makes it so that non-zero exit codes and termination by signal
are treated as a normal `ShellError`. Currently, these are silent
errors. That is, if an external command fails, then it's code block is
aborted, but the parent block can sometimes continue execution. E.g.,
see #8569 and this example:
```nushell
[1 2] | each { ^false }
```
Before this would give:
```
╭───┬──╮
│ 0 │ │
│ 1 │ │
╰───┴──╯
```
Now, this shows an error:
```
Error: nu::shell::eval_block_with_input
× Eval block failed with pipeline input
╭─[entry #1:1:2]
1 │ [1 2] | each { ^false }
· ┬
· ╰── source value
╰────
Error: nu::shell::non_zero_exit_code
× External command had a non-zero exit code
╭─[entry #1:1:17]
1 │ [1 2] | each { ^false }
· ──┬──
· ╰── exited with code 1
╰────
```
This PR fixes #12874, fixes #5960, fixes #10856, and fixes #5347. This
PR also partially addresses #10633 and #10624 (only the last command of
a pipeline is currently checked). It looks like #8569 is already fixed,
but this PR will make sure it is definitely fixed (fixes #8569).
# User-Facing Changes
- Non-zero exit codes and termination by signal now cause an error to be
thrown.
- The error record value passed to a `catch` block may now have an
`exit_code` column containing the integer exit code if the error was due
to an external command.
- Adds new config values, `display_errors.exit_code` and
`display_errors.termination_signal`, which determine whether an error
message should be printed in the respective error cases. For
non-interactive sessions, these are set to `true`, and for interactive
sessions `display_errors.exit_code` is false (via the default config).
# Tests
Added a few tests.
# After Submitting
- Update docs and book.
- Future work:
- Error if other external commands besides the last in a pipeline exit
with a non-zero exit code. Then, deprecate `do -c` since this will be
the default behavior everywhere.
- Add a better mechanism for exit codes and deprecate
`$env.LAST_EXIT_CODE` (it's buggy).
2024-09-07 08:44:26 +02:00
|
|
|
assert!(actual.err.contains("exited with code"));
|
2022-09-30 14:14:02 +02:00
|
|
|
assert_eq!(actual.out, "");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn capture_errors_works_for_external_with_pipeline() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!("do -c {nu --testbin fail} | echo `text`");
|
Error on non-zero exit statuses (#13515)
# Description
This PR makes it so that non-zero exit codes and termination by signal
are treated as a normal `ShellError`. Currently, these are silent
errors. That is, if an external command fails, then it's code block is
aborted, but the parent block can sometimes continue execution. E.g.,
see #8569 and this example:
```nushell
[1 2] | each { ^false }
```
Before this would give:
```
╭───┬──╮
│ 0 │ │
│ 1 │ │
╰───┴──╯
```
Now, this shows an error:
```
Error: nu::shell::eval_block_with_input
× Eval block failed with pipeline input
╭─[entry #1:1:2]
1 │ [1 2] | each { ^false }
· ┬
· ╰── source value
╰────
Error: nu::shell::non_zero_exit_code
× External command had a non-zero exit code
╭─[entry #1:1:17]
1 │ [1 2] | each { ^false }
· ──┬──
· ╰── exited with code 1
╰────
```
This PR fixes #12874, fixes #5960, fixes #10856, and fixes #5347. This
PR also partially addresses #10633 and #10624 (only the last command of
a pipeline is currently checked). It looks like #8569 is already fixed,
but this PR will make sure it is definitely fixed (fixes #8569).
# User-Facing Changes
- Non-zero exit codes and termination by signal now cause an error to be
thrown.
- The error record value passed to a `catch` block may now have an
`exit_code` column containing the integer exit code if the error was due
to an external command.
- Adds new config values, `display_errors.exit_code` and
`display_errors.termination_signal`, which determine whether an error
message should be printed in the respective error cases. For
non-interactive sessions, these are set to `true`, and for interactive
sessions `display_errors.exit_code` is false (via the default config).
# Tests
Added a few tests.
# After Submitting
- Update docs and book.
- Future work:
- Error if other external commands besides the last in a pipeline exit
with a non-zero exit code. Then, deprecate `do -c` since this will be
the default behavior everywhere.
- Add a better mechanism for exit codes and deprecate
`$env.LAST_EXIT_CODE` (it's buggy).
2024-09-07 08:44:26 +02:00
|
|
|
assert!(actual.err.contains("exited with code"));
|
2022-09-30 14:14:02 +02:00
|
|
|
assert_eq!(actual.out, "");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn capture_errors_works_for_external_with_semicolon() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!(r#"do -c {nu --testbin fail}; echo `text`"#);
|
Error on non-zero exit statuses (#13515)
# Description
This PR makes it so that non-zero exit codes and termination by signal
are treated as a normal `ShellError`. Currently, these are silent
errors. That is, if an external command fails, then it's code block is
aborted, but the parent block can sometimes continue execution. E.g.,
see #8569 and this example:
```nushell
[1 2] | each { ^false }
```
Before this would give:
```
╭───┬──╮
│ 0 │ │
│ 1 │ │
╰───┴──╯
```
Now, this shows an error:
```
Error: nu::shell::eval_block_with_input
× Eval block failed with pipeline input
╭─[entry #1:1:2]
1 │ [1 2] | each { ^false }
· ┬
· ╰── source value
╰────
Error: nu::shell::non_zero_exit_code
× External command had a non-zero exit code
╭─[entry #1:1:17]
1 │ [1 2] | each { ^false }
· ──┬──
· ╰── exited with code 1
╰────
```
This PR fixes #12874, fixes #5960, fixes #10856, and fixes #5347. This
PR also partially addresses #10633 and #10624 (only the last command of
a pipeline is currently checked). It looks like #8569 is already fixed,
but this PR will make sure it is definitely fixed (fixes #8569).
# User-Facing Changes
- Non-zero exit codes and termination by signal now cause an error to be
thrown.
- The error record value passed to a `catch` block may now have an
`exit_code` column containing the integer exit code if the error was due
to an external command.
- Adds new config values, `display_errors.exit_code` and
`display_errors.termination_signal`, which determine whether an error
message should be printed in the respective error cases. For
non-interactive sessions, these are set to `true`, and for interactive
sessions `display_errors.exit_code` is false (via the default config).
# Tests
Added a few tests.
# After Submitting
- Update docs and book.
- Future work:
- Error if other external commands besides the last in a pipeline exit
with a non-zero exit code. Then, deprecate `do -c` since this will be
the default behavior everywhere.
- Add a better mechanism for exit codes and deprecate
`$env.LAST_EXIT_CODE` (it's buggy).
2024-09-07 08:44:26 +02:00
|
|
|
assert!(actual.err.contains("exited with code"));
|
2022-09-30 14:14:02 +02:00
|
|
|
assert_eq!(actual.out, "");
|
2022-06-30 03:01:34 +02:00
|
|
|
}
|
2022-09-30 14:13:46 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn do_with_semicolon_break_on_failed_external() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!(r#"do { nu --not_exist_flag }; `text`"#);
|
2022-09-30 14:13:46 +02:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "");
|
|
|
|
}
|
2022-10-12 15:41:20 +02:00
|
|
|
|
2022-11-22 22:58:36 +01:00
|
|
|
#[test]
|
|
|
|
fn ignore_shell_errors_works_for_external_with_semicolon() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!(r#"do -s { open asdfasdf.txt }; "text""#);
|
2022-11-22 22:58:36 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.err, "");
|
|
|
|
assert_eq!(actual.out, "text");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn ignore_program_errors_works_for_external_with_semicolon() {
|
2024-04-10 00:27:46 +02:00
|
|
|
let actual = nu!(r#"do -p { nu -n -c 'exit 1' }; "text""#);
|
2022-11-22 22:58:36 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.err, "");
|
|
|
|
assert_eq!(actual.out, "text");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn ignore_error_should_work_for_external_command() {
|
2023-04-07 23:09:55 +02:00
|
|
|
let actual = nu!(r#"do -i { nu --testbin fail asdf }; echo post"#);
|
2022-11-22 22:58:36 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.err, "");
|
|
|
|
assert_eq!(actual.out, "post");
|
|
|
|
}
|
|
|
|
|
2023-02-02 00:04:53 +01:00
|
|
|
#[test]
|
|
|
|
fn ignore_error_works_with_list_stream() {
|
2023-09-26 18:49:28 +02:00
|
|
|
let actual = nu!(r#"do -i { ["a", null, "b"] | ansi strip }"#);
|
2023-02-02 00:04:53 +01:00
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
}
|
2024-05-17 02:03:13 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn run_closure_with_it_using() {
|
|
|
|
let actual = nu!(r#"let x = {let it = 3; $it}; do $x"#);
|
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
assert_eq!(actual.out, "3");
|
|
|
|
}
|
2024-09-22 16:26:32 +02:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn waits_for_external() {
|
|
|
|
let actual = nu!(r#"do -p { nu -c 'sleep 1sec; print before; exit 1'}; print after"#);
|
|
|
|
assert!(actual.err.is_empty());
|
|
|
|
assert_eq!(actual.out, "beforeafter");
|
|
|
|
}
|