2020-03-03 22:01:24 +01:00
|
|
|
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
|
|
use nu_test_support::playground::Playground;
|
2020-05-07 13:03:43 +02:00
|
|
|
use nu_test_support::{nu, pipeline};
|
2020-03-03 22:01:24 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn changes_the_column_name() {
|
|
|
|
Playground::setup("rename_test_1", |dirs, sandbox| {
|
|
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
|
|
"los_cuatro_mosqueteros.txt",
|
|
|
|
r#"
|
|
|
|
Andrés N. Robalino
|
2023-03-15 06:54:55 +01:00
|
|
|
JT Turner
|
2020-03-03 22:01:24 +01:00
|
|
|
Yehuda Katz
|
|
|
|
Jason Gedge
|
|
|
|
"#,
|
|
|
|
)]);
|
|
|
|
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: dirs.test(), pipeline(
|
|
|
|
r#"
|
|
|
|
open los_cuatro_mosqueteros.txt
|
|
|
|
| lines
|
|
|
|
| wrap name
|
|
|
|
| rename mosqueteros
|
|
|
|
| get mosqueteros
|
2021-03-13 22:46:40 +01:00
|
|
|
| length
|
2020-03-03 22:01:24 +01:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
2020-05-07 13:03:43 +02:00
|
|
|
assert_eq!(actual.out, "4");
|
2020-03-03 22:01:24 +01:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn keeps_remaining_original_names_given_less_new_names_than_total_original_names() {
|
|
|
|
Playground::setup("rename_test_2", |dirs, sandbox| {
|
|
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
|
|
"los_cuatro_mosqueteros.txt",
|
|
|
|
r#"
|
|
|
|
Andrés N. Robalino
|
2023-03-15 06:54:55 +01:00
|
|
|
JT Turner
|
2020-03-03 22:01:24 +01:00
|
|
|
Yehuda Katz
|
|
|
|
Jason Gedge
|
|
|
|
"#,
|
|
|
|
)]);
|
|
|
|
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: dirs.test(), pipeline(
|
|
|
|
r#"
|
|
|
|
open los_cuatro_mosqueteros.txt
|
|
|
|
| lines
|
|
|
|
| wrap name
|
2022-03-09 14:46:28 +01:00
|
|
|
| default "arepa!" hit
|
2020-03-03 22:01:24 +01:00
|
|
|
| rename mosqueteros
|
|
|
|
| get hit
|
2021-03-13 22:46:40 +01:00
|
|
|
| length
|
2020-03-03 22:01:24 +01:00
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
2020-05-07 13:03:43 +02:00
|
|
|
assert_eq!(actual.out, "4");
|
2020-03-03 22:01:24 +01:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn errors_if_no_columns_present() {
|
|
|
|
Playground::setup("rename_test_3", |dirs, sandbox| {
|
|
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
|
|
"los_cuatro_mosqueteros.txt",
|
|
|
|
r#"
|
|
|
|
Andrés N. Robalino
|
2023-03-15 06:54:55 +01:00
|
|
|
JT Turner
|
2020-03-03 22:01:24 +01:00
|
|
|
Yehuda Katz
|
|
|
|
Jason Gedge
|
|
|
|
"#,
|
|
|
|
)]);
|
|
|
|
|
2020-05-07 13:03:43 +02:00
|
|
|
let actual = nu!(
|
2020-03-03 22:01:24 +01:00
|
|
|
cwd: dirs.test(), pipeline(
|
|
|
|
r#"
|
|
|
|
open los_cuatro_mosqueteros.txt
|
|
|
|
| lines
|
|
|
|
| rename mosqueteros
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
Standardise the use of ShellError::UnsupportedInput and ShellError::TypeMismatch and add spans to every instance of the former (#7217)
# Description
* I was dismayed to discover recently that UnsupportedInput and
TypeMismatch are used *extremely* inconsistently across the codebase.
UnsupportedInput is sometimes used for input type-checks (as per the
name!!), but *also* used for argument type-checks. TypeMismatch is also
used for both.
I thus devised the following standard: input type-checking *only* uses
UnsupportedInput, and argument type-checking *only* uses TypeMismatch.
Moreover, to differentiate them, UnsupportedInput now has *two* error
arrows (spans), one pointing at the command and the other at the input
origin, while TypeMismatch only has the one (because the command should
always be nearby)
* In order to apply that standard, a very large number of
UnsupportedInput uses were changed so that the input's span could be
retrieved and delivered to it.
* Additionally, I noticed many places where **errors are not propagated
correctly**: there are lots of `match` sites which take a Value::Error,
then throw it away and replace it with a new Value::Error with
less/misleading information (such as reporting the error as an
"incorrect type"). I believe that the earliest errors are the most
important, and should always be propagated where possible.
* Also, to standardise one broad subset of UnsupportedInput error
messages, who all used slightly different wordings of "expected
`<type>`, got `<type>`", I created OnlySupportsThisInputType as a
variant of it.
* Finally, a bunch of error sites that had "repeated spans" - i.e. where
an error expected two spans, but `call.head` was given for both - were
fixed to use different spans.
# Example
BEFORE
```
〉20b | str starts-with 'a'
Error: nu::shell::unsupported_input (link)
× Unsupported input
╭─[entry #31:1:1]
1 │ 20b | str starts-with 'a'
· ┬
· ╰── Input's type is filesize. This command only works with strings.
╰────
〉'a' | math cos
Error: nu::shell::unsupported_input (link)
× Unsupported input
╭─[entry #33:1:1]
1 │ 'a' | math cos
· ─┬─
· ╰── Only numerical values are supported, input type: String
╰────
〉0x[12] | encode utf8
Error: nu::shell::unsupported_input (link)
× Unsupported input
╭─[entry #38:1:1]
1 │ 0x[12] | encode utf8
· ───┬──
· ╰── non-string input
╰────
```
AFTER
```
〉20b | str starts-with 'a'
Error: nu::shell::pipeline_mismatch (link)
× Pipeline mismatch.
╭─[entry #1:1:1]
1 │ 20b | str starts-with 'a'
· ┬ ───────┬───────
· │ ╰── only string input data is supported
· ╰── input type: filesize
╰────
〉'a' | math cos
Error: nu::shell::pipeline_mismatch (link)
× Pipeline mismatch.
╭─[entry #2:1:1]
1 │ 'a' | math cos
· ─┬─ ────┬───
· │ ╰── only numeric input data is supported
· ╰── input type: string
╰────
〉0x[12] | encode utf8
Error: nu::shell::pipeline_mismatch (link)
× Pipeline mismatch.
╭─[entry #3:1:1]
1 │ 0x[12] | encode utf8
· ───┬── ───┬──
· │ ╰── only string input data is supported
· ╰── input type: binary
╰────
```
# User-Facing Changes
Various error messages suddenly make more sense (i.e. have two arrows
instead of one).
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-23 07:48:53 +01:00
|
|
|
assert!(actual.err.contains("only record input data is supported"));
|
2020-03-03 22:01:24 +01:00
|
|
|
})
|
|
|
|
}
|
2023-02-15 22:47:27 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn errors_if_columns_param_is_empty() {
|
|
|
|
Playground::setup("rename_test_4", |dirs, sandbox| {
|
|
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
|
|
"los_cuatro_mosqueteros.txt",
|
|
|
|
r#"
|
|
|
|
Andrés N. Robalino
|
2023-03-15 06:54:55 +01:00
|
|
|
JT Turner
|
2023-02-15 22:47:27 +01:00
|
|
|
Yehuda Katz
|
|
|
|
Jason Gedge
|
|
|
|
"#,
|
|
|
|
)]);
|
|
|
|
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: dirs.test(), pipeline(
|
|
|
|
r#"
|
|
|
|
open los_cuatro_mosqueteros.txt
|
|
|
|
| lines
|
|
|
|
| wrap name
|
|
|
|
| default "arepa!" hit
|
|
|
|
| rename -c []
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert!(actual.err.contains("The column list cannot be empty"));
|
|
|
|
})
|
|
|
|
}
|