2019-12-17 19:54:39 +01:00
|
|
|
use nu_test_support::{nu, pipeline};
|
2019-12-15 17:15:06 +01:00
|
|
|
|
|
|
|
#[test]
|
2020-04-30 06:18:24 +02:00
|
|
|
fn sets_the_column() {
|
2019-12-15 17:15:06 +01:00
|
|
|
let actual = nu!(
|
|
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
|
|
r#"
|
|
|
|
open cargo_sample.toml
|
2022-03-17 18:55:02 +01:00
|
|
|
| update dev-dependencies.pretty_assertions "0.7.0"
|
2019-12-15 17:15:06 +01:00
|
|
|
| get dev-dependencies.pretty_assertions
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
2020-05-07 13:03:43 +02:00
|
|
|
assert_eq!(actual.out, "0.7.0");
|
2020-04-30 06:18:24 +02:00
|
|
|
}
|
|
|
|
|
2022-11-21 14:35:11 +01:00
|
|
|
#[test]
|
|
|
|
fn doesnt_convert_record_to_table() {
|
2023-04-28 13:25:44 +02:00
|
|
|
let actual = nu!("{a:1} | update a 2 | to nuon");
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
assert_eq!(actual.out, "{a: 2}");
|
|
|
|
}
|
|
|
|
|
2020-08-12 09:51:24 +02:00
|
|
|
#[test]
|
|
|
|
fn sets_the_column_from_a_block_full_stream_output() {
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
|
|
r#"
|
2022-12-07 19:31:57 +01:00
|
|
|
{content: null}
|
Restrict closure expression to be something like `{|| ...}` (#8290)
# Description
As title, closes: #7921 closes: #8273
# User-Facing Changes
when define a closure without pipe, nushell will raise error for now:
```
❯ let x = {ss ss}
Error: nu::parser::closure_missing_pipe
× Missing || inside closure
╭─[entry #2:1:1]
1 │ let x = {ss ss}
· ───┬───
· ╰── Parsing as a closure, but || is missing
╰────
help: Try add || to the beginning of closure
```
`any`, `each`, `all`, `where` command accepts closure, it forces user
input closure like `{||`, or parse error will returned.
```
❯ {major:2, minor:1, patch:4} | values | each { into string }
Error: nu::parser::closure_missing_pipe
× Missing || inside closure
╭─[entry #4:1:1]
1 │ {major:2, minor:1, patch:4} | values | each { into string }
· ───────┬───────
· ╰── Parsing as a closure, but || is missing
╰────
help: Try add || to the beginning of closure
```
`with-env`, `do`, `def`, `try` are special, they still remain the same,
although it says that it accepts a closure, but they don't need to be
written like `{||`, it's more likely a block but can capture variable
outside of scope:
```
❯ def test [input] { echo [0 1 2] | do { do { echo $input } } }; test aaa
aaa
```
Just realize that It's a big breaking change, we need to update config
and scripts...
# Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass
# After Submitting
If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-03-17 13:36:28 +01:00
|
|
|
| update content {|| open --raw cargo_sample.toml | lines | first 5 }
|
2020-08-12 09:51:24 +02:00
|
|
|
| get content.1
|
|
|
|
| str contains "nu"
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "true");
|
|
|
|
}
|
2020-08-26 12:56:45 +02:00
|
|
|
|
|
|
|
#[test]
|
2021-06-07 10:08:35 +02:00
|
|
|
fn sets_the_column_from_a_subexpression() {
|
2020-08-26 12:56:45 +02:00
|
|
|
let actual = nu!(
|
|
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
|
|
r#"
|
2022-12-07 19:31:57 +01:00
|
|
|
{content: null}
|
2022-03-17 18:55:02 +01:00
|
|
|
| update content (open --raw cargo_sample.toml | lines | first 5)
|
2020-08-26 12:56:45 +02:00
|
|
|
| get content.1
|
|
|
|
| str contains "nu"
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert_eq!(actual.out, "true");
|
|
|
|
}
|
2022-03-17 18:55:02 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn upsert_column_missing() {
|
|
|
|
let actual = nu!(
|
|
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
|
|
r#"
|
|
|
|
open cargo_sample.toml
|
|
|
|
| update dev-dependencies.new_assertions "0.7.0"
|
|
|
|
"#
|
|
|
|
));
|
|
|
|
|
|
|
|
assert!(actual.err.contains("cannot find column"));
|
|
|
|
}
|
2022-03-18 22:12:54 +01:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn update_list() {
|
2023-04-28 13:25:44 +02:00
|
|
|
let actual = nu!("[1, 2, 3] | update 1 abc | to json -r");
|
2022-03-18 22:12:54 +01:00
|
|
|
assert_eq!(actual.out, r#"[1,"abc",3]"#);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
fn update_past_end_of_list() {
|
2023-04-28 13:25:44 +02:00
|
|
|
let actual = nu!("[1, 2, 3] | update 5 abc | to json -r");
|
2022-03-18 22:12:54 +01:00
|
|
|
assert!(actual.err.contains("too large"));
|
|
|
|
}
|
2022-11-19 18:35:55 +01:00
|
|
|
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
#[test]
|
|
|
|
fn update_list_stream() {
|
|
|
|
let actual = nu!("[1, 2, 3] | every 1 | update 1 abc | to json -r");
|
|
|
|
assert_eq!(actual.out, r#"[1,"abc",3]"#);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn update_past_end_of_list_stream() {
|
|
|
|
let actual = nu!("[1, 2, 3] | every 1 | update 5 abc | to json -r");
|
|
|
|
assert!(actual.err.contains("too large"));
|
|
|
|
}
|
|
|
|
|
2022-11-19 18:35:55 +01:00
|
|
|
#[test]
|
|
|
|
fn update_nonexistent_column() {
|
2023-04-28 13:25:44 +02:00
|
|
|
let actual = nu!("{a:1} | update b 2");
|
2022-11-19 18:35:55 +01:00
|
|
|
assert!(actual.err.contains("cannot find column 'b'"));
|
|
|
|
}
|
2022-11-21 14:35:11 +01:00
|
|
|
|
|
|
|
#[test]
|
2023-02-02 23:59:58 +01:00
|
|
|
fn update_uses_enumerate_index() {
|
2022-11-21 14:35:11 +01:00
|
|
|
let actual = nu!(
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
"[[a]; [7] [6]] | enumerate | update item.a {|el| $el.index + 1 + $el.item.a } | flatten | to nuon"
|
2023-04-28 13:25:44 +02:00
|
|
|
);
|
2022-11-21 14:35:11 +01:00
|
|
|
|
2023-02-02 23:59:58 +01:00
|
|
|
assert_eq!(actual.out, "[[index, a]; [0, 8], [1, 8]]");
|
2022-11-21 14:35:11 +01:00
|
|
|
}
|
2023-05-31 13:27:55 +02:00
|
|
|
|
Fix replacement closures for `update`, `insert`, and `upsert` (#11258)
# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.
# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.
# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests
2023-12-09 22:22:45 +01:00
|
|
|
#[test]
|
|
|
|
fn list_replacement_closure() {
|
|
|
|
let actual = nu!("[1, 2] | update 1 {|i| $i + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3]");
|
|
|
|
|
|
|
|
let actual = nu!("[1, 2] | update 1 { $in + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn record_replacement_closure() {
|
|
|
|
let actual = nu!("{ a: text } | update a {|r| $r.a | str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "{a: TEXT}");
|
|
|
|
|
|
|
|
let actual = nu!("{ a: text } | update a { str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "{a: TEXT}");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn table_replacement_closure() {
|
|
|
|
let actual = nu!("[[a]; [text]] | update a {|r| $r.a | str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [TEXT]]");
|
|
|
|
|
|
|
|
let actual = nu!("[[a]; [text]] | update a { str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [TEXT]]");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn list_stream_replacement_closure() {
|
|
|
|
let actual = nu!("[1, 2] | every 1 | update 1 {|i| $i + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3]");
|
|
|
|
|
|
|
|
let actual = nu!("[1, 2] | every 1 | update 1 { $in + 1 } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[1, 3]");
|
|
|
|
|
|
|
|
let actual = nu!("[[a]; [text]] | every 1 | update a {|r| $r.a | str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [TEXT]]");
|
|
|
|
|
|
|
|
let actual = nu!("[[a]; [text]] | every 1 | update a { str upcase } | to nuon");
|
|
|
|
assert_eq!(actual.out, "[[a]; [TEXT]]");
|
|
|
|
}
|