extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-11-25 01:43:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix stop suggesting --trash when already enabled (issue #12361) (#12362)

Browse Source 
fixes #12361

Looking at the condition, `TRASH_SUPPORTED && (trash || (rm_always_trash
&& !permanent))`, this code path seems only to run when `--trash` is
enabled and `--permanent` is disabled.

This suggests that the `--trash` suggestion is a mistake and should have
suggested `--permanent`.
This commit is contained in:
Ethan Brierley 2024-04-06 02:28:40 +01:00 committed by GitHub
parent 88ff622b16
commit 00b576b7f1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/nu-command/src/filesystem/rm.rs
View File

@ -382,7 +382,10 @@ fn rm(
))] ))]
{ {
trash::delete(&f).map_err(|e: trash::Error| { trash::delete(&f).map_err(|e: trash::Error| {
Error::new(ErrorKind::Other, format!("{e:?}\nTry '--trash' flag")) Error::new(
ErrorKind::Other,
format!("{e:?}\nTry '--permanent' flag"),
)
}) })
} }