extern/nushell
1
0
Fork 1
mirror of https://github.com/nushell/nushell.git synced 2024-11-26 02:13:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Disable flaky network tests (#12010)

Browse Source 
# Description
Ignores some network tests that sometimes fail in CI. E.g., in
[11953](https://github.com/nushell/nushell/pull/11953#issuecomment-1962275863)
and
[11654](https://github.com/nushell/nushell/pull/11654#issuecomment-1968404551).
This commit is contained in:
Ian Manske 2024-02-28 16:28:33 +00:00 committed by GitHub
parent 387328fe73
commit 0126620c19
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/nu-command/tests/commands/network/http/get.rs
View File

@ -243,26 +243,32 @@ fn http_get_redirect_mode_error() {
// These tests require network access; they use badssl.com which is a Google-affiliated site for testing various SSL errors. // These tests require network access; they use badssl.com which is a Google-affiliated site for testing various SSL errors.
// Revisit this if these tests prove to be flaky or unstable. // Revisit this if these tests prove to be flaky or unstable.
//
// These tests are flaky and cause CI to fail somewhat regularly. See PR #12010.
#[test] #[test]
#[ignore = "unreliable test"]
fn http_get_expired_cert_fails() { fn http_get_expired_cert_fails() {
let actual = nu!("http get https://expired.badssl.com/"); let actual = nu!("http get https://expired.badssl.com/");
assert!(actual.err.contains("network_failure")); assert!(actual.err.contains("network_failure"));
} }
#[test] #[test]
#[ignore = "unreliable test"]
fn http_get_expired_cert_override() { fn http_get_expired_cert_override() {
let actual = nu!("http get --insecure https://expired.badssl.com/"); let actual = nu!("http get --insecure https://expired.badssl.com/");
assert!(actual.out.contains("<html>")); assert!(actual.out.contains("<html>"));
} }
#[test] #[test]
#[ignore = "unreliable test"]
fn http_get_self_signed_fails() { fn http_get_self_signed_fails() {
let actual = nu!("http get https://self-signed.badssl.com/"); let actual = nu!("http get https://self-signed.badssl.com/");
assert!(actual.err.contains("network_failure")); assert!(actual.err.contains("network_failure"));
} }
#[test] #[test]
#[ignore = "unreliable test"]
fn http_get_self_signed_override() { fn http_get_self_signed_override() {
let actual = nu!("http get --insecure https://self-signed.badssl.com/"); let actual = nu!("http get --insecure https://self-signed.badssl.com/");
assert!(actual.out.contains("<html>")); assert!(actual.out.contains("<html>"));