Use heck instead of convert_case for nu-derive-value (#13708)

<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx

you can also mention related issues, PRs or discussions!
-->

# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.

Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
@sholderbach mentioned that I introduced `convert_case` as a dependency
while we already had `heck` for case conversion. So in this PR replaced
the use `convert_case` with `heck`. Mostly I rebuilt the `convert_case`
API with `heck` to work with it as I like the API of `convert_case` more
than `heck`.

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->
Nothing changed, the use of `convert_case` wasn't exposed anywhere and
all case conversions are still available.

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the
tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
No new tests required but my tests in `test_derive` captured some errors
I made while developing this change, (hurray, tests work 🎉)
- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
This commit is contained in:
Piepmatz
2024-08-28 15:02:25 +02:00
committed by GitHub
parent af76e11dd6
commit 055d7e27e9
11 changed files with 100 additions and 50 deletions

View File

@ -0,0 +1,72 @@
use heck::*;
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
pub enum Case {
// directly supported by heck
Pascal,
Camel,
Snake,
Kebab,
ScreamingSnake,
Title,
Cobol,
Train,
// custom variants
Upper,
Lower,
Flat,
ScreamingFlat,
}
impl Case {
pub fn from_str(s: impl AsRef<str>) -> Option<Self> {
match s.as_ref() {
// The matched case are all useful variants from `convert_case` with aliases
// that `serde` uses.
"PascalCase" | "UpperCamelCase" => Case::Pascal,
"camelCase" | "lowerCamelCase" => Case::Camel,
"snake_case" => Case::Snake,
"kebab-case" => Case::Kebab,
"SCREAMING_SNAKE_CASE" | "UPPER_SNAKE_CASE" | "SHOUTY_SNAKE_CASE" => {
Case::ScreamingSnake
}
"Title Case" => Case::Title,
"COBOL-CASE" | "SCREAMING-KEBAB-CASE" | "UPPER-KEBAB-CASE" => Case::Cobol,
"Train-Case" => Case::Train,
"UPPER CASE" | "UPPER WITH SPACES CASE" => Case::Upper,
"lower case" | "lower with spaces case" => Case::Lower,
"flatcase" | "lowercase" => Case::Flat,
"SCREAMINGFLATCASE" | "UPPERFLATCASE" | "UPPERCASE" => Case::ScreamingFlat,
_ => return None,
}
.into()
}
}
pub trait Casing {
fn to_case(&self, case: Case) -> String;
}
impl<T: AsRef<str>> Casing for T {
fn to_case(&self, case: Case) -> String {
let s = self.as_ref();
match case {
Case::Pascal => s.to_upper_camel_case(),
Case::Camel => s.to_lower_camel_case(),
Case::Snake => s.to_snake_case(),
Case::Kebab => s.to_kebab_case(),
Case::ScreamingSnake => s.to_shouty_snake_case(),
Case::Title => s.to_title_case(),
Case::Cobol => s.to_shouty_kebab_case(),
Case::Train => s.to_train_case(),
Case::Upper => s.to_shouty_snake_case().replace('_', " "),
Case::Lower => s.to_snake_case().replace('_', " "),
Case::Flat => s.to_snake_case().replace('_', ""),
Case::ScreamingFlat => s.to_shouty_snake_case().replace('_', ""),
}
}
}