mirror of
https://github.com/nushell/nushell.git
synced 2025-06-30 22:50:14 +02:00
couple minor updates to xml deps (#7311)
# Description Just some minor updates to xml deps # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This commit is contained in:
@ -117,7 +117,7 @@ pub fn write_xml_events<W: Write>(
|
||||
match current {
|
||||
Value::Record { cols, vals, span } => {
|
||||
for (k, v) in cols.iter().zip(vals.iter()) {
|
||||
let mut e = BytesStart::owned(k.as_bytes(), k.len());
|
||||
let mut e = BytesStart::new(k);
|
||||
if !is_xml_row(v) {
|
||||
return Err(ShellError::GenericError(
|
||||
"Expected a row with 'children' and 'attributes' columns".to_string(),
|
||||
@ -141,7 +141,7 @@ pub fn write_xml_events<W: Write>(
|
||||
}
|
||||
}
|
||||
writer
|
||||
.write_event(Event::End(BytesEnd::borrowed(k.as_bytes())))
|
||||
.write_event(Event::End(BytesEnd::new(k)))
|
||||
.expect("Couldn't close XML node");
|
||||
}
|
||||
}
|
||||
@ -153,7 +153,7 @@ pub fn write_xml_events<W: Write>(
|
||||
_ => {
|
||||
let s = current.into_abbreviated_string(config);
|
||||
writer
|
||||
.write_event(Event::Text(BytesText::from_plain_str(s.as_str())))
|
||||
.write_event(Event::Text(BytesText::from_escaped(s.as_str())))
|
||||
.expect("Couldn't write XML text");
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user