make ls works better with glob (#5691)

* fix glob behavior

* fix doc

crates/nu-command/src/filesystem/cp.rs

@@ -19,6 +19,7 @@ const GLOB_PARAMS: nu_glob::MatchOptions = nu_glob::MatchOptions {
     case_sensitive: true,
     require_literal_separator: false,
     require_literal_leading_dot: false,
+    recursive_match_hidden_dir: true,
 };
 
 #[derive(Clone)]

crates/nu-command/src/filesystem/ls.rs

@@ -3,6 +3,7 @@ use crate::DirInfo;
 use chrono::{DateTime, Local, LocalResult, TimeZone, Utc};
 use nu_engine::env::current_dir;
 use nu_engine::CallExt;
+use nu_glob::MatchOptions;
 use nu_path::expand_to_real_path;
 use nu_protocol::ast::Call;
 use nu_protocol::engine::{Command, EngineState, Stack};
@@ -128,7 +129,15 @@ impl Command for Ls {
             item: path.display().to_string(),
             span: p_tag,
         };
-        let (prefix, paths) = nu_engine::glob_from(&glob_path, &cwd, call_span)?;
+
+        let glob_options = if all {
+            None
+        } else {
+            let mut glob_options = MatchOptions::new();
+            glob_options.recursive_match_hidden_dir = false;
+            Some(glob_options)
+        };
+        let (prefix, paths) = nu_engine::glob_from(&glob_path, &cwd, call_span, glob_options)?;
 
         let mut paths_peek = paths.peekable();
         if paths_peek.peek().is_none() {

crates/nu-command/src/filesystem/mv.rs

@@ -14,6 +14,7 @@ const GLOB_PARAMS: nu_glob::MatchOptions = nu_glob::MatchOptions {
     case_sensitive: true,
     require_literal_separator: false,
     require_literal_leading_dot: false,
+    recursive_match_hidden_dir: true,
 };
 
 #[derive(Clone)]

crates/nu-command/src/filesystem/rm.rs

@@ -24,6 +24,7 @@ const GLOB_PARAMS: nu_glob::MatchOptions = nu_glob::MatchOptions {
     case_sensitive: true,
     require_literal_separator: false,
     require_literal_leading_dot: false,
+    recursive_match_hidden_dir: true,
 };
 
 #[derive(Clone)]

crates/nu-command/src/platform/du.rs

@@ -14,6 +14,7 @@ const GLOB_PARAMS: MatchOptions = MatchOptions {
     case_sensitive: true,
     require_literal_separator: true,
     require_literal_leading_dot: false,
+    recursive_match_hidden_dir: true,
 };
 
 #[derive(Clone)]

crates/nu-command/src/system/run_external.rs

@@ -417,7 +417,9 @@ impl ExternalCommand {
             let cwd = PathBuf::from(cwd);
 
             if arg.item.contains('*') {
-                if let Ok((prefix, matches)) = nu_engine::glob_from(&arg, &cwd, self.name.span) {
+                if let Ok((prefix, matches)) =
+                    nu_engine::glob_from(&arg, &cwd, self.name.span, None)
+                {
                     let matches: Vec<_> = matches.collect();
 
                     // FIXME: do we want to special-case this further? We might accidentally expand when they don't

crates/nu-command/tests/commands/ls.rs

@@ -244,6 +244,42 @@ fn lists_all_hidden_files_when_glob_does_not_contain_dot() {
     })
 }
 
+#[test]
+// TODO Remove this cfg value when we have an OS-agnostic way
+// of creating hidden files using the playground.
+#[cfg(unix)]
+fn glob_with_hidden_directory() {
+    Playground::setup("ls_test_8", |dirs, sandbox| {
+        sandbox.within(".dir_b").with_files(vec![
+            EmptyFile("andres.10.txt"),
+            EmptyFile("chicken_not_to_be_picked_up.100.txt"),
+            EmptyFile(".dotfile3"),
+        ]);
+
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ls **/*
+                | length
+            "#
+        ));
+
+        assert_eq!(actual.out, "");
+        assert!(actual.err.contains("No matches found"));
+
+        // will list files if provide `-a` flag.
+        let actual = nu!(
+            cwd: dirs.test(), pipeline(
+            r#"
+                ls -a **/*
+                | length
+            "#
+        ));
+
+        assert_eq!(actual.out, "4");
+    })
+}
+
 #[test]
 #[cfg(unix)]
 fn fails_with_ls_to_dir_without_permission() {